Created attachment 146857 [details]
Notes and warnings — before and after
It’s always bothered me that notes are yellow instead of green, and warnings are red instead of yellow. It creates cognitive dissonances across the help content.
To solve this, the browser-based help should use the icons from core/icon-themes/colibre_svg/res/helpimg instead of from core/icon-themes/colibre_svg/help (I don’t know why the latter folder exists — it’s just duplication).
Once solved, the note icon should become a green check mark instead of a yellow clipboard, and the warning icon should become a yellow shield instead of a red alert sign.
See the attachment for details.
Don't think it needs UX.
We have defined the colors for the info bar in a similar way (bug 105829) with
case InfoBarType::Info: // blue; #00529B/0,82,155; #BDE5F8/189,229,248
case InfoBarType::Success: // green; #4F8A10/79,138,16; #DFF2BF/223,242,191
case InfoBarType::Warning: // orange; #9F6000/159,96,0; #FEEFB3/254,239,179
case InfoBarType::Danger: // red; #D8000C/216,0,12; #FFBABA/255,186,186
using also not just black font color but something with proper contrast.
The color values were taken from https://www.tutorialrepublic.com/twitter-bootstrap-tutorial/bootstrap-alerts.php, IIRC
TBH I don’t like the Bootstrap colors. I chose instead to base them in Colibre’s colors.
I’ll take care of updating the font colors when I update the CSS file. =)
So what l have to update to fix the bug.
In addition to css styling as l would like to have when svg support for icon will be available can l define an css or text file in the colibte_svg folder where the colors are defined and if you change the color in the txt or css file it will be changed in the png generator.
Andreas: nothing required on your part — the correct icons are already in core; we just need to fix the help to use them instead of what it uses right now.
As for the CSS part, I already have a patch ready; don’t worry. :)
(In reply to andreas_k from comment #3)
> So what l have to update to fix the bug.
> In addition to css styling as l would like to have when svg support for icon
> will be available can l define an css or text file in the colibte_svg folder
> where the colors are defined and if you change the color in the txt or css
> file it will be changed in the png generator.
We already use colibre_svg directly in the Help pages in browser (>6.2), no more png. Remaining png are from legacy icons/images
Adolfo Jayme Barrientos committed a patch related to this issue.
It has been pushed to "master":
tdf#121571 Solve cognitive dissonance with note icons and colors