Bug 121700 - Can’t choose paragraph or character language from status bar
Summary: Can’t choose paragraph or character language from status bar
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
6.2.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: needsUXEval
Depends on:
Blocks: Statusbar
  Show dependency treegraph
 
Reported: 2018-11-24 21:25 UTC by Cathy Crumbley
Modified: 2018-11-30 19:55 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Attachments
first window that appears when click Language in status bar (12.63 KB, image/jpeg)
2018-11-24 21:25 UTC, Cathy Crumbley
Details
Window that appears when click "More" (68.30 KB, image/jpeg)
2018-11-24 21:27 UTC, Cathy Crumbley
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Cathy Crumbley 2018-11-24 21:25:34 UTC
Created attachment 147008 [details]
first window that appears when click Language in status bar

The tooltip for the language area of the status bar says “Text language. Right-click to set character or paragraph language.”

However, in Calc and Impress, right clicking (or left clicking for that matter) in the language area of the status bar opens a window with the options English, None, Reset, and More. 

Clicking More opens the same window as the window located at Options > Language Settings > Languages.

Neither window contains options for setting the language for paragraph or character.

What I expected: a window with a link to a window for setting the paragraph language and another link to a window for setting the character language.  This is similar to what happens in Writer. In Writer, however, three windows need to be opened before the option appears for setting the character language.

I don't know which version of 6 this started with.
Comment 1 Cathy Crumbley 2018-11-24 21:26:34 UTC
Second window that appears.
Comment 2 Cathy Crumbley 2018-11-24 21:27:45 UTC
Created attachment 147010 [details]
Window that appears when click "More"
Comment 3 Joel Madero 2018-11-24 23:09:00 UTC
Cathy - you sure this started with 6 at all? is this a regression from 5.x? If you could check, that would be great:

https://downloadarchive.documentfoundation.org/libreoffice/old/
Comment 4 Cathy Crumbley 2018-11-25 15:15:32 UTC
Hi Joel,

Here is what I found:

Version: 5.4.7.2  
Calc and Impress: no language area on the status bar
Writer: the windows open as expected (although three windows should not need to be opened to set paragraph and character language).

Version: 6.0.7.3 (x64)
Calc and Impress: There is a tooltip saying right click to set character or paragraph language. However, nothing happens when right click or left click.
Writer: works as expected

Version: 6.2.0.0.beta1
Calc and Impress: When right click or left click, windows open but there is no window to change character or paragraph language.
Writer: works as expected

Hope this helps.
Comment 5 himajin100000 2018-11-27 19:00:08 UTC
Reproducible.

Version: 6.3.0.0.alpha0+ (x64)
Build ID: ef2dfe4d54e1383b1f757f659f9cd1e13d12fba4
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-11-20_04:15:34
Locale: ja-JP (ja_JP); UI-Language: en-US
Calc: CL
=================================

1. Open Writer
2. Follow Tools->Language
3. You will find three items: "For Selection", "For Paragraph", and "For All Text"
4. If you follow "For Selection"->"More" or "For Paragraph"->"More", "Character" dialog will open.
5. But if you follow "For All Text"->"More" , "Options - Language Settings - Languages" will open.

https://opengrok.libreoffice.org/xref/core/framework/source/uielement/langselectionstatusbarcontroller.cxx?r=bdb0775a#167
https://opengrok.libreoffice.org/xref/core/framework/source/uielement/langselectionstatusbarcontroller.cxx?r=bdb0775a#169

so for Writer, the first three items in the status bar context menu is for selection, and the last one "Set Language for Paragraph" is for the paragraph, literally.
https://opengrok.libreoffice.org/xref/core/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu#6623
https://opengrok.libreoffice.org/xref/core/framework/source/uielement/langselectionstatusbarcontroller.cxx?r=bdb0775a#196
https://opengrok.libreoffice.org/xref/core/framework/source/uielement/langselectionmenucontroller.cxx?r=b83cc2b0#266
https://opengrok.libreoffice.org/xref/core/framework/source/uielement/langselectionmenucontroller.cxx?r=b83cc2b0#182

On the other hand,  the menus in other applications' context menu is for default text(all text), so this opens  "Options - Language Settings - Languages"

https://opengrok.libreoffice.org/xref/core/framework/source/uielement/langselectionstatusbarcontroller.cxx?r=bdb0775a#201
https://opengrok.libreoffice.org/xref/core/sc/source/ui/docshell/docsh4.cxx?r=0dfb0f09#1187
Comment 6 Cathy Crumbley 2018-11-27 19:07:01 UTC
Himajin -  I don't see how what you are saying is different from what I reported as a bug. 

Are you agreeing that it is a bug or are you saying that it is not a bug?
Comment 7 himajin100000 2018-11-27 19:20:34 UTC
(In reply to Cathy Crumbley from comment #6)

Though this can be by design(not a bug), I agree that providing additional menus for paragraph and character would be better(as an enhancement).

my purposes were 
1. to confirm the bug, which should be done by another than the reporter
2. to make it clearer that the program is executing "language status" for "all the text"
3. to give source code pointer
Comment 8 himajin100000 2018-11-27 19:21:56 UTC
>to confirm the bug,
to confirm what the reporter saw on my own environment
Comment 9 Cathy Crumbley 2018-11-27 20:23:49 UTC
Oh, I see. Thank you for making this report more complete.

It appears that this feature in Calc has not worked properly for a while, if it ever did. That makes me wonder if it is the best use of that space.

I am working on Calc documentation and need to figure out what to say about this feature. 

As long as there is a tooltip saying that both paragraph and character languages can be set there, then this seems like a bug. If the tooltip doesn't mention paragraph and character languages, then there would be no obvious bug. 

It seems like an easy fix. What would you suggest I do to help that happen?
Comment 10 himajin100000 2018-11-27 20:55:26 UTC
um, Honestly , I'm not successful in letting the tooltip show for the statusbar items with my 6.3 nightly build, though I found that the message is set here in the sourcecode(shared among all applications,but it would be not that difficult to use bWriter as in LangSelectionStatusbarController::LangMenu ).

https://opengrok.libreoffice.org/xref/core/framework/source/uielement/langselectionstatusbarcontroller.cxx?r=bdb0775a#121
https://opengrok.libreoffice.org/xref/core/framework/inc/strings.hrc?r=c89a4996#54

===
If you don't mind going along just a bit hard way (for programmers) and want to do all things yourself, and can spend two days for the first time, Developer documents await you.

https://wiki.documentfoundation.org/Development/BuildingOnWindows
https://wiki.documentfoundation.org/Development/gerrit/SubmitPatch

If you mind that hard way, please prepare the tooltip messages for writer and other applications, and give them to me. you can post them on this bug report:-), and I will submit a patch to gerrit. ( I'm not going to prepare the messages myself. I'm not confident in that area.)
Comment 11 Cathy Crumbley 2018-11-28 16:51:34 UTC
The tooltip for Writer is OK (but see below). 

I suppose that the tooltip for Calc and Draw could say something such as: Text language. Right-click to change. (Currently, either right click or left click open the same dialog.)

However, on further consideration, just changing the tooltip does not seem like a good option since changing the language for a whole document would only need to be done once. It seems to me that it would be unusual for a user to decide to change the language of the document after they have started to work on it. Therefore, this does not seem like a good use of space on the status bar. 

Rather than change the tooltip, a better option would be to make it function in Calc and Draw as it does in Writer. I am thinking that it might be relatively easy but then I really don’t know.

Better still would be to simplify the dialogs in all three modules so that the first dialog would link directly to dialogs for changing character language and for changing paragraph language.

By the way, in looking this over, I have noticed that tooltips don't appear for other areas in the status bar. It would be especially helpful if tooltips could be added, especially for inscrutable areas such as those that are often empty.
Comment 12 Heiko Tietze 2018-11-30 08:05:42 UTC
In Writer, the top-level options affect the selection (and More opens the character dialog) while everything underneath paragraph is applied to the whole section. This menu replicates Tools > Language > For Selection and > For Paragraph. Meaning also the tooltip is not correct. I would suggest "Change text language" and have two menus with Selection and Paragraph likewise the main menu.  

In Calc there is no such thing as character or paragraph, so only one level is presented and More goes to Tools > Options > Language. It would be more consistent to open the Format Cells dialog at the Font tab. However changing the cell property does not affect what is stated on the statusbar. Eike, could yopu please enlighten us here.
Comment 13 Thomas Lendo 2018-11-30 19:55:26 UTC
Is this a duplicate of Bug 114178 'Calc/Impress Statusbar: wrong language display, no change possible'?