Bug 121914 - Undo/redo of text box movement broken
Summary: Undo/redo of text box movement broken
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.1.3.2 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, implementationError
Depends on:
Blocks: Textbox Undo-Redo
  Show dependency treegraph
 
Reported: 2018-12-05 01:41 UTC by muso
Modified: 2019-01-21 14:56 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
ODT test file (48.23 KB, application/vnd.oasis.opendocument.text)
2018-12-05 01:41 UTC, muso
Details
Reproducer document, whithout a textbox. (48.22 KB, application/vnd.oasis.opendocument.text)
2018-12-18 15:38 UTC, Miklos Vajna
Details

Note You need to log in before you can comment on or make changes to this bug.
Description muso 2018-12-05 01:41:30 UTC
Created attachment 147293 [details]
ODT test file

- open the attached simple file and move the box "some red text" to the right side
- click the undo button

result: the movement is not undone since the moved text box lands on a different place

- now press the redo button

result: the box is placed somewhere else

- now press undo then redo a few times and see that the box is placed quite randomly

I found out that the bug does not appear when I delete the image in the file so it seems the fact that the file contains an image seems to be important for the bug.
Comment 1 muso 2018-12-05 01:44:01 UTC
The occurs no matter if you move the box to the upper or lower right of the page, the random movement with several undo/redo however only occurs when moving the box to the lower right.
Comment 2 Dieter Praas 2018-12-05 08:31:28 UTC
I confirm it with

Version: 6.2.0.0.beta1 (x64)
Build ID: d1b41307be3f8c19fe6f1938cf056e7ff1eb1d18
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
Locale: en-US (de_DE); UI-Language: en-GB
Calc: threaded
Comment 3 Xisco Faulí 2018-12-12 18:31:48 UTC
Not reproduced in

Version: 5.2.0.0.alpha0+
Build ID: 3ca42d8d51174010d5e8a32b96e9b4c0b3730a53
Threads 4; Ver: 4.15; Render: default;
Comment 4 raal 2018-12-13 08:54:07 UTC
This seems to have begun at the below commit.
Adding Cc: to Miklos Vajna; Could you possibly take a look at this one? Thanks

fffa2416982cdc322a1c91acdf48e46c391b4c4f is the first bad commit
commit fffa2416982cdc322a1c91acdf48e46c391b4c4f
Author: Norbert Thiebaud <nthiebaud@gmail.com>
Date:   Tue Aug 7 00:20:18 2018 -0700

    source sha:59f5f666a5085ae58a8dd164636a6bea47e6bddc

author	Miklos Vajna <vmiklos@collabora.co.uk>	2018-08-06 21:42:32 +0200
committer	Miklos Vajna <vmiklos@collabora.co.uk>	2018-08-07 09:14:03 +0200
commit	59f5f666a5085ae58a8dd164636a6bea47e6bddc (patch)
tree	2ce2f852b1befcff27f46757f039238590ede889
parent	7d800d0fa98978e06c5dc0f189501f96402e11d5 (diff)
tdf#109137 sw textbox: fix initial wrap type of a shape's textbox
Comment 5 Miklos Vajna 2018-12-18 15:37:54 UTC
Sorry, I think this just made existing problem more visible. I'll attach an ODT which has no textbox in it (textbox as in the feature described at https://vmiklos.hu/blog/textbox.html) and the same problem happens there as well: if you just select the shape, press the right arrow then undo, you don't get back the original position.

So yes, this is a bug, it has to be fixed, but it's not a regression.
Comment 6 Miklos Vajna 2018-12-18 15:38:53 UTC
Created attachment 147651 [details]
Reproducer document, whithout a textbox.

Reproduce document that shows this was already broken before.