Bug 122118 - Toolbar dropdown button triangles are too large
Summary: Toolbar dropdown button triangles are too large
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.3.0.0.alpha0+
Hardware: All All
: low trivial
Assignee: Not Assigned
URL:
Whiteboard: target:6.3.0
Keywords: bibisected, bisected, easyHack, needsDevEval, regression
Depends on:
Blocks: Toolbars
  Show dependency treegraph
 
Reported: 2018-12-15 06:48 UTC by Aron Budea
Modified: 2020-06-16 22:47 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot (Windows) (48.23 KB, image/png)
2018-12-15 06:48 UTC, Aron Budea
Details
Screenshot (Linux) (114.69 KB, image/png)
2018-12-21 10:14 UTC, Aron Budea
Details
Screenshot with the patch (10.76 KB, image/png)
2019-01-11 12:20 UTC, Heiko Tietze
Details
gen and gtk3/Breeze (44.65 KB, image/png)
2019-01-11 13:13 UTC, Heiko Tietze
Details
Windows GL vs no GL (52.53 KB, image/png)
2019-01-29 20:54 UTC, Aron Budea
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Aron Budea 2018-12-15 06:48:43 UTC
Created attachment 147567 [details]
Screenshot (Windows)

The little triangles next to dropdown toolbar buttons are too large. See comparison screenshot.

Observed using LO 6.3.0.0.alpha0+ (68aef0a3df1dd4c83dc3c26e4d3280649f4d3265) / Windows 7.
Looks fine in 6.2 beta1.
=> regression

Bibisected to the following commit using repo bibisect-win32-6.3. Adding Cc: to Michael Meeks, please take a look.
https://cgit.freedesktop.org/libreoffice/core/commit/?id=b62c43d1200e524369d9c7c2bd1dad3044efd672
author		Michael Meeks <michael.meeks@collabora.com>	2018-11-23 02:14:00 +0000
committer	Michael Meeks <michael.meeks@collabora.com>	2018-11-26 18:54:08 +0100

Anti-alias toolbar button drop-downs.
Comment 1 Roman Kuznetsov 2018-12-15 10:28:17 UTC
confirm for

Version: 6.3.0.0.alpha0+
Build ID: 3c964980da07892a02d5ac721d80558c459532d0
CPU threads: 4; OS: Windows 6.1; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-12-12_02:07:45
Locale: ru-RU (ru_RU); UI-Language: en-US
Calc: threaded
Comment 2 Timur 2018-12-20 13:35:15 UTC
I wouldn't agree this is a bug. Triangles are larger but not too large for me.
Comment 3 Heiko Tietze 2018-12-21 09:50:17 UTC
Besides Timur's comment, I doubt it is a Colibre icon. Rather the system theme has changed.
Comment 4 Aron Budea 2018-12-21 10:14:58 UTC
Created attachment 147735 [details]
Screenshot (Linux)

(In reply to Heiko Tietze from comment #3)
> Besides Timur's comment, I doubt it is a Colibre icon. Rather the system
> theme has changed.
The triangles are drawn programmatically. I'd say the change looks fine on Linux, but they are too large on Windows.
Comment 5 Heiko Tietze 2018-12-21 10:53:24 UTC
Okay, let's make it a pixel smaller, ideally depending on the toolbar size (gtk3 dropdowns are quite large while qt is smaller too). Could be an easyhack with code pointers.
Comment 6 andreas_k 2018-12-22 11:34:12 UTC
(In reply to Heiko Tietze from comment #5)
> Okay, let's make it a pixel smaller, ideally depending on the toolbar size
> (gtk3 dropdowns are quite large while qt is smaller too). Could be an
> easyhack with code pointers.

+1
Comment 7 Heiko Tietze 2019-01-11 12:20:07 UTC
Created attachment 148236 [details]
Screenshot with the patch

Triangle size depend now on the height of the toolbar. 

Patch is here https://gerrit.libreoffice.org/#/c/66166/, comments are welcome.
Comment 8 andreas_k 2019-01-11 12:30:57 UTC
can I have a screenshot of the tabbed notebookbar cause there are some commands with size small and others with labels on bottom so the toolbar height will be two rows.
Comment 9 Heiko Tietze 2019-01-11 13:13:52 UTC
Created attachment 148237 [details]
gen and gtk3/Breeze

Not sure that NB uses the same routines.
Comment 10 andreas_k 2019-01-11 13:54:28 UTC
(In reply to Heiko Tietze from comment #9)
> Created attachment 148237 [details]
> gen and gtk3/Breeze
> 
> Not sure that NB uses the same routines.

see first icon which is two rows high, has larger arrow. don't know if you like it.
Comment 11 Heiko Tietze 2019-01-11 14:24:12 UTC
(In reply to andreas_k from comment #10)
> ... don't know if you like it.

Worse that some buttons are so small that the triangle is just a few pixels big. The question is rather how we deal with that per a) having a minimum/maximum size, b) require NB controls to have a minimum size, c) change the algorithm to be more conservative, d) refuse the change and accept bigger triangles in standard etc.

Would also be very interesting how all this works on hires screens.
Comment 12 Michael Meeks 2019-01-11 14:27:29 UTC
FYI; I would suggest just reverting my patch if we think it makes things better and getting that into 6.2. The change is mostly helpful for HiDPI in Online anyway - which we don't use for PC / HiDPI yet (sadly).
Comment 13 andreas_k 2019-01-11 14:34:48 UTC
Nb follow icon settings default is sc_ so 16px but 24 pix is also possible via settings.
Comment 14 Aron Budea 2019-01-14 00:03:00 UTC
(In reply to Heiko Tietze from comment #7)
> Patch is here https://gerrit.libreoffice.org/#/c/66166/, comments are
> welcome.
Sadly in Windows this patch makes no difference, perhaps that needs different constants in the formula.

(In reply to Michael Meeks from comment #12)
> FYI; I would suggest just reverting my patch if we think it makes things
> better and getting that into 6.2. The change is mostly helpful for HiDPI in
> Online anyway - which we don't use for PC / HiDPI yet (sadly).
The original commit was only pushed in master, after branch-off, so 6.2 isn't affected.
Comment 15 Heiko Tietze 2019-01-15 09:37:57 UTC
Would keep Michaels patch and this too as it also solves the problem with too small triangles at extra large icons. Added now a minimum value.

Don't see why Windows need different constants, maybe you run a hires display, which should be covered by the other factor.
Comment 16 Aron Budea 2019-01-15 11:22:59 UTC
(In reply to Heiko Tietze from comment #15)
> Don't see why Windows need different constants, maybe you run a hires
> display, which should be covered by the other factor.
1920x1200, not particularly high resolution.
Comment 17 Heiko Tietze 2019-01-15 13:06:13 UTC
Pushed it to master. QA, please test this carefully.
Comment 18 Commit Notification 2019-01-15 13:06:50 UTC
heiko tietze committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/b56ad2a1292b01647c4ee1f4364f7c4aa20fc449%5E%21

Resolves tdf#122118 - Toolbar dropdown button triangles are too large

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 19 Heiko Tietze 2019-01-17 14:17:55 UTC
(In reply to Commit Notification from comment #18)
> heiko tietze committed a patch related to this issue.
>...

Which is being reverted because of bug 122761, I will look into it.
Comment 20 Commit Notification 2019-01-17 14:21:10 UTC
Xisco Faulí committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/59647fa4d190622cc6aae873de06a4dfe973bd54%5E%21

tdf#122761: Revert "Resolves tdf#122118 - Toolbar dropdown button triangles are too large"

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 21 Heiko Tietze 2019-01-18 16:57:13 UTC
https://gerrit.libreoffice.org/#/c/66565/3

Second try, please test.
Comment 22 Commit Notification 2019-01-18 16:57:31 UTC
heiko tietze committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/e3cc5506d695b602fbd3c6ee816e36e6a76d9d96%5E%21

Resolves tdf#122118 - Toolbar dropdown button triangles are too large

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 23 Aron Budea 2019-01-29 20:54:24 UTC
Created attachment 148741 [details]
Windows GL vs no GL

Interestingly with OpenGL disabled it looks good now, but with OpenGL enabled, not so much.
Comment 24 Heiko Tietze 2019-01-30 08:25:38 UTC
(In reply to Aron Budea from comment #23)
> Interestingly with OpenGL disabled it looks good now, but with OpenGL
> enabled, not so much.

Could that be related to bug 122457? Anyway, I'm more interested if the size works on hires screens; the patch doesn't touch the DrawPolygon() function.
Comment 25 Xisco Faulí 2019-03-02 03:48:38 UTC Comment hidden (obsolete)
Comment 26 Xisco Faulí 2019-03-03 03:37:33 UTC Comment hidden (obsolete)
Comment 27 Xisco Faulí 2019-06-10 15:00:31 UTC
Dear Heiko Tietze,
This bug has been in ASSIGNED status for more than 3 months without any
activity. Resetting it to NEW.
Please assigned it back to yourself if you're still working on this.
Comment 28 Heiko Tietze 2019-06-11 08:54:33 UTC
Questionable patch, see c23, c24. But better we close this ticket and start new.