Bug 122120 - UI Preview is truncated in Format cells dialog
Summary: UI Preview is truncated in Format cells dialog
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
6.3.0.0.alpha0+
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard: target:6.3.0 target:6.2.0.1 target:6....
Keywords: bibisected, bisected
Depends on:
Blocks:
 
Reported: 2018-12-15 08:15 UTC by Emil Tanev
Modified: 2019-06-12 08:34 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
screenshot and file (289.90 KB, application/x-zip-compressed)
2018-12-15 08:15 UTC, Emil Tanev
Details
how it looks with gtk3 3.18.9 (47.62 KB, image/png)
2018-12-18 10:34 UTC, Xisco Faulí
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Emil Tanev 2018-12-15 08:15:15 UTC
Created attachment 147569 [details]
screenshot and file

Open the workbook in Calc
Right-click on cell A1
Open Format cells dialog - Numbers

Issue - the preview is truncated (see screenshot)

Version: 6.3.0.0.alpha0+ (x64)
Build ID: 3c964980da07892a02d5ac721d80558c459532d0
CPU threads: 1; OS: Windows 10.0; UI render: default; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-12-12_03:38:09
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded
Comment 1 raal 2018-12-16 09:05:38 UTC
Confirm with Version: 6.3.0.0.alpha0+
Build ID: 0ad2302cf6787cacbbaca081a890a0e356a55297
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3;
Comment 2 raal 2018-12-16 09:57:37 UTC
This seems to have begun at the below commit.
Adding Cc: to Caolán McNamara ; Could you possibly take a look at this one?
Thanks
 3fb4036a9aef3c6298f4cf1a7a18099a11e2a18f is the first bad commit
commit 3fb4036a9aef3c6298f4cf1a7a18099a11e2a18f
Author: Jenkins Build User <tdf@pollux.tdf>
Date:   Thu Oct 11 20:51:32 2018 +0200

    source 14337672d2793fec5ec1cebcced33d04ecf4d0c6

author	Caolán McNamara <caolanm@redhat.com>	2018-10-11 14:02:50 +0100
committer	Caolán McNamara <caolanm@redhat.com>	2018-10-11 20:44:45 +0200
commit 14337672d2793fec5ec1cebcced33d04ecf4d0c6 (patch)
tree 7daa1265c3eb010e4c60561c92004e09f2dbfe12
parent 759dcc107cb7740ec4242634a19631d9ed70cb0f (diff)
Resolves: tdf#120476 need to be resizable if number of tabs is variable
Comment 3 Caolán McNamara 2018-12-17 17:41:35 UTC
If you add more text to the cell and test in an earlier version the same truncation will occur with the longer text, so there has always been a truncation on both sides when there's more text than can fit in the preview space. And the truncation will depend on the font used for the ui so its going to affect different people with different length strings and depending on the size of the other tabs

Checking with an ancient version of AOO I also get a truncation with this string.

The bisect has presumably just found a location where the dialog becomes narrower, so I'm not buying a real regression here, not even a real bug.

That said, I can easily left align it if it won't fit centred and let the truncation take place on the end of the string
Comment 4 Emil Tanev 2018-12-17 17:56:14 UTC
Left aligning it is probably the way to go.
Comment 5 Commit Notification 2018-12-17 21:08:58 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/b9505d6be5ff62930ec68a1baeb7c4bcf01442a4%5E%21

Related: tdf#122120 left align text if preview won't fit

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Caolán McNamara 2018-12-17 21:10:48 UTC
backport to 6-2 in gerrit
Comment 7 Xisco Faulí 2018-12-18 10:34:07 UTC
Created attachment 147645 [details]
how it looks with gtk3 3.18.9

in

Version: 6.3.0.0.alpha0+
Build ID: 6dc36d343aeacb3d1e14ec0c847937d63f4e68a7
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

with gtk3 3.18.9 the UI preview is gone...
Comment 8 Xisco Faulí 2018-12-18 10:38:54 UTC
Actually my problem seems to be older than 14337672d2793fec5ec1cebcced33d04ecf4d0c6.
Investigating... Putting it back to FIXED
Comment 9 Xisco Faulí 2018-12-18 11:00:19 UTC
(In reply to Caolán McNamara from comment #3)
> The bisect has presumably just found a location where the dialog becomes
> narrower, so I'm not buying a real regression here, not even a real bug.
> 
> That said, I can easily left align it if it won't fit centred and let the
> truncation take place on the end of the string

Removing 'regression' keyword
Comment 10 Xisco Faulí 2018-12-18 11:02:02 UTC
Verified in

Version: 6.3.0.0.alpha0+
Build ID: 6dc36d343aeacb3d1e14ec0c847937d63f4e68a7
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk2; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

Now, the preview is aligned to the left.
@Caolán, thanks for fixing this!
Comment 11 Commit Notification 2018-12-18 11:34:29 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-6-2":

https://git.libreoffice.org/core/+/9fcca59d30ab69bfbb07b40d7429bcba6fcf869c%5E%21

Related: tdf#122120 left align text if preview won't fit

It will be available in 6.2.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Commit Notification 2019-06-09 20:42:53 UTC
Muhammet Kara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/0d35f8f673ac4e6aa3f1e5f1edc0c6c7a45d2f95%5E%21

Fix logic error and simplify. Related: tdf#122120

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 13 Commit Notification 2019-06-10 07:59:15 UTC
Muhammet Kara committed a patch related to this issue.
It has been pushed to "libreoffice-6-3":

https://git.libreoffice.org/core/+/1ccf361e78eb0acd7ff682bf6c74ec8471abc0d4%5E%21

Fix logic error and simplify. Related: tdf#122120

It will be available in 6.3.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.