Created attachment 147569 [details] screenshot and file Open the workbook in Calc Right-click on cell A1 Open Format cells dialog - Numbers Issue - the preview is truncated (see screenshot) Version: 6.3.0.0.alpha0+ (x64) Build ID: 3c964980da07892a02d5ac721d80558c459532d0 CPU threads: 1; OS: Windows 10.0; UI render: default; VCL: win; TinderBox: Win-x86_64@42, Branch:master, Time: 2018-12-12_03:38:09 Locale: en-US (en_US); UI-Language: en-US Calc: threaded
Confirm with Version: 6.3.0.0.alpha0+ Build ID: 0ad2302cf6787cacbbaca081a890a0e356a55297 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3;
This seems to have begun at the below commit. Adding Cc: to Caolán McNamara ; Could you possibly take a look at this one? Thanks 3fb4036a9aef3c6298f4cf1a7a18099a11e2a18f is the first bad commit commit 3fb4036a9aef3c6298f4cf1a7a18099a11e2a18f Author: Jenkins Build User <tdf@pollux.tdf> Date: Thu Oct 11 20:51:32 2018 +0200 source 14337672d2793fec5ec1cebcced33d04ecf4d0c6 author Caolán McNamara <caolanm@redhat.com> 2018-10-11 14:02:50 +0100 committer Caolán McNamara <caolanm@redhat.com> 2018-10-11 20:44:45 +0200 commit 14337672d2793fec5ec1cebcced33d04ecf4d0c6 (patch) tree 7daa1265c3eb010e4c60561c92004e09f2dbfe12 parent 759dcc107cb7740ec4242634a19631d9ed70cb0f (diff) Resolves: tdf#120476 need to be resizable if number of tabs is variable
If you add more text to the cell and test in an earlier version the same truncation will occur with the longer text, so there has always been a truncation on both sides when there's more text than can fit in the preview space. And the truncation will depend on the font used for the ui so its going to affect different people with different length strings and depending on the size of the other tabs Checking with an ancient version of AOO I also get a truncation with this string. The bisect has presumably just found a location where the dialog becomes narrower, so I'm not buying a real regression here, not even a real bug. That said, I can easily left align it if it won't fit centred and let the truncation take place on the end of the string
Left aligning it is probably the way to go.
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/b9505d6be5ff62930ec68a1baeb7c4bcf01442a4%5E%21 Related: tdf#122120 left align text if preview won't fit It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
backport to 6-2 in gerrit
Created attachment 147645 [details] how it looks with gtk3 3.18.9 in Version: 6.3.0.0.alpha0+ Build ID: 6dc36d343aeacb3d1e14ec0c847937d63f4e68a7 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: threaded with gtk3 3.18.9 the UI preview is gone...
Actually my problem seems to be older than 14337672d2793fec5ec1cebcced33d04ecf4d0c6. Investigating... Putting it back to FIXED
(In reply to Caolán McNamara from comment #3) > The bisect has presumably just found a location where the dialog becomes > narrower, so I'm not buying a real regression here, not even a real bug. > > That said, I can easily left align it if it won't fit centred and let the > truncation take place on the end of the string Removing 'regression' keyword
Verified in Version: 6.3.0.0.alpha0+ Build ID: 6dc36d343aeacb3d1e14ec0c847937d63f4e68a7 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk2; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: threaded Now, the preview is aligned to the left. @Caolán, thanks for fixing this!
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-6-2": https://git.libreoffice.org/core/+/9fcca59d30ab69bfbb07b40d7429bcba6fcf869c%5E%21 Related: tdf#122120 left align text if preview won't fit It will be available in 6.2.0.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Muhammet Kara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/0d35f8f673ac4e6aa3f1e5f1edc0c6c7a45d2f95%5E%21 Fix logic error and simplify. Related: tdf#122120 It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Muhammet Kara committed a patch related to this issue. It has been pushed to "libreoffice-6-3": https://git.libreoffice.org/core/+/1ccf361e78eb0acd7ff682bf6c74ec8471abc0d4%5E%21 Fix logic error and simplify. Related: tdf#122120 It will be available in 6.3.0.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.