Bug 122585 - Classification: by using the dialog, footer text from policy is not placed in the document - it is the same as the header
Summary: Classification: by using the dialog, footer text from policy is not placed i...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.0.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisectRequest, regression
Depends on:
Blocks: Classification
  Show dependency treegraph
 
Reported: 2019-01-08 22:08 UTC by Cor Nouws
Modified: 2019-03-03 09:22 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Cor Nouws 2019-01-08 22:08:25 UTC
- Writer document
- View > Toolbar > (TSCP) Classification
- use list from toolbar and apply Confidential
   >  header and footer text appear in the document (as defined in policy file)
     (as well as watermark)
   This is OK

- New document
- Open dialog Document Classification
- select Confidential from list Classification
- hit OK
   > footer texts only shows the "classification", just as the header
     (if in the dialog text is added in the "content" box, that is
      placed in the footer too > header and footer are the same)
     thus the footer also misses the extra info (from the policy file)

It is easy to see per version, by comparing result from toolbar and from dialog!

Already wrong in Version: 6.0.0.0.alpha0+
Build ID: 892c719fffa06de4c7aeab497326cad7bae9e5c6
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk2; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2017-09-27_03:02:09
Locale: nl-NL (nl_NL.UTF-8); Calc: group

So an implementation error (stupid I missed that before - apologies :\ )
Comment 1 raal 2019-01-09 07:08:58 UTC
Confirm. Version: 6.3.0.0.alpha0+
Build ID: 993913469e74e9db9743004bbe36aa412411671c
CPU threads: 4; OS: Windows 6.1; UI render: default; VCL: win;
Comment 2 Cor Nouws 2019-01-29 11:15:46 UTC
was ok in one the master builds before 6.0.0.0.alpha0+
Comment 3 Aron Budea 2019-03-03 05:57:50 UTC
I don't know much about TSCP Classification, but isn't the point of the dialog that the user constructs the text, and it doesn't come from the policy?

The dialog was added with the following commit, and already doesn't add info from the policy file:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=71ee09947d5a71105d64fd225bb3672dfa7ce834
author		Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>	2017-09-19 15:37:04 +0200
committer	Tomaž Vajngerl <quikee@gmail.com>	2017-09-21 09:49:12 +0200

TSCP: add advanced classification dialog
Comment 4 Cor Nouws 2019-03-03 09:22:21 UTC
(In reply to Aron Budea from comment #3)
> I don't know much about TSCP Classification, but isn't the point of the
> dialog that the user constructs the text, and it doesn't come from the
> policy?
It allows the user to add information _additional_ to what the policy provides.