Bug 123056 - GUI in Draw's Groupedbar Compact dissapeared after adding of table
Summary: GUI in Draw's Groupedbar Compact dissapeared after adding of table
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
(earliest affected) release
Hardware: All All
: medium normal
Assignee: Not Assigned
Keywords: implementationError
: 128851 (view as bug list)
Depends on:
Blocks: Notebookbar-Groupedbar
  Show dependency treegraph
Reported: 2019-01-30 15:01 UTC by Roman Kuznetsov
Modified: 2023-05-23 23:22 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:

No GUI after inserting of table (30.67 KB, image/png)
2019-01-30 15:03 UTC, Roman Kuznetsov

Note You need to log in before you can comment on or make changes to this bug.
Description Roman Kuznetsov 2019-01-30 15:01:18 UTC
GUI in Draw's Groupedbar Compact dissapeared after adding of table

Steps to Reproduce:
1. Open new Draw drawing
2. Switch GUI to Groupedbar Compact
3. Add a table in to document (a table will be selected and GUI will be have icons for table)
4. Click on sheet out of table
5. GUI dissapeared (see attach)

Actual Results:
GUI dissapeared after inserting of table

Expected Results:
GUI change its view to normal

Reproducible: Always

User Profile Reset: No

Additional Info:
ID сборки: 98c6a8a1c6c7b144ce3cc729e34964b47ce25d62
Потоков ЦП: 4; ОС:Windows 6.1; Отрисовка ИП: по умолчанию; VCL: win; 
Локаль: ru-RU (ru_RU); UI-Language: ru-RU
Calc: threaded
Comment 1 Roman Kuznetsov 2019-01-30 15:03:23 UTC
Created attachment 148757 [details]
No GUI after inserting of table
Comment 2 Roman Kuznetsov 2019-01-30 15:05:07 UTC
deleting of user profile didn't help
Comment 3 Xisco Faulí 2019-01-30 15:48:19 UTC
Reproduced in

Build ID: f1f84cf7fae3c777908cfc5357a067db731367ac
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded
Comment 4 Xisco Faulí 2019-01-30 16:28:55 UTC
Reproduced back to 7c0c1524f45e73ce24180efc26f969f370fbeb79, when the groupedbar was added to draw.
Not reproduced in Impress
Comment 5 Roman Kuznetsov 2019-11-17 11:42:56 UTC
*** Bug 128851 has been marked as a duplicate of this bug. ***
Comment 6 QA Administrators 2021-11-17 05:12:09 UTC Comment hidden (obsolete)
Comment 7 Roman Kuznetsov 2021-11-17 10:53:36 UTC
Still repro in

Version: (x64) / LibreOffice Community
Build ID: 7b8f630db30ee0066a9f4b6e540368d2fcad7fa8
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: ru-RU
Calc: threaded
Comment 8 St. Ernst 2022-02-18 19:20:35 UTC Comment hidden (off-topic)
Comment 9 Stéphane Guillou (stragu) 2023-01-30 10:23:14 UTC
Reproduced in Draw as described by Roman in description in:

Version: (X86_64) / LibreOffice Community
Build ID: ec4babad021218b75dfe8534985d7db525edde69
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

What St. Ernst described in Comment 8 is different and most likely is bug 141684, which should be fixed now. Hiding comment as "off-topic" just to reduce risk of confusion.
Comment 10 Justin L 2023-05-23 21:16:16 UTC
I don't really understand what is going on here, but...
selection changed properly vcl/source/control/notebookbar.cxx:241: ::notifyContextChangeEvent[DrawPage]

but then the context changes to [default] when table deactivates. I assume the activation comes from mrBase.AddSubShell(**iTargetShell);

There is no deactivation going from DrawPage -> Table.

If we can strategically (when nothing is selected) call GetViewShellBase().GetDrawController()->BroadcastContextChange()
that would re-notify with the correct context.
Comment 11 Justin L 2023-05-23 23:22:18 UTC
(In reply to Justin L from comment #10)
> If we can strategically (when nothing is selected) 
This was my attempt at guessing, https://gerrit.libreoffice.org/c/core/+/152178 

Some other thoughts:
-ContextChangeBroadcaster::Deactivate doesn't run when comphelper::LibreOfficeKit::isActive(). Is it really needed in the desktop?
-perhaps it would just be better to turn off the broadcaster(s)?

In any case, this bug needs to be handled by someone familiar with the obviously flawed fundamentals. Bye...