Bug 123088 - Allow in Content Navigation View focused on Headings, the selection of several headers to be dragged at once.
Summary: Allow in Content Navigation View focused on Headings, the selection of severa...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.1.4.2 release
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard: target:6.4.0
Keywords:
: 127496 (view as bug list)
Depends on:
Blocks: Navigator
  Show dependency treegraph
 
Reported: 2019-01-31 15:01 UTC by ricky.tigg
Modified: 2020-03-29 15:20 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Navigator – Headings' continuous & non-continuous chains (117.21 KB, image/png)
2019-01-31 15:03 UTC, ricky.tigg
Details
continous chains drag drop demo (189.22 KB, video/x-matroska)
2019-09-04 02:49 UTC, Jim Raykowski
Details

Note You need to log in before you can comment on or make changes to this bug.
Description ricky.tigg 2019-01-31 15:01:49 UTC
Description:
Feature request: allow in Navigator view focused on Headings, the selection of several headers to be dragged at once, if required conditions have been fulfilled.

Steps to Reproduce:
None.

Actual Results:
At most a single header at a time can be dragged through an Headings' structure.

Expected Results:
In cases where many enough headers are present in a document and many of them have repetitively to be relocated, desired efficient work-flow cannot be achieved due to the essence of the current one-by-one header's dragging feature.

However, I have observed that some of those headers would have been eligible to be dragged together at once, by implementing a mechanism relying at most on two required conditions:

Only when the following conditions are fulfilled regarding selected headers – be they main headers or sub-headers – could then those headers be dragged somewhere else through an Headings' structure:

1. Same-levelled;
2. Form a continuous chain or chain part.

thanks to issue 123084 which was conveniently still alive when I submitted the present request, that last one could at least easily be illustrated – See attachment –. Cases that represent a continuous headings' chain or a continuous headings chain part are mentioned in the illustrations themselves as such.


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.1.4.2; Build ID: 6.1.4.2-1.fc29; CPU threads: 4; OS: Linux 4.20; UI render: default; VCL: gtk3; Locale: en-GB (en_GB.UTF-8); Calc: group threaded
Comment 1 ricky.tigg 2019-01-31 15:03:34 UTC
Created attachment 148804 [details]
Navigator – Headings' continuous & non-continuous chains
Comment 2 Xisco Faulí 2019-03-21 16:00:34 UTC
@Jim, any opinion here ?
Comment 3 Jim Raykowski 2019-03-24 22:23:42 UTC
This looks interesting to me.
Comment 4 Xisco Faulí 2019-05-02 10:15:02 UTC
let's move to NEW...
Comment 5 Jim Raykowski 2019-06-04 20:08:42 UTC
Hi all, here is an enhancement patch that adds drag and drop for multi selected continuous headings. Testing and code review are very much appreciated.

https://gerrit.libreoffice.org/#/c/73426/
Comment 6 Commit Notification 2019-07-11 19:34:13 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/7ae308e5cac31c64a6bf4892aac097dac3a054b7%5E%21

tdf#123088 Multi outline drag and drop

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Jim Raykowski 2019-07-11 19:38:38 UTC
I will put this in the release notes if it proves worthy.
Comment 8 ricky.tigg 2019-07-13 16:32:35 UTC
Test relied on current Master Linux-rpm_deb-x86_64@86-TDF as LibreOfficeDev-daily-x86_64.AppImage:

Version: 6.4.0.0.alpha0+; Build ID: c54597a8905b07807952aebc24237549302fb941;
CPU threads: 2; OS: Linux 5.1; UI render: default; VCL: gtk3; TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2019-07-10_22:22:02; Locale: fi-FI (fi_FI.UTF-8); UI-Language: en-US; Calc: threaded

I could not make it work as intended. While several headings have the focus on, only one heading is currently indicated as selected to be dragged –that one is inside a dotted line–; this is then that one that is actually dragged.
Comment 9 Jim Raykowski 2019-07-13 18:21:15 UTC
(In reply to ricky.tigg from comment #8)
> Test relied on current Master Linux-rpm_deb-x86_64@86-TDF as
> LibreOfficeDev-daily-x86_64.AppImage:
> 
> Version: 6.4.0.0.alpha0+; Build ID: c54597a8905b07807952aebc24237549302fb941;
> CPU threads: 2; OS: Linux 5.1; UI render: default; VCL: gtk3; TinderBox:
> Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2019-07-10_22:22:02;
> Locale: fi-FI (fi_FI.UTF-8); UI-Language: en-US; Calc: threaded
> 


Hi Ricky, I see the time of the build you tested is 2019-07-10_22:22:02. The patch was merged on 2019-07-11 so the build you have is before the patch was merged.
Comment 10 ricky.tigg 2019-07-16 10:11:28 UTC
Hi.Then daily-named files available for download are named by convention. Currently available files for download have today again the time-stamp you also noticed, which illustrates a practise of non-daily builds.I noticed today on https://libreoffice.soluzioniopen.com/index.php/daily-version,/, we can read regarding that subject "The packet with the date and the one with the quotation daily are identical" that confirms today again that state.

Would it be appropriate to name currently daily-named files according to Libreoffice's real build cycle? Could then monthly-named files be the right naming scheme?
Comment 11 Jim Raykowski 2019-07-17 06:16:24 UTC
It looks like the linux rpm-deb daily builds aren't working. Unfortunately this happened just before the merge was made.

Here is a link to check the status of the build boxes:
https://tinderbox.libreoffice.org/MASTER/status.html
Comment 12 Jim Raykowski 2019-08-31 04:22:16 UTC
AppImage can be used to test this. See https://www.libreoffice.org/download/appimage/
Comment 13 ricky.tigg 2019-09-02 06:27:33 UTC
Version: 6.3.0.4; Build ID: 057fc023c990d676a43019934386b85b21a9ee99; CPU threads: 2; OS: Linux 5.2; UI render: default; VCL: gtk3; Locale: fi-FI (fi_FI.UTF-8); UI-Language: en-US; Calc: threaded

Hey; for test purpose, in order to cover all combinations scenarios possible, I conceived that at least four main headings with each two sub-levelled headings would be required; Naming scheme of headings under a single main heading is according to that model: A, AA, AAA, respectively for main heading, 1st sub-levelled heading, 2nd sub-levelled heading.

Not ready for testing phase; I could observe that a feature allowing for the selection of several same-levelled headers has not been achieved yet. Observation in Comment 8 is still relevant.
Comment 14 Jim Raykowski 2019-09-02 22:33:00 UTC
You will need to use the daily AppImage to test this. 

https://libreoffice.soluzioniopen.com/index.php/daily-version/
Comment 15 ricky.tigg 2019-09-03 07:31:40 UTC
Version: 6.4.0.0.alpha0+; Build ID: 41cd3e8e817c8c33a13608e62eeb06ce2c6977e4;
CPU threads: 2; OS: Linux 5.2; UI render: default; VCL: gtk3; TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2019-09-01_22:30:33; Locale: fi-FI (fi_FI.UTF-8); UI-Language: en-US; Calc: threaded

Observation in Comment 8 is still relevant.
Comment 16 Jim Raykowski 2019-09-04 02:49:31 UTC
Created attachment 153852 [details]
continous chains drag drop demo

The patch only does drag moves for contiguous multi selected sibling headings or in other words "continuous chains". See created attachment for video demonstration.

Anyone who is interested in doing the non-continuous chains part of this request is welcome to take it.
Comment 17 ricky.tigg 2019-09-04 07:45:46 UTC
That feature you have achieved to be operational probably alone since it was assigned to you, shows you have talent. That's also a good part. You are the one that grabbed first the whole potential of drag an drop applied to continuous and discontinuous chains of headers that would add value for exigent use. I thank you for all of them.

You certainly should not attempt to achieve the whole task by your own, as things have to remain fair, and I agree with your comment regarding the future of the task. There is place in our world for a talented enough developer to express it in that missing complementary feature. 

Nevertheless, as noticeable in panel Navigator, one of the conventions in use is that when an header is selected alone, it gets as well a dotted line around it. That convention is not honoured in case of a multiselection of same-leveled continuous headers, which brings confusion in the use of the presently achieved new feature. By the way it made be doubt the feature you achieved was ready to be tested.
Comment 18 V Stuart Foote 2019-09-11 14:00:53 UTC
*** Bug 127496 has been marked as a duplicate of this bug. ***
Comment 19 Dieter 2019-11-16 11:20:20 UTC
Jim, it doesn't work for me in

Version: 6.4.0.0.beta1 (x64)
Build ID: 4d7e5b0c40ed843384704eca3ce21981d4e98920
CPU threads: 4; OS: Windows 10.0 Build 18362; UI render: default; VCL: win; 
Locale: de-DE (de_DE); UI-Language: en-US
Calc: threaded

I tried it with shift + Arrows (lik selecting mutiple styles).
Comment 20 Jim Raykowski 2019-11-18 00:54:50 UTC
(In reply to Dieter Praas from comment #19)
> Jim, it doesn't work for me in
> 
Hi Dieter,

Make sure you are in root mode by clicking the Content Navigation View button in the toolbox. Should only see headings in content tree list box.
Comment 21 Dieter 2019-11-18 08:54:28 UTC
(In reply to Jim Raykowski from comment #20)
> (In reply to Dieter Praas from comment #19)
> > Jim, it doesn't work for me in
> > 
> Hi Dieter,
> 
> Make sure you are in root mode by clicking the Content Navigation View
> button in the toolbox. Should only see headings in content tree list box.

Yes, that works. Do you plan to implement this feature also for "normal" view in navigator? If not, is it fixed then?
Comment 22 Jim Raykowski 2019-11-20 08:57:37 UTC
(In reply to Dieter Praas from comment #21)

> Do you plan to implement this feature also for "normal"
> view in navigator? If not, is it fixed then?

Probably not going to implement for "normal" view anytime soon. The full enhancement request hasn't been fulfilled so I'll just remove myself from being assigned for now.
Comment 23 Dieter 2020-03-29 15:20:07 UTC
(In reply to Jim Raykowski from comment #22)
> (In reply to Dieter Praas from comment #21)
> 
> > Do you plan to implement this feature also for "normal"
> > view in navigator? If not, is it fixed then?
> 
> Probably not going to implement for "normal" view anytime soon. The full
> enhancement request hasn't been fulfilled so I'll just remove myself from
> being assigned for now.

Jim, I've changed bug summary a bit, so it is clear, that this enhancement is actually available only in Content Navigaton View.

I've verified this with

Version: 7.0.0.0.alpha0+ (x64)
Build ID: 41177730421f9be9ad955766a5a19667d8003b11
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: default; VCL: win; 
Locale: de-DE (de_DE); UI-Language: en-GB
Calc: threaded

I hope you agree. If not, please feel free to change it back.