Bug 123656 - Ctrl+Plus keyboard shortcut unavailable on laptop keyboards
Summary: Ctrl+Plus keyboard shortcut unavailable on laptop keyboards
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
6.2.0.3 release
Hardware: All Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Shortcuts-Accelerators
  Show dependency tree / graph
 
Reported: 2019-02-22 19:35 UTC by Andy Goth
Modified: 2019-02-25 11:17 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Goth 2019-02-22 19:35:41 UTC 
Description:
On a laptop keyboard lacking a dedicated plus (+) key, the Ctrl+Plus keyboard shortcut (insert cells) is unavailable.  In trying to type Ctrl+Plus, I end up typing Ctrl+Shift+Equal, which is not mapped.

Ctrl+Minus (delete cells) works fine, by the way.

Steps to Reproduce:
1. Type Ctrl+Shift+Equal

Actual Results:
Nothing.

Expected Results:
Insert cells, same as Ctrl+Plus.


Reproducible: Always


User Profile Reset: No



Additional Info:
Comment 1 Roman Kuznetsov 2019-02-23 14:14:17 UTC 
it's works fine with key "+" on numpad. But if your notebook doesn't have numpad on keyboard, then really sign "+" on key "=" doesn't work
Comment 2 V Stuart Foote 2019-02-23 15:05:35 UTC 
Confirmed on Windows 10 Home 64-bit en-US (1809) with Intel HD Graphics 620 with
Version: 6.3.0.0.alpha0+ (x64)
Build ID: 9712dd74bfb0c9b99cab37bd147fe267b48c6d7d
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2019-02-17_22:47:09
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded

Using the keyboard Numpad provided "+" key opens the Insert Cells dialog. But using the shifted =/+ does not.

Looks like we define a "KEY_MOD1 | KEY_ADD" mapping, but *not* a "KEY_SHIFT | KEY_MOD1 | KEY_ADD" is that needed to make this shortcut/accelerator functional?
Comment 3 Heiko Tietze 2019-02-25 11:17:27 UTC 
(In reply to V Stuart Foote from comment #2)
> Looks like we define a "KEY_MOD1 | KEY_ADD" mapping, but *not* a "KEY_SHIFT
> | KEY_MOD1 | KEY_ADD" is that needed to make this shortcut/accelerator
> functional?

That's likely true. The plus is reachable on German keyboard layout without shift and both numpad and standard pad work. What we have to do is bug 115052. Make this a duplicate?