Bug 124870 - Up key does not move to line ended by hyphen
Summary: Up key does not move to line ended by hyphen
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
4.2.0.4 release
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
: 118024 (view as bug list)
Depends on:
Blocks: Text-Cursor
  Show dependency treegraph
 
Reported: 2019-04-21 15:29 UTC by Dávid Horváth
Modified: 2021-03-03 16:50 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Sample file to demonstrate the bug. (9.49 KB, application/vnd.oasis.opendocument.text)
2019-04-21 15:33 UTC, Dávid Horváth
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dávid Horváth 2019-04-21 15:29:48 UTC
Description:
Up key does not move to line ended by hyphen if you start the moving from a more right position than the hyphen.

Steps to Reproduce:
1. Open a new document, and write some long text.
2. Type a hyphen in a word, ensure that the word will be broken.
3. Move the cursor to a later line's end that is more at the right that the hyphen.
4. Press the up key repeatedly, try to move to the top of the document.

Actual Results:
You can not reach the top. Cursor will get stuck at the start of the line next to the hyphen. (Behavior is the same that this line would be the first line in the document.)

Expected Results:
Cursor should be move to the previous line.


Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
Sadly, I can not attach a sample.

Copy the above sample text into a new document with standard settings. Move after the "!" sign. Press the up key repeatedly.

Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse-cillum dolore eu fugiat nulla pariatur.
Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est! laborum.
Comment 1 Dávid Horváth 2019-04-21 15:33:40 UTC
Created attachment 150902 [details]
Sample file to demonstrate the bug.
Comment 2 Dieter 2019-04-22 04:55:21 UTC
(In reply to Dávid Horváth from comment #1)
> Created attachment 150902 [details]
> Sample file to demonstrate the bug.

I confirm itwith document from attachement 1 and

Version: 6.3.0.0.alpha0+ (x64)
Build ID: 421e6fc3cd2e6fe37afbef341e2d0ad7b8edde37
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2019-04-07_01:12:58
Locale: en-US (de_DE); UI-Language: en-US
Calc: threaded
Comment 3 Xisco Faulí 2019-05-23 11:07:09 UTC
Reproduced in

Version: 4.3.0.0.alpha1+
Build ID: c15927f20d4727c3b8de68497b6949e72f9e6e9e


but not in

Version 4.1.0.0.alpha0+ (Build ID: efca6f15609322f62a35619619a6d5fe5c9bd5a)
Comment 4 Aron Budea 2020-05-04 00:10:39 UTC
This deteriorated in two steps, possibly more, but the behavior was a bit random at some point, sometimes if you moved up from "pariatur.", you didn't jump back to the beginning of the line, but moved up a line and stayed in the middle of the line.

1. When repeating the repro steps, and pressing up in the line of "pariatur.", it moved to the beginning of the line. Then if you kept pressing up, it wouldn't move further, but if you stopped and waited for a fraction of a second, you could keep moving up.

This started from the following commit, bibisected using repo bibisect-42max.
https://cgit.freedesktop.org/libreoffice/core/commit/?id=c8b4ffc2adcc744c0d7d5e68944439238828692b
author		Zolnai Tamás <zolnaitamas2000@gmail.com>	2013-07-23 11:18:38 +0200
committer	Zolnai Tamás <zolnaitamas2000@gmail.com>	2013-07-23 20:19:56 +0200

"Check explicitily the space at the end of the line"

2. From this commit it wouldn't move further up by pressing the up key when you've ended up at the beginning of the line.

Bibisected using repo bibisect-44max
https://cgit.freedesktop.org/libreoffice/core/commit/?id=d58bea0ffa2a2fe79103ab7aa743aea63e27a0fd
author		Juergen Funk <juergen.funk_ml@cib.de>	2014-09-17 16:31:20 +0200
committer	Samuel Mehrbrodt <s.mehrbrodt@gmail.com>	2014-09-22 08:01:57 +0000

Fix fdo#38884 Improve Up/Down movement in writer
Comment 5 Xisco Faulí 2021-03-03 15:39:48 UTC
*** Bug 118024 has been marked as a duplicate of this bug. ***
Comment 6 sdc.blanco 2021-03-03 16:17:37 UTC
(In reply to Xisco Faulí from comment #5)
> *** Bug 118024 has been marked as a duplicate of this bug. ***
Attachment 157127 [details] and Attachment 157622 [details] from bug 118024 have several simple test cases to demonstrate the problem. None of these cases involve a hyphen, so this bug is more general than the summary indicates.
Comment 7 Xisco Faulí 2021-03-03 16:20:46 UTC
(In reply to sdc.blanco from comment #6)
> (In reply to Xisco Faulí from comment #5)
> > *** Bug 118024 has been marked as a duplicate of this bug. ***
> Attachment 157127 [details] and Attachment 157622 [details] from bug 118024
> have several simple test cases to demonstrate the problem. None of these
> cases involve a hyphen, so this bug is more general than the summary
> indicates.

The problem is not reproducible if the space at the end is removed ( at least in the testcase I tried ) which matches the bisection of this issue < c8b4ffc2adcc744c0d7d5e68944439238828692b > "Check explicitily the space at the end of the line"
Comment 8 Dávid Horváth 2021-03-03 16:50:48 UTC
Generally, you can not navigate to the end of the line after the hyphen. If you are coming from left with the Right key, then you will be "redirected" to the start of the next line.

The same happens when you are coming with Up. So, in this case, the target position (the last "valid" position in the line) should be the position BEFORE the hyphen.