Bug 124909 - Swiss German Dictionary missing
Summary: Swiss German Dictionary missing
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: iOS Editor (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: Other iOS
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:6.3.0 target:7.2.0
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-23 13:09 UTC by Andreas Gruhler
Modified: 2021-03-17 13:00 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Swiss German dictionary missing in the iOS-App (461.39 KB, image/png)
2019-04-23 13:09 UTC, Andreas Gruhler
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Gruhler 2019-04-23 13:09:29 UTC
Description:
The Swiss German dictionary seems to be missing in the iOS App. I can only find the German dictionary for "German (Germany)". Please find the screenshot attached.

Steps to Reproduce:
1. Open a new document in the iOS-App
2. Choose Extras > Language > For All Text > German (Switzerland)

Actual Results:
1. New document opens in the iOS-App
2. There is no option "German (Switzerland)", only "German (Deutschland)"

Expected Results:
1. New document opens in the iOS-App
2. There is an option "German (Switzerland)", not only "German (Deutschland)"


Reproducible: Always


User Profile Reset: No



Additional Info:
Comment 1 Andreas Gruhler 2019-04-23 13:09:50 UTC
Created attachment 150949 [details]
Swiss German dictionary missing in the iOS-App
Comment 2 Aron Budea 2019-04-24 05:03:11 UTC
Confirmed.
Comment 3 How can I remove my account? 2019-04-24 12:08:40 UTC
Would it be good enough if the menu simply said "Deutsch" and not "Deutsch (Deutschland)"? It seems that the built-in system German spell checker actually accepts either Swiss or German orthography. It accepts both Maßstab and Massstab, for instance.
Comment 4 Commit Notification 2019-04-24 13:28:58 UTC
Tor Lillqvist committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/dedf339aa14df31c134650660b9aac55bdd8464d%5E%21

tdf#124909: Assume the iOS de_DE dictionary works well enough generically

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 How can I remove my account? 2019-04-24 13:37:07 UTC
We use mostly the same code to interface with the system spell checker on macOS and iOS. On macOS, the system reports that it has a generic German ("de") dictionary, and our code then assumes it can be use for all six German locales ("de_AT", "de_BE", "de_CH", "de_DE", "de_LI", and "de_LU"). But on iOS the system reports it specifically has a German (Germany) ("de_DE") dictionary. As experimentation showed (comment #3), it still accepts both Swiss and German spelling, though, so assume it, too, works well enough for all six locales.

Now "Deutsch (Schweiz)" shows up in the menu, too.
Comment 6 How can I remove my account? 2021-03-17 10:10:50 UTC
The iOS system German dictionary is not good enough for Swiss German. A better fix is to use a separate Swiss German myspell dictionary also on iOS, see https://gerrit.libreoffice.org/c/core/+/112603 .
Comment 7 Commit Notification 2021-03-17 12:57:53 UTC
Tor Lillqvist committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/cb6ba06d286d0b44e0a54635588e33c2a650e0b8

tdf#124909: Use the myspell dictionary for Swiss German on iOS

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 How can I remove my account? 2021-03-17 13:00:01 UTC
(Above fix also in the cp-6.4 branch.)

Another possibility would have been to use code to detect any ß explicitly for de_CH and fail already before even invoking the system spell checker. (And correspondingly then generate replacement suggestions with s/ß/ss/.) Possibly that would have been better?