Bug 125574 - FILEOPEN: DOCX: Vertical Cells are displayed as separated instead of as merged
Summary: FILEOPEN: DOCX: Vertical Cells are displayed as separated instead of as merged
Status: RESOLVED DUPLICATE of bug 120315
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.3.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, implementationError
Depends on:
Blocks: DOCX-Tables
  Show dependency treegraph
 
Reported: 2019-05-29 11:38 UTC by Xisco Faulí
Modified: 2019-11-04 09:15 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
comparison MSO 2010 and LibreOffice 6.3 Master (166.02 KB, image/png)
2019-05-29 11:38 UTC, Xisco Faulí
Details
BeforeAndAfterInLO6.4A1+ (155.08 KB, image/png)
2019-11-04 09:13 UTC, Attila Bakos (NISZ)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2019-05-29 11:38:03 UTC
Created attachment 151759 [details]
comparison MSO 2010 and LibreOffice 6.3 Master

Steps to reproduce:
1. Open attachment 63889 [details] from bug 51785

-> Cells on the right of rows 1,2,3 as displayed as separated. See attached screenshot

Reproduced in

Version: 6.3.0.0.alpha1+
Build ID: 69b62cfcbd364d7f62142149c2f690104b217ca1
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded
Comment 1 Xisco Faulí 2019-05-29 11:39:49 UTC
[Bug found by office-interoperability-tools]

Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=e502463fa9a601963aa9f5a8783eb1318de36c13

author	Miklos Vajna <vmiklos@collabora.com>	2019-03-11 21:40:44 +0100
committer	Miklos Vajna <vmiklos@collabora.com>	2019-03-12 08:43:22 +0100
commit e502463fa9a601963aa9f5a8783eb1318de36c13 (patch)
tree 5c24cbd991d6352e782557406c83a482ae956a8b
parent af836fe33dd42c6043ef70f897c90c8b3ba826a7 (diff)
tdf#123104 DOCX import: fix lack of vertical merge due to rounding

Bisected with: bibisect-linux64-6.3

Adding Cc: to Miklos Vajna
Comment 2 Miklos Vajna 2019-05-29 11:59:21 UTC
Reading git history here, this was never really working. It was "working" between commit 29cbbad64088354425c606f9eb6c267bdf7731dc and e502463fa9a601963aa9f5a8783eb1318de36c13, but in fact it only worked with serious side effects (see bug 123104). So there was a window in time where this was better, but in the long run, this was never made to work properly.

I agree it's a bug and it should be fixed, but not really a regression, I would argue.
Comment 3 Attila Bakos (NISZ) 2019-11-04 09:13:55 UTC
Created attachment 155496 [details]
BeforeAndAfterInLO6.4A1+

Hi there!

It seems to me, this bug is fixed by the patch committed for the tdf120315. For details see the last attachment (BeforeAndAfterInLO6.4A1+). This patch will be avialable in LibreOffice 6.4 release. Changed to duplicate of tdf120315.
Comment 4 Attila Bakos (NISZ) 2019-11-04 09:15:05 UTC

*** This bug has been marked as a duplicate of bug 120315 ***