Description: Crash in swlo!SwRedlineData::SetSeqNo Steps to Reproduce: 1. Open attachment 151856 [details] 2. Download attachment 141990 [details] 3. Edit -> Track changes -> Compare documents & select attachment 141990 [details] 4. Accept all in the dialog & close 5. Repeat step 3/4 6. Press CTRL+Z -> Crash Actual Results: Crash Expected Results: No Crash Reproducible: Always User Profile Reset: No Additional Info: Version: 6.4.0.0.alpha0+ (x86) Build ID: 93477d1a963e38e3319013e43835a8ffef200972 CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; TinderBox: Win-x86@42, Branch:master, Time: 2019-06-02_10:16:52 Locale: it-IT (nl_NL); UI-Language: en-US Calc: threaded
No repro with Version: 6.3.0.0.beta1 (x64) Build ID: a187af327633f5f00363be5131bd21a13e0f1a7b CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; Locale: en-US (de_DE); UI-Language: en-GB Calc: threaded
Confirm crash with Version: 6.3.0.0.alpha1+ Build ID: 53325b40b557cc84d8d21c1baa0ef8d3bfc00ab8 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; redline - add Samuel to cc
@Raal Slightly confused: Redline = Michael Stahl; as far I know
(In reply to Telesto from comment #3) > @Raal > Slightly confused: Redline = Michael Stahl; as far I know Sorry, my fault
Regression introduced by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=d258fc29560baa5ecae03ebc2740e11420643e27 author Michael Stahl <Michael.Stahl@cib.de> 2018-09-03 18:07:29 +0200 committer Michael Stahl <Michael.Stahl@cib.de> 2018-09-19 10:18:29 +0200 commit d258fc29560baa5ecae03ebc2740e11420643e27 (patch) tree b934fcbe96f5f433e05f365edc438499de63d671 parent f32075fd7404dba62ae844cff84fdb43a91ac600 (diff) sw_redlinehide_2: update frames on redline ops Bisected with: bibisect-linux64-6.2 Adding Cc: to Michael Stahl
In my case I can reproduce it with the following steps: 1. Compare both documents 2. Accept all the changes 3. Close the track changes dialog 4. Undo
fixed on master
Michael Stahl committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/edca548f865f4c19f213c1386905ec3591326461%5E%21 tdf#125660 sw_redlinehide: don't create redlines for GrfNode/OLENode It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-6-3": https://git.libreoffice.org/core/+/da23e848b697a22b5cc8ea2e0dbfb38dfa0b3d66%5E%21 tdf#125660 sw_redlinehide: don't create redlines for GrfNode/OLENode It will be available in 6.3.0.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-6-2": https://git.libreoffice.org/core/+/315a43ec55895648e1c3a2a5cb7d1615099bf04c%5E%21 tdf#125660 sw_redlinehide: don't create redlines for GrfNode/OLENode It will be available in 6.2.6. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Verified in Version: 6.4.0.0.alpha0+ Build ID: 52800731baf9fcb88e54d60de5585640c8f97f7b CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: threaded @Michael Stahl, thanks for fixing this issue!
Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-6-2-5": https://git.libreoffice.org/core/+/de572b2973ebddd8e368e8441bb2831be893cc44%5E%21 tdf#125660 sw_redlinehide: don't create redlines for GrfNode/OLENode It will be available in 6.2.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.