Bug 125756 - Draw MIME type icon overlay on thumbnails at the start center
Summary: Draw MIME type icon overlay on thumbnails at the start center
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.2.4.2 release
Hardware: x86-64 (AMD64) Windows (All)
: medium enhancement
Assignee: Heiko Tietze
URL:
Whiteboard: target:6.4.0
Keywords:
Depends on:
Blocks: Start-Center
  Show dependency treegraph
 
Reported: 2019-06-06 18:24 UTC by Chris Tsekouras
Modified: 2021-02-25 10:36 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
[1] screenshot the same as image [1] in bug (85.55 KB, image/png)
2019-06-06 18:25 UTC, Chris Tsekouras
Details
[2] the suggested changes - mockup, same as the mockup [2] in the bug report (92.41 KB, image/png)
2019-06-06 18:26 UTC, Chris Tsekouras
Details
Patch applied (116.66 KB, image/png)
2019-07-29 10:08 UTC, Heiko Tietze
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Tsekouras 2019-06-06 18:24:14 UTC
Description:
as shown in the screenshot [1] you cannot see the extention of the file so same named files with long name and different extention cannot be distinguished

well it has a workaround, you can hover the file and see the bubble but I have a suggestion:

in many apps and programms when a filename is displayed at least the extention is visible in the end like so: google-docs-sear...6_x64.odt

also in the same example you can add the last few chars, so, if two files are named almost the same but some chars in the end are different, you can see the difference!

[1]https://postimg.cc/5YCwf2r3

proposed changes mockup

[2] https://postimg.cc/7JrShy8y

all images together
[3] https://postimg.cc/gallery/1e1fsfgi4/

Steps to Reproduce:
1. open libreoffice (you see the recent files) see [1]
2. no extention visible if the file name is big


Actual Results:
pic [1.1] no way to see last chars or at least extention so same named files with different extention or almost same named files look the same (if they have the same thumbnail then they are indistinguishable)

[1] https://postimg.cc/5YCwf2r3

Expected Results:
show last few chars and extention as shown in a quick mockup [3.1]

[2] https://postimg.cc/7JrShy8y


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.2.4.2 (x64)
Build ID: 2412653d852ce75f65fbfa83fb7e7b669a126d64
CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; 
Locale: en-US (en_US); UI-Language: en-US
Calc: CL
Comment 1 Chris Tsekouras 2019-06-06 18:25:57 UTC
Created attachment 151994 [details]
[1] screenshot the same as image [1] in bug

its the same image as the screenshot [1] in the bug
Comment 2 Chris Tsekouras 2019-06-06 18:26:46 UTC
Created attachment 151995 [details]
[2] the suggested changes - mockup, same as the mockup [2] in the bug report

its the same image as the mockup [2]
Comment 3 Roman Kuznetsov 2019-06-06 19:33:06 UTC
+1 from me

UX-team, what do you think?
Comment 4 V Stuart Foote 2019-06-07 01:03:17 UTC
Not a fan. We already provide the full path with extension (if any) as a Tool-tip on mouse over of the thumbnail.  Labeling with the file name--suplemented with the full path name & extension was the design decision when we laid out the StartCenter.

See no reason to change that now.

IMHO => WF
Comment 5 Olivier R. 2019-06-07 07:39:43 UTC
I also think extension should be visible. I had never noticed it was visible with the tooltip.

IMHO, we should even see the extension as a very visible tag upon the preview icon.
Comment 6 Heiko Tietze 2019-06-07 20:57:58 UTC
What you likely want to know is the module in which the file would be loaded. Meaning odt = Writer, ods = Calc etc. That applies also to docx and xlsx but how about hdg or nyz? (fictional file extension you never heard about). So wouldn't the best solution be a small overlay MIME type icon indicating the LibreOffice module?
Comment 7 Olivier R. 2019-06-08 05:21:31 UTC
Most of the time, yes.
But sometimes I need to make a distinction between an odt file, a doc file, a text file that have the same name.
Comment 8 Heiko Tietze 2019-06-12 12:03:32 UTC
(In reply to Olivier R. from comment #7)
> Most of the time, yes.

So let's have an overlay with the MIME type icon for the relevant cases and stick to the tooltip if in doubt according comment 4.
Comment 9 Heiko Tietze 2019-07-29 10:08:31 UTC
Created attachment 153029 [details]
Patch applied

That's how it would look with icon overlay. The actual filename and extension is still available per tooltip.

Patch is under review at https://gerrit.libreoffice.org/#/c/76537/
Comment 10 Commit Notification 2019-08-06 07:27:00 UTC
Heiko Tietze committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/d43c6fa220524a09c0b24cbb5bc03c4456cd2515%5E%21

Resolves: tdf#125756 - MIME type icons on start center's thumbnails

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Mike Kaganski 2019-08-14 10:44:46 UTC
A note: the overlay icons are not the same as used in the left sidebar of the Start Center that launch respective modules (more detailed? maybe other icons, or other resolution?)
Comment 12 Heiko Tietze 2019-08-16 11:53:48 UTC
(In reply to Mike Kaganski from comment #11)
> ... maybe other icons, or other resolution?

Any proposal? Would be nice, indeed, to have icons not only for LibreOffice modules but all known file formats.
Comment 13 Mike Kaganski 2020-02-24 15:01:51 UTC
(In reply to Heiko Tietze from comment #12)
> Any proposal? Would be nice, indeed, to have icons not only for LibreOffice
> modules but all known file formats.

In https://gerrit.libreoffice.org/c/core/+/76537, you used the full-sized icons (128 pixel) from BitmapForExtension/EncryptedBitmapForExtension. Then you scaled those bitmaps to 40 pixel resolution, with all the raster image downsampling side effects.

But indeed, we also have lower-resolution icons for the same things, like those shown in the "Create" panel on the same start center screen (I don't know which their resource ids are, but I'm sure Andreas or Rizal could help here?). So using, say, 32-pixel icons here without any scaling would result in sharp overlays without downsampling artifacts.

Note that I'm not talking about more fine-grained MIME icons like for every supported filetype; only about per-application icons, just as you used in the change.