Bug 125760 - UI: Notes View: Currently selected / opened slide is not visible during edit
Summary: UI: Notes View: Currently selected / opened slide is not visible during edit
Status: RESOLVED DUPLICATE of bug 92254
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
3.4.0 release
Hardware: All All
: low minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: preBibisect, regression
Depends on:
Blocks:
 
Reported: 2019-06-06 19:52 UTC by DarkTrick
Modified: 2022-12-20 16:31 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description DarkTrick 2019-06-06 19:52:54 UTC
Description:
UI: Notes View:
While editing a note, the currently selected slide is not marked. 
This is different for e.g. the Normal View. Even though the slide is edited, there's still a selection inside the "Slides" side pane.

OS: XUbuntu, xfce

Steps to Reproduce:
1. Add 2 slides
2. Open "Notes View" ( Top menu -> View -> Notes View )
3. Select slide 2
4. Select slide 1
5. Edit the note

Actual Results:
Selection inside the "Slides" pane vanishes. 

Expected Results:
Selection inside the "Slides" pane stays - Like the behaviour for "Normal View", when editing slides.



Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
Happens with OpenGL enabled AND disabled.

Side note: 
The current implementation in the "Normal View" is also not perfect, as it advertises the focus to be inside the "Slides" pane, while it is actually inside  the slide itself. 
This is a different enhancement, but I thought it's worth noting here.
Comment 1 Xisco Faulí 2019-11-15 11:25:42 UTC
Reproduced in

Version: 6.4.0.0.beta1+
Build ID: e54b0467422e8871600ae93b953a0770dc27e785
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

i think this is a normal bug
Comment 2 Xisco Faulí 2019-11-15 11:26:54 UTC
Also reproduced in

Version 4.1.0.0.alpha0+ (Build ID: efca6f15609322f62a35619619a6d5fe5c9bd5a)
Comment 3 Timur 2019-12-06 20:08:19 UTC
No repro LO 3.3, repro LO 3.5. Regression. I guess NotBibisectable.
Comment 4 Aron Budea 2020-01-19 09:26:08 UTC
Note that this might appear fine at first, and bad after repetition (which I could repro even in 3.4.0.1). Not sure if the steps matter, let's not bother with even trying to bibisect this.
Comment 5 Justin L 2021-11-26 11:11:37 UTC
Using PageUp or PageDown keys show the selected slide highlighted and it stays selected when working on the Notes. But when clicking on in the slide pane to select one, and then working on the Note, the selection disappears.
Comment 6 Justin L 2021-11-26 15:05:57 UTC
The code related to this appears to be sd/source/ui/slidesorter/model/SlideSorterModel.cxx's GetIndex

because

    if (pDescriptor && pDescriptor->GetXDrawPage() == rxSlide)

rxSlide points to a different draw page.

First LO bibisect source commit is in 2011. 

The last significant change here was
commit 834905dfdf7c20604b8ff35b0444355b62c12d48
Author: Kurt Zenker on Thu Apr 3 13:40:49 2008 +0000
    INTEGRATION: CWS presenterview (1.8.54); FILE MERGED
Comment 7 Justin L 2021-12-01 11:52:41 UTC
It would be good for someone with a high-level view of Impress/Draw to review this. I'm not sure what the implications are, or knowing what ought to be happening here. Should it only try to compare the actual slide while in the normal slide view?
Comment 8 Axel Braun 2022-05-28 15:33:42 UTC
I just stumble over the same (?) problem - when editing notes, the selected slide is not displayed above the notes section.
Same error?
Version: 7.3.3.2 / LibreOffice Community
Build ID: 30(Build:2)
CPU threads: 12; OS: Linux 5.17; UI render: default; VCL: kf5 (cairo+xcb)
Locale: de-DE (de_DE.UTF-8); UI: en-US
Calc: threaded
Comment 9 Mike Kaganski 2022-12-20 16:31:26 UTC

*** This bug has been marked as a duplicate of bug 92254 ***