Created attachment 152657 [details]
Save Icon Changes Size screencast
With Version: 188.8.131.52 (x64)
Build ID: 41ac97386aba908b6db860cfb4cfe2da871886ae
CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win;
Locale: ru-RU (ru_RU); UI-Language: en-US
when the open document gets modified, and the icon on the Save toolbar button needs to change to indicate that, its size is changed: see attached screencast.
This is reproducible with any built-in icon set (Colibre, Sifr, Breeze), including SVG variants. Toolbar icon size is Automatic.
Possibly related: DPI scaling is 150% in Windows settings.
*** Bug 126230 has been marked as a duplicate of this bug. ***
New as per dupe 126230, Tango icon theme with scaled UI
*** Bug 126349 has been marked as a duplicate of this bug. ***
Bibisected to the following commit using repo bibisect-win32-6.3, but I'm not sure if the commit is directly responsible for this, probably somewhere an icon file is incorrect.
author Noel Grandin <email@example.com> 2018-12-07 10:29:02 +0200
committer Noel Grandin <firstname.lastname@example.org> 2018-12-08 19:15:09 +0100
use Image(OUString) instead of Image(Bitmap(OUString))
The problem is the code in
where it follows a completel different path for the "save" icon.
Probably this code needs to take into account DPI settings somehow.
*** Bug 126957 has been marked as a duplicate of this bug. ***
@Maxim, Noel -- do you think bug 127434 would be a similar issue of bypassing UI scaling applied to icons of the Sidebar's Tab bar , and icons of the Status Bar's view layout ?
(In reply to V Stuart Foote from comment #8)
Oh, and likewise the other icons on the status bar that are not picking up os/DE system scaling of the UI...
The selection mode
The modified state
fixed by commit
*** Bug 127757 has been marked as a duplicate of this bug. ***
Confirm scaling issues fixed in master (2019-09-26), don't see a backport to 6.3 in gerrit...
@Michael M. ?
(In reply to V Stuart Foote from comment #12)
> Confirm scaling issues fixed in master (2019-09-26), don't see a backport to
> 6.3 in gerrit...
> @Michael M. ?
@Michael Meeks, considering your commit fixed this issue and bug 127434, should it be backported to 6.3 ?
Sure - why not if someone wants to test & maintain that, I don't have time personally, sorry !
Michael Meeks committed a patch related to this issue.
It has been pushed to "libreoffice-6-3":
tdf#126293 Use lazy-loading stock Image to simplify fwk image lists
It will be available in 6.3.4.
The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
Affected users are encouraged to test the fix and report feedback.