Bug 126632 - Tabs in Tabbed Compact don't update after adding of table and moving of cursor to body text in Writer document
Summary: Tabs in Tabbed Compact don't update after adding of table and moving of curso...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.4.0.0.alpha1+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.6.0 target:7.5.3 target:7.4.7
Keywords:
Depends on:
Blocks: Notebookbar-Resize Notebookbar-Tabbed
  Show dependency treegraph
 
Reported: 2019-07-31 06:03 UTC by Roman Kuznetsov
Modified: 2023-05-23 20:53 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Roman Kuznetsov 2019-07-31 06:03:19 UTC
Description:
Tabs in Tabbed Compact don't update after adding of table and moving of cursor to body text in Writer document

Steps to Reproduce:
1. Open Writer
2. Toggle UI to Tabbed Compact
3. Tab Insert => Table => insert table with any numbers of rows and columns
4. Look at tabs => there is highlighted Table tab
5. Move cursor in to body text
6. Look at tabs => there is still highlighted Table tab and you can't select Tools tab
7. Select Table tabs => it's Tools tab! And you see TWO Tools tab
8. Hide/show LibreOffice window => tabs look good

Actual Results:
tabs don't update after moving cursor in to body text

Expected Results:
tabs update after moving cursor in to body text and looks fine


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.4.0.0.alpha0+ (x86)
Build ID: 29fbb2512c741bc34221b7d13b9958c832f0a3f7
CPU threads: 4; OS: Windows 6.1; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-07-24_03:19:14
Locale: ru-RU (ru_RU); UI-Language: en-US
Calc: threaded
Comment 1 Xisco Faulí 2020-01-23 12:21:57 UTC
This is what I see in

Version: 6.5.0.0.alpha0+
Build ID: a821d89646ef25428cf5992f86d8f31581313bdb
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded

Once I moved the cursor outside the table, Home tab is highlighted but the table tab is still there. Then if I click on it, it disappears...
Comment 2 V Stuart Foote 2023-03-20 16:19:26 UTC
Issue with the NB Tabbed Compact tab logic continues, STR here and from the see also bug 152908 have the NB tabs for the Tabbed Compact UI out of sync.

Version: 7.5.1.2 (X86_64) / LibreOffice Community
Build ID: fcbaee479e84c6cd81291587d2ee68cba099e129
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

@Jim, I don't think this was you. But maybe something done for the NB Tabbed UI needed to matched with the NB Tabbed Compact UI?
Comment 3 Jim Raykowski 2023-03-24 06:03:48 UTC
I had to remove a couple of asserts to test using debug builds but I don't repro with either x11 or gtk3 vcl plugins:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 770580ba8e9546aa7b960c8b622b936ba6cf9d37
CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: x11 and gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 4 Jim Raykowski 2023-03-24 06:21:13 UTC
After closer examination, I do repro. 

Looking into it.
Comment 5 Buovjaga 2023-03-26 16:17:41 UTC
(In reply to Jim Raykowski from comment #3)
> I had to remove a couple of asserts to test using debug builds but I don't
> repro with either x11 or gtk3 vcl plugins:

Side note: one assert is reported as bug 154282
Comment 6 Jim Raykowski 2023-03-26 16:40:13 UTC
Proposed patch that covers both this bug report and similar reported bug in bug 152908:
https://gerrit.libreoffice.org/c/core/+/149593
Comment 7 Commit Notification 2023-03-26 23:48:48 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/e0daa98a802cc1f84ceb0f306f5d15fecabd62c1

tdf#126632 tdf#152908 Resize the notebook bar on context change

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2023-03-27 10:41:53 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/b2575b26f403e97b5a1e85559d1506a0f60b3903

tdf#126632 tdf#152908 Resize the notebook bar on context change

It will be available in 7.5.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2023-03-27 16:52:37 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/9c6bf935cd447922f8e6c974d545832d03779b12

tdf#126632 tdf#152908 Resize the notebook bar on context change

It will be available in 7.4.7.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Justin L 2023-05-23 20:53:57 UTC
confirmed fix using SAL_USE_VCLPLUGIN=gen instdir/program/soffice