Description: User Interface fail to repaint tabs when a tab get added or removed due to context changes. Steps to Reproduce: 1. Open Writer 2. Write simple sentence 3. Insert a table on the next line 4. Switch User Interface to Tabbed Compact 5. Move the cursor between table cell and simple sentence Actual Results: Tabs painting over other tabs Expected Results: Tabs repaint without overlapping Reproducible: Always User Profile Reset: Yes Additional Info: Confirmed on Windows 10 and MacOS 13.0.1
Bibisected with win64-7.0 to 68c96a54fef93b9f735aeb6c9ae07171e934132a tdf#131209 reload the notebook bar Before this commit, it was repainted with a slight delay.
Created attachment 186094 [details] phantom Tools tab on NB Tabbed Compact UI The MUFFIN NB framework has always had awareness of display width. Drag the LO Window frame wide enough and this never occurs, it is only when the LO frame is dragged narrower than ~1140px that the shift in padding applied to Tab labels occurs. At that point all padding to Tab labels is removed. Adding a Table to the document adds the contextual Tab to the NB. The NB will become wider to accommodate. But if the table is then removed (select and delete all columns) the NB will remove the Table tab *but does not recalculate its width* and the Tab labels/edge marks overlap. In fact the Tab for the Tools leaves a residual at the end of the NB (clip attached). Issue seems only to be on the NB Tabbed Compact but not on the NB Tabbed UI.
The buggy behavior doesn't happen for me when the tab is set to other than the Table tab and then the cursor is moved from the table to a simple sentence below the table. And it doesn't occur for me when using the gtk3 vcl backend. (In reply to Buovjaga from comment #1) > Bibisected with win64-7.0 to 68c96a54fef93b9f735aeb6c9ae07171e934132a > tdf#131209 reload the notebook bar > > Before this commit, it was repainted with a slight delay. The bibisected patch itself caused a regression and the fix for that caused a regression so hopefully the fix offered here will not also cause a regression: https://gerrit.libreoffice.org/c/core/+/149593
Created attachment 186241 [details] 20230326 nightly with patch, does not correctly refreshing NB Tabbed Compact waiting for https://gerrit.libreoffice.org/c/core/+/149593 to roll screen clip just status quo until it does.
make that 20230326 nightly without patch
(In reply to V Stuart Foote from comment #4) > waiting for https://gerrit.libreoffice.org/c/core/+/149593 to roll Jenkins has been having problems with this one. I'll put it in as soon as it passes. I've tested with x11, qt5, and gtk3 vcl plugins.
Jim Raykowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/e0daa98a802cc1f84ceb0f306f5d15fecabd62c1 tdf#126632 tdf#152908 Resize the notebook bar on context change It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Jim Raykowski committed a patch related to this issue. It has been pushed to "libreoffice-7-5": https://git.libreoffice.org/core/commit/b2575b26f403e97b5a1e85559d1506a0f60b3903 tdf#126632 tdf#152908 Resize the notebook bar on context change It will be available in 7.5.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Jim Raykowski committed a patch related to this issue. It has been pushed to "libreoffice-7-4": https://git.libreoffice.org/core/commit/9c6bf935cd447922f8e6c974d545832d03779b12 tdf#126632 tdf#152908 Resize the notebook bar on context change It will be available in 7.4.7. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Seems to work fine, thanks Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 4daeb21a5f533144fd6b3bc397a98f37e5b1dd4c CPU threads: 2; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win Locale: en-US (en_FI); UI: en-US Calc: threaded
Yes. It is behaving now on master against 7.6.0, same STR Already backported to 7.5.3 and 7.4.7, need to double check nightlys for those. Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 4daeb21a5f533144fd6b3bc397a98f37e5b1dd4c CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded