Bug 126933 - LO Writer shows some Buttons almost Unreadable when using High Contrast Theme
Summary: LO Writer shows some Buttons almost Unreadable when using High Contrast Theme
Status: UNCONFIRMED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.4.0.0.alpha1+
Hardware: x86-64 (AMD64) Linux (All)
: medium trivial
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: High-Contrast
  Show dependency treegraph
 
Reported: 2019-08-14 22:18 UTC by Adalbert Hanßen
Modified: 2020-03-16 12:36 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
first picture: some depressed and some undepressed buttons in LibreOfficeWriter. (4.49 KB, image/png)
2019-08-14 22:18 UTC, Adalbert Hanßen
Details
second picture: original undepressed keys, inverted and proposed special inverted display (15.54 KB, image/png)
2019-08-14 22:20 UTC, Adalbert Hanßen
Details
third picture: The color transformation curve used in Gimp for a special inversion for the depressed states (31.60 KB, image/png)
2019-08-14 22:24 UTC, Adalbert Hanßen
Details
Attachment mentioned in comment #4 (174.72 KB, application/vnd.oasis.opendocument.text)
2020-03-01 22:05 UTC, Adalbert Hanßen
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Adalbert Hanßen 2019-08-14 22:18:46 UTC
Created attachment 153397 [details]
first picture: some depressed and some undepressed buttons in LibreOfficeWriter.

This bug report pertains to

Version: 6.4.0.0.alpha0+
Build-ID: 9ee5ad5a0b84bfa652da34694ba4f75668f06087
CPU-Threads: 4; BS: Linux 4.4; UI-Render: Standard; VCL: gtk3; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2019-07-30_13:21:44
Gebietsschema: de-DE (de_DE.UTF-8); UI-Sprache: de-DE
Calc: threaded
running on Xubuntu 16.04 and as well on 18.04.

I tried windows manager’s theme „Hoher Kontrast“ (probably it is called High Contrast in an English version). However, using it in connection with LibreOffice, the buttons which have a permanent on/off state become almost unreadable when they are activated. 

When depressed, LibreOffice's buttons are flooded with dark color. Since the key caps inscription is in dark grey, they become almost unreadable then. Try it out e.g. with bold, italic, underlined, … as shown in my first picture.
First I thought this is a problem of xfwm4, the window manager of xfce4 and I reported a bug at https://bugzilla.xfce.org/show_bug.cgi?id=15826. However I was told, xfwm4 has nothing to do with how the applications draw their own widgets. I should report the bug at the make of the application instead.

If one would just invert the color of the pressed key, the on and off states for bold/italic/underlined/subscripted/superscripted…. would clearly be recognized in one or the other state and this would work in any a windows manager settings as shown in my second picture.

Instead of inverting, one might do a little better by inverting the button using a negatively bent brightness curve as shown in my third picture.
Comment 1 Adalbert Hanßen 2019-08-14 22:20:55 UTC
Created attachment 153398 [details]
second picture: original undepressed keys, inverted and proposed special inverted display
Comment 2 Adalbert Hanßen 2019-08-14 22:24:37 UTC
Created attachment 153399 [details]
third picture: The color transformation curve  used in Gimp for a special inversion for the depressed states

The bent curve is the inversion applied in the third row (this has been done in GIMP). This one shows the added items more clearly.

In the pressed state, a button should best be shown in such a special inversion mode. This can be done by applying a proper look up table for the pixle colors.
Comment 3 Xisco Faulí 2020-02-18 17:07:24 UTC
Could you please try to reproduce it with a master build from http://dev-builds.libreoffice.org/daily/master/ ?
You can install it alongside the standard version.
I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' if the bug is still present in the master build
Comment 4 Adalbert Hanßen 2020-03-01 22:02:24 UTC
Unfortunately the appearance is not really pleasant under the high contrast theme in

Version: 7.0.0.0.alpha0+
Build ID: 48295aead3e15c62d31157f963bd5728f7278db5
CPU threads: 4; OS: Linux 5.3; UI render: default; VCL: gtk3; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2020-02-29_21:13:36
Locale: de-DE (de_DE.UTF-8); UI-Language: en-US
Calc: threaded

It could easily be done better (and the method to invert the appearance of a depressed button is probably the easiest thing to implement since the inverting operation applied an even number of times returns to where it left off). But it could be made even nicer with a similar approach as in the attached document, but that is not inverse to itself. One would have to keep a copy of the bitmap of the pressed button to re-establish if a pressed  button gets reverted to unpressed.

BTW: I don’t like it that pictures pasted are now by default anchored to the character. I know, it has been an endless discussion between 2014 and 2019 under Bug 79234, Bug 87720. Bug 99646 e.g. requested to make the default anchor “to character”, however I don’t like it that way, I just like placing pictures anchored to paragraph by default. 

I had to manually anchor each picture in this document to the paragraph to really get what I want. I’d still advocate to make the default anchoring to be configurable (at least for new documents). A good place would be in Frame Styles:Graphics under the tab Wrap. It leaves enough space place buttons letting one to select between anchor to page/paragraph/character and since this would be in the style sheet aka template, every LO user could set it to his/her personal preferences. However, there seem to be some pagination and image placement bugs which are/were(?) buried deep in LO and even in OOO.
Comment 5 Adalbert Hanßen 2020-03-01 22:05:15 UTC
Created attachment 158291 [details]
Attachment mentioned in comment #4
Comment 6 Dieter 2020-03-15 09:21:12 UTC
(In reply to Adalbert Hanßen from comment #4)
> BTW: I don’t like it that pictures pasted are now by default anchored to the
> character. I know, it has been an endless discussion between 2014 and 2019
> under Bug 79234, Bug 87720. Bug 99646 e.g. requested to make the default
> anchor “to character”, however I don’t like it that way, I just like placing
> pictures anchored to paragraph by default. 

Adalbert, please don't mix diferent topics in one bug report. Thank you.
Comment 7 Dieter 2020-03-15 09:23:03 UTC
(In reply to Adalbert Hanßen from comment #0)
> I tried windows manager’s theme „Hoher Kontrast“ (probably it is called High
> Contrast in an English version). However, using it in connection with
> LibreOffice, the buttons which have a permanent on/off state become almost
> unreadable when they are activated. 

Does it happen with every icon theme? There are some bug reports about high contrast. Have you checked for duplicates or relationships?
Comment 8 Adalbert Hanßen 2020-03-16 12:36:30 UTC
Meanwhile I tried it in the two versions currently installed on my system:
First: The appearance of the tool buttons of LO Writer has changed between version 6.0.7.3 and LibreOfficeDev 7.0.0.0.alpha0+ (2020-03-13_16:53:06): In general the pressed/depressed state in the development version is better distinguishable than in LO Writer version 6.0.7.3. 

The appearance of LO’s butons seems to be almost independent from the theme chosen for xfce4 with two exceptions for the development version:

Adwaita-dark changes everything and the inscriptions on the tool buttons are poorly legible. The difference between the depressed and the non depressed state is distinguishable, but it could be done better.

In the High contrast theme, the pressed and the unpressed states of LO’s tool buttons are easily distinguishable, but the button inscriptions are poorly legible.

Which possible duplicate do you mean? Before my original post, I searched for similar postings bud did not encounter any.