Bug 127540 - menu About > Show License crashes
Summary: menu About > Show License crashes
Status: RESOLVED INSUFFICIENTDATA
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Android Viewer (show other bugs)
Version:
(earliest affected)
6.4.0.0.alpha1+
Hardware: All Android
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:6.4.0
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-14 01:56 UTC by Terrence Enger
Modified: 2019-12-12 18:52 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Terrence Enger 2019-09-14 01:56:43 UTC
Menu options About > Show License exits program abruptly.

I have updated to
master~2019-09-13_06.00.54_LibreOfficeViewer-strippedUIEditing-debug.apk
which is commit c5d37d32, running on a Samsung Galaxy J3, running
kernel version 3.18.14-14435608-QB19866303, 2018-09-20.

For comparison, my previous version of Android Viewer executing the
same menu options gave error message:

    Cannot open /assets/license.txt: Unsupported URL
    <file:///assets/license.txt>: "type detection failed"

I am setting severity minor.
Comment 1 Xisco Faulí 2019-10-21 11:45:15 UTC
it should be fixed in master now

Info from ESC meeting:
    + Android viewer
       + Issue when opening any document? (Xisco)
         + Should be fixed (Cloph)

Could you please try to reproduce it with a master build from http://dev-builds.libreoffice.org/daily/master/ ?
I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' if the bug is still present in the master build
Comment 2 Terrence Enger 2019-10-21 18:27:58 UTC
To be more specific, editing versions only of LibreOffice Viewer upon
an attempt to open any file return the android device to the home
screen; then selecting LibreOffice Viewer from the list of background
applications displays the initial LO screen with list of files.  This
differs from my original report in that the problem extends beyond the
files offered on the About screen.  (I still have .apk.s of Editing
version from August and September.  Whether they open the files or
fail seems random.)

The version without editing capabilities has no problem opening my own
files or the files offered from the About screen.

I see the same behaviours (editing version fails, non-editing version
works) in .apk's timestamped 2019-10-20_23.35.56 and 2019-10-07_11.53.41.

I am setting bug status NEW.  Seeing as the bug extends to failure to
open my own files, I am setting importance up to Normal.

I have time available but little knowledge of Android.  I would
welcome any suggestions for what I might do to help with the problem.
Comment 3 Terrence Enger 2019-10-21 18:28:50 UTC
Whoops.  Bug status to UNCONFIRMED.
Comment 4 Xisco Faulí 2019-11-07 14:22:36 UTC
I believe, the root cause is the same as in bug 123290

*** This bug has been marked as a duplicate of bug 123290 ***
Comment 5 Xisco Faulí 2019-11-07 14:31:33 UTC
Not a duplicate. See:

cloph> x1sc0: I never actually used the apk as provided by a regular "make", but always use android studio's build & deploy - and apparently that did pick up the shared lib for me...
<x1sc0> so you can reproduce the crash now ?
<cloph> yes - should be fixed now. The license typedetection thing remains though https://bugs.documentfoundation.org/show_bug.cgi?id=127540
Comment 6 Commit Notification 2019-11-08 15:10:07 UTC
Christian Lohmaier committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/256e2a3de8af34e751a3fb8329f49f2f362342d1

tdf#127540 android: fix type-detection error when trying About|Show License

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Xisco Faulí 2019-11-09 14:52:59 UTC
@Terrence Enger, Could you please check whether this issue is fixed in a recent master build ?
Comment 8 Terrence Enger 2019-11-09 16:16:36 UTC
Alas, I see no difference in behavior.

This is with the version in
master~2019-11-09_01.35.17_LibreOfficeViewer-strippedUIEditing-debug.apk,
source hash a79640b3.
Comment 9 Michael Weghorn 2019-12-12 12:58:01 UTC
@Terrence:
Just to make clear: What bug exactly is still reproducible? The initial description mentions the "About" -> "Show License" crash that should be fixed by the commit mentioned in comment 6, while comment 2 mentions a problem with opening files...

If the initial problem is fixed, I'd recommend to close this bug and open a new one, to make it possible to focus on the actual issue and avoid confusion.
Comment 10 Terrence Enger 2019-12-12 18:52:52 UTC
(In reply to Michael Weghorn from comment #9)
What I have now is the inability to open any file.  This is
reproducible more often than not; there may be an error message, or
Viewer may just quit.  I did not see that thae commit mentioned in
comment 6 changed anything.

As I see the problems on files other than the ones offered on the
About menu, I guess my problem reduces to one of the earlier bug
reports.  Bugzilla will not let me close this report RESOLVED
DUPLICATE without choosing a particular report, so I closing it
RESOLVED INSUFFICIENTDATA.