Bug 127583 - In "Tabbed" or "Grouped Compact" toolbar modes, switching between light and dark GTK themes does not refresh the styling of the toolbars
Summary: In "Tabbed" or "Grouped Compact" toolbar modes, switching between light and d...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.2.7.1 release
Hardware: All Linux (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: UI-Theming Desktop-Integration Notebookbar-Theming
  Show dependency treegraph
 
Reported: 2019-09-16 20:19 UTC by Jeff Fortin Tam
Modified: 2022-03-20 19:39 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:
Regression By:


Attachments
light to dark (47.88 KB, image/png)
2019-09-16 20:21 UTC, Jeff Fortin Tam
Details
dark to light (57.82 KB, image/png)
2019-09-16 20:21 UTC, Jeff Fortin Tam
Details
GNOME from light to dark in tabbed UI, LO 7.3 alpha0+ (58.91 KB, image/png)
2021-08-01 14:31 UTC, stragu
Details
GNOME from dark to light in groupedbar compact UI, LO 7.3 alpha0+ (51.10 KB, image/png)
2021-08-01 14:32 UTC, stragu
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff Fortin Tam 2019-09-16 20:19:34 UTC
Description:
In "Tabbed" or "Grouped Compact" toolbar modes, switching between light and dark GTK theme (Adwaita) does not refresh the styling of the toolbars.

Starting a new window or changing the toolbar style works around the issue.

Steps to Reproduce:
1. Set LibreOffice's toolbar UI to either "Tabbed" or "Grouped Compact"
2. Open gnome-tweak-tool
3. While a LibreOffice Writer/Calc/etc. GUI is open, switch the GTK theme from "Adwaita Dark" to "Adwaita", or from "Adwaita" to "Adwaita Dark".

Actual Results:
The GUI adapts to the new theme, except the main toolbar. Particularly, the combobox/dropdown widgets change their font color but not the widget's background color, leading to illegible text. 

Expected Results:
The main toolbar should adapt, like the rest.


Reproducible: Always


User Profile Reset: Yes



Additional Info:
See attached screenshots.
Tested on Fedora 30 (the latest stable Fedora version available to me), hence the LibreOffice 6.2.x version.
Comment 1 Jeff Fortin Tam 2019-09-16 20:21:24 UTC
Created attachment 154202 [details]
light to dark

When the app was started with the light theme
Comment 2 Jeff Fortin Tam 2019-09-16 20:21:53 UTC
Created attachment 154203 [details]
dark to light

When the app was started with the dark theme
Comment 3 Heiko Tietze 2019-10-05 08:31:03 UTC
Ordinary bug, please fix it.
Comment 4 stragu 2021-08-01 14:30:23 UTC
Reproduced with recent master build, using the GNOME 3.36 light and dark modes (in GNOME settings > Appearance). Both "Tabbed" and "Groupedbar compact" UIs are affected.

Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: 1dd4a80fa076bedb3a82821517036bad8dd79857
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-07-26_22:41:19
Calc: threaded
Comment 5 stragu 2021-08-01 14:31:30 UTC
Created attachment 174015 [details]
GNOME from light to dark in tabbed UI, LO 7.3 alpha0+
Comment 6 stragu 2021-08-01 14:32:30 UTC
Created attachment 174016 [details]
GNOME from dark to light in groupedbar compact UI, LO 7.3 alpha0+
Comment 7 Jeff Fortin Tam 2022-03-20 19:39:56 UTC
It may now be easier for the app to handle this, as there now is a standardized (i.e. FreeDesktop) way for LibreOffice to authoritatively know, without just trying to "guess" whether the current GTK theme is dark or not, what the user's intent is in terms of light/dark themes.

* Overview here: https://blogs.gnome.org/alexm/2021/10/04/dark-style-preference/
* Implementation tips here: https://gitlab.gnome.org/GNOME/Initiatives/-/wikis/Dark-Style-Preference

Presumably this would let LibreOffice connect to a clear standardized signal, which would allow it to confidently switch over (& refresh) its themes internally when needed.