Bug 153541 - Toggle Appearance mode from Light to System leaves some SB and NB elements in Light mode
Summary: Toggle Appearance mode from Light to System leaves some SB and NB elements in...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.6.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.6.0 target:7.5.2
Keywords:
: 127583 (view as bug list)
Depends on:
Blocks: UI-Theming
  Show dependency treegraph
 
Reported: 2023-02-11 04:35 UTC by V Stuart Foote
Modified: 2023-04-12 16:23 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
screen capture of toggle between System and Light color theme, not fully applied (3.05 MB, image/gif)
2023-02-13 15:13 UTC, V Stuart Foote
Details

Note You need to log in before you can comment on or make changes to this bug.
Description V Stuart Foote 2023-02-11 04:35:11 UTC
With recent work on bug 153229, the new Tools -> Options -> View -> Appearance mode has an issue toggling from 'Light' back to 'Automatic' for Win10 in os/DE 'Dark' color theme.

Elements of the SB, the Decks and the Tab bar are not refreshed and remain in light mode. Similar for backing elements of the Notebook Bar.
Comment 1 V Stuart Foote 2023-02-11 04:38:56 UTC
to fully clear need to exit LO completely not just all modules to Start Center, and only on restart will fully render system Dark mode in the 'Automatic' mode setting.
Comment 2 V Stuart Foote 2023-02-11 04:39:27 UTC
testing with
Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 9788a565b3241d1bd62394b9e29c322361d05f80
CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded
Comment 3 V Stuart Foote 2023-02-11 04:49:51 UTC
Same happens in reverse when in os/DE Light theme and toggling from 'Dark' mode to 'Automatic' mode some elements on the SB and NB do not get correctly toggled. Only clears with restart of LibreOffice.
Comment 4 V Stuart Foote 2023-02-13 15:13:25 UTC
Created attachment 185347 [details]
screen capture of toggle between System and Light color theme, not fully applied

Screen capture of the toggle between System and Light color modes not fully applying to elements of the NB and the SB, and not clearing with module (Writer) restart. As if the UI loses track of the mode it is in.

with the 20230213 TB77 nightly

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 14a36ad49518bcb5b606b0f1640e3ca56b636e89
CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded
Comment 5 Caolán McNamara 2023-02-14 13:17:00 UTC
it seems that the notebookbar is inserted into the widget hierarchy in a non-standard way and wasn't getting any Settings updates at all.

https://gerrit.libreoffice.org/c/core/+/147008 may not solve all problems, but without it things are hopeless.
Comment 6 Caolán McNamara 2023-02-14 13:20:10 UTC
*** Bug 127583 has been marked as a duplicate of this bug. ***
Comment 7 Commit Notification 2023-02-14 15:52:12 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/fd92b09db497a7dfd594a5418f87856dc3886bf9

tdf#153541 notify listeners when any of the icon sizes change

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2023-02-14 19:59:31 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ab07248af6fd7c6af631875cecb759ecf1ad1e7a

tdf#153541 NotebookBar not getting settings change notifications

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2023-02-14 20:00:34 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/0f5218d04b17c256dd04c99b1c2ed1d9e685856f

tdf#153541 update icons in notebookbar when theme changes

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Caolán McNamara 2023-02-14 20:29:53 UTC
looks decent to me in trunk, backports to 7-5 in gerrit
Comment 11 Commit Notification 2023-02-15 04:07:15 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/0287cf59e2f6a1f74e4df3ea580970465f996726

tdf#153541 notify listeners when any of the icon sizes change

It will be available in 7.5.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Commit Notification 2023-02-15 04:07:18 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/6b756ce38364b568c28f0eba48b90a1ae4676f24

tdf#153541 NotebookBar not getting settings change notifications

It will be available in 7.5.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 13 Stéphane Guillou (stragu) 2023-04-12 16:23:33 UTC
Linux issues were also fixed, see duplicate bug 127583.

Verified in:

Version: 7.5.2.2 (X86_64) / LibreOffice Community
Build ID: 53bb9681a964705cf672590721dbc85eb4d0c3a2
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR
Calc: threaded