Bug 127833 - Field shading in comments not properly refreshed
Summary: Field shading in comments not properly refreshed
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
4.4.0.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Writer-Comments
  Show dependency treegraph
 
Reported: 2019-09-28 08:00 UTC by Heiko Tietze
Modified: 2024-03-04 08:35 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot (19.48 KB, image/png)
2024-03-04 08:35 UTC, Heiko Tietze
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Heiko Tietze 2019-09-28 08:00:42 UTC
First issue: Enable field shading (ctrl+F8), add a comment and enter a hyperlink - it has a gray background. Save, close, reload - background is lost while it's still a hyperlink.

Second: After editing the link the highlight comes back, disable field shading - the background remains in the comment.
Comment 1 Dieter 2019-10-02 06:54:26 UTC
(In reply to Heiko Tietze from comment #0)
> First issue: Enable field shading (ctrl+F8), add a comment and enter a
> hyperlink - it has a gray background.

I get a gray background with

Version: 6.3.2.2 (x64)
Build-ID: 98b30e735bda24bc04ab42594c85f7fd8be07b9c
CPU-Threads: 4; BS: Windows 10.0; UI-Render: GL; VCL: win; 
Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE
Calc: threaded

but not with

Version: 6.4.0.0.alpha0+ (x64)
Build ID: 460908269972fd1f89312a1e62897ed1503e9e98
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2019-09-30_09:18:03
Locale: de-DE (de_DE); UI-Language: en-US
Calc: threaded
Comment 2 Xisco Faulí 2019-10-04 13:47:39 UTC
Hi Heiko,
Please, one issue at a time...

I can reproduce the first issue in

Version: 6.4.0.0.alpha0+
Build ID: c9336bfb6bbf6d73d3f23c124262ade30133448d
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

what is the regression keyword for? the first or the second issue ?

Could you please report the second issue in a follow-up issue ?
Comment 3 Telesto 2020-01-12 14:57:41 UTC
About the first issue

Repro with 4.4.0.1

No repro with
Version: 4.3.7.2
Build ID: 8a35821d8636a03b8bf4e15b48f59794652c68ba
Comment 4 Lukeoss 2020-02-13 05:31:22 UTC Comment hidden (spam)
Comment 5 Aadhya Mutti 2021-01-29 06:00:40 UTC Comment hidden (no-value)
Comment 6 raal 2021-07-10 06:42:50 UTC
(In reply to Heiko Tietze from comment #0)
> First issue: Enable field shading (ctrl+F8), add a comment and enter a
> hyperlink - it has a gray background. Save, close, reload - background is
> lost while it's still a hyperlink.
> 
bibisect-44max$ 612c411072ede9debf0ceafc3aef125b930b3762 is the first bad commit
commit 612c411072ede9debf0ceafc3aef125b930b3762
Author: Matthew Francis <mjay.francis@gmail.com>
Date:   Sat Mar 14 22:29:35 2015 +0800

    source-hash-3350fabd23859eb5fdbe77c6db9248866d4e2995
    
    commit 3350fabd23859eb5fdbe77c6db9248866d4e2995
    Author:     Miklos Vajna <vmiklos@collabora.co.uk>
    AuthorDate: Mon Jun 30 13:46:04 2014 +0200
    Commit:     Miklos Vajna <vmiklos@collabora.co.uk>
    CommitDate: Tue Jul 1 13:30:12 2014 +0200
    
        SwXAutoStyle::GetPropertyValues_Impl: fix handling of CharAutoStyleName
    
        Without this, all character properties defined inside automatic styles
        are ignored.
    
        Change-Id: I3c25f5d36503a9f40834dd88573a40c34380b967
Comment 7 Miklos Vajna 2021-07-12 07:43:16 UTC
My notes say that this was part of the work to bring feature/aoo-fillattribute into master, i.e. have gradient / hatching / etc support in Writer textframe backgrounds. I don't remember further details, so one option would be to see if the problem from the commit msg is still there after a local revert.
Comment 8 Justin L 2022-03-04 15:14:04 UTC
When I enter a hyperlink into Writer's text body, I don't get a field highlight. (This is true as far back as I can see in LO 3.5.) So why should we expect it in a comment?

Of course, comments are part of editEngine, while Writer generally is not. In Draw/Impress (which are editeng), while the text is in edit mode the hyperlink is highlighted, but not when the text doesn't have the focus.
Comment 9 Heiko Tietze 2022-03-04 15:16:54 UTC
(In reply to Justin L from comment #8)
> ... I don't get a field highlight.

Enable View > Field Shadings (ctrl+F8) first.
Comment 10 QA Administrators 2024-03-04 03:12:56 UTC Comment hidden (obsolete)
Comment 11 Heiko Tietze 2024-03-04 08:35:15 UTC
Created attachment 192935 [details]
Screenshot

Field shading is still always on in comments in 

Version: 24.2.0.3 (X86_64) / LibreOffice Community
Build ID: 420(Build:3)
CPU threads: 32; OS: Linux 6.7; UI render: default; VCL: kf5 (cairo+xcb)
Locale: en-IL (en_US.UTF-8); UI: en-US
24.2.0-2
Calc: threaded

(changing the application color from grey to yellow, for example, becomes effective after reloading the document or after changing the field)

I suspect sw/source/uibase/docvw/AnnotationWin2.cxx line #371 ff to cause the trouble.