Steps to reproduce: 1. Clean the user profile 2. Launch Writer 3. Click on 'new tip' button -> The dialog get resized
Regression introduced by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=3d85f485dee1c4e0c3a30f2e088fe34be69e1b06 author Heiko Tietze <heiko.tietze@documentfoundation.org> 2019-09-08 11:29:29 +0200 committer Heiko Tietze <heiko.tietze@documentfoundation.org> 2019-09-13 12:07:22 +0200 commit 3d85f485dee1c4e0c3a30f2e088fe34be69e1b06 (patch) tree b1328bf149d941107e7bdb7cfeadcca57fb19ede parent b59a67b4e3186660155038906ecb6d6fb11df834 (diff) Resolves tdf#127436 - Display issues of TotD on macOS Bisected with: bibisect-linux64-6.4 Adding Cc: to Heiko Tietze
Wouldn't call it a regression. The dialog has no defined width and I hesitate to set, let's say 200px, as this may not work in case of high resolution. The width is calculated based on the content which has a maximum width of 50 characters but is wrapped at word and therefore variable. My take: NAB.
Xisco, your opinion regarding NAB please.
(In reply to Heiko Tietze from comment #3) > Xisco, your opinion regarding NAB please. Sorry, I missed it. Well, at least it seems a regression from the user point of view. Before the commit mentioned, the dialog didn't get resized, the problem I see now is that the cursor is where the next button is, I click next, the dialog resizes and in the next tip, the cursor is where the close button is, thus if I click again, I close the dialog instead of going to the next tip, a bit annoying imho
https://gerrit.libreoffice.org/#/c/80887/
Heiko Tietze committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/dae96d4e629c5eccaacdc763cd390d341c16175d Resolves tdf#127994 - Totd dialog get resized horizontally It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
The dialog still gets resized in Version: 6.4.0.0.alpha1+ Build ID: 437dc68285dab0f08a1ded2193d86d64f560cd9b CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: threaded
(In reply to Xisco Faulí from comment #7) > The dialog still gets resized in If that happens it would be only in rare cases. Guess I cannot do much more without making it ugly.
@Caolán, is it something you could tweak a bit more ?
(In reply to Xisco Faulí from comment #4) > the problem I see now is > that the cursor is where the next button is, I click next, the dialog > resizes and in the next tip, the cursor is where the close button is, thus > if I click again, I close the dialog instead of going to the next tip, a bit > annoying imho I'm merely a user and not a developer, but if this is the main concern, instead of trying to keep the dialog width constant, wouldn't moving the mouse cursor onto the next button after the click and resizing an alternative solution?
(In reply to Ming Hua from comment #10) > wouldn't moving the mouse cursor onto the next button after the click... Bad usability when the cursor jumps around. You don't feel safe anymore when the application takes over control of your input devices. OTOH, resistance is futile :-)
(In reply to Heiko Tietze from comment #11) > (In reply to Ming Hua from comment #10) > > wouldn't moving the mouse cursor onto the next button after the click... > > Bad usability when the cursor jumps around. You don't feel safe anymore when > the application takes over control of your input devices. OTOH, resistance > is futile :-) Hmm... what about moving the button to directly under the cursor, then? ;-) I'm only half-joking, but I know it's easily said than done. Basicly I'm agreeing with Xisco that not being able to keeping clicking the next button is a bit inconvenient.
https://gerrit.libreoffice.org/#/c/81685/ may be acceptable to all I hope
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/517e093d78012896b54628d6a3092162be3cedec tdf#127994 stabilize tip of the day width It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Verified in Version: 6.4.0.0.alpha1+ Build ID: 2d0a4182712673d8f7a5abe919cd2a1d5ece4a77 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: threaded @Caolán, thanks for fixing this issue!!
Heiko Tietze committed a patch related to this issue. It has been pushed to "libreoffice-6-3": https://git.libreoffice.org/core/commit/f85473e0fbfbca0329559b0c6258e5ae603bfb34 Resolves tdf#127994 - Totd dialog get resized horizontally It will be available in 6.3.4. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.