Description: infinite loop in attribute search in writer Steps to Reproduce: 1. load attached hyphen.odt 2. select and copy first soft hyphen in para 1 3. edit, find & replace, paste hypen to search and click attributes, select hyphenation and click ok 4. click find next and then again Actual Results: 5. writer hangs Expected Results: no hang Reproducible: Always User Profile Reset: No Additional Info: git bisect on bibisect-linux-64-6.3 blames... commit 4caef398af256be5f0c2a159129b528ee3702e5c Author: Michael Stahl <Michael.Stahl@cib.de> Date: Thu Dec 13 15:49:10 2018 +0100 sw_redlinehide_4b: adapt FindAttrs() Iterate over merged nodes, and iterate over extents in them, so the complex attribute-finding logic doesn't need to be changed. Change-Id: Id72ca9247165a0c93f0cf2a38b7a0249771ca2eb
Created attachment 154990 [details] hyphen.odt
Michael Stahl committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/4e0241697371c40f4348bdfb6585a872d4cbcbf6 tdf#128138 sw_redlinehide: fix infinite loop in FindAttrsImpl() It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
fixed om master
Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-6-3": https://git.libreoffice.org/core/commit/46eedca34f6f421c2f2f8181b72a6073ad16efef tdf#128138 sw_redlinehide: fix infinite loop in FindAttrsImpl() It will be available in 6.3.4. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Verified in Version: 6.4.0.0.alpha0+ Build ID: e2d82611088677f8ec9f038639567f2d7c699b5e CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: threaded @Michael, thanks for fixing this issue!
Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-6-3-3": https://git.libreoffice.org/core/commit/9a5fd659873450a59309f71082a67fa9e74fcf47 tdf#128138 sw_redlinehide: fix infinite loop in FindAttrsImpl() It will be available in 6.3.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.