Bug 128227 - NAVIGATOR: Rename "Text Frame" to "Frame"
Summary: NAVIGATOR: Rename "Text Frame" to "Frame"
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Heiko Tietze
URL:
Whiteboard: target:6.4.0 target:6.5.0 target:6.4.0.1
Keywords: topicUI
Depends on:
Blocks: Navigator
  Show dependency treegraph
 
Reported: 2019-10-18 10:08 UTC by Dieter
Modified: 2021-01-31 09:21 UTC (History)
8 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dieter 2019-10-18 10:08:16 UTC
Steps to reproduce:

1. Open navigator
2. Entry "Text Frames" should be renamed to "Frames"

Reasoning
- More consistency: There is also Insert => Frame (and not "Text Frame") and the dialog is also named "Frame" (and not "Text Frame")
- Less confusion with Text Box: You find text boxes (Insert => Text Box) as Drawing Obect in the navigator. Unexperienced users could easly mix that up and expect text boxes as text frames in the navigator.
Comment 1 Roman Kuznetsov 2019-10-18 10:38:06 UTC
Agree.

Inserted Text box shows in Navigator as Drawing object
Comment 2 Dieter 2019-10-18 10:41:27 UTC
Jim, is this something for you?
Comment 3 V Stuart Foote 2019-10-18 13:10:39 UTC
In reply to Roman Kuznetsov from comment #1)
> Agree.
> 
> Inserted Text box shows in Navigator as Drawing object

Because it is a 'Draw Object' and should _not_ be confused with the content of _any_ frame.

What other content does the Navigator 'Text frames' hold, but frames that hold text?
Comment 4 Dieter 2019-10-18 13:49:42 UTC
(In reply to V Stuart Foote from comment #3)
> What other content does the Navigator 'Text frames' hold, but frames that
> hold text?

Help tells me:
"A text frame is a container for text and graphics that you can place anywhere on a page. You can also use a frame to apply a column layout to text.
To Insert a Text Frame: Select the text that you want to include in the frame. Choose Insert - Frame, and click OK." https://help.libreoffice.org/6.4/en-US/text/swriter/guide/text_frame.html?DbPAR=WRITER#bm_id3149487

So again "Frame" and "Text frame" are always mixed up. Should be more consistent.
Comment 5 V Stuart Foote 2019-10-18 15:24:51 UTC
(In reply to Dieter Praas from comment #4)
> 
> So again "Frame" and "Text frame" are always mixed up. Should be more
> consistent.

Every object on document canvas will have a frame, a 'Text frame' is specifically for managing text layout and can contain other objects. Images, shapes, OLE objects, tables inserted into a 'Text frame' will still be listed separately in Navigator. The 'Text frame' is the container, but its function is to control flow of textual content in the layout--objects other than text will flow in text along with their anchors.  Linking 'Text frames' is the way we layout the text on a page.

Maybe because I come from a Framemaker DTP background that just seems more natural handlig of 'Text frames'.

The 'frame' holding an image, holding a table, holding an OLE object, holding a Draw object (including a "Text box") is not exposed in Navigator.
Comment 6 Jim Raykowski 2019-10-18 23:09:33 UTC
(In reply to Dieter Praas from comment #2)
> Jim, is this something for you?

Hi Dieter, 

Here is where STR_CONTENT_TYPE_FRAME seen in the navigator content tree as "Text Frames" is defined:

https://opengrok.libreoffice.org/xref/core/sw/inc/strings.hrc?r=ed200d9f#355

I have no opinion of what the name for this should be.
Comment 7 Dieter 2019-10-20 05:31:28 UTC
(In reply to V Stuart Foote from comment #5)

> Every object on document canvas will have a frame, a 'Text frame' is
> specifically for managing text layout and can contain other objects. Images,
> shapes, OLE objects, tables inserted into a 'Text frame' will still be
> listed separately in Navigator. The 'Text frame' is the container, but its
> function is to control flow of textual content in the layout--objects other
> than text will flow in text along with their anchors.  Linking 'Text frames'
> is the way we layout the text on a page.

Thnks for clarification, but a normal user (just me) doesn't know that. I could see, that Insert => Frame => Frame Interactively / Frame inserts an entry into the navigator, while Insert => Frame => Floating Frame doesn't. So my idea won't be the best solution, but I still think, that the actual situation is al little confusing.
Comment 8 Thomas Lendo 2019-10-22 20:05:31 UTC
I've no preference, there are people with more insight in evolution of the wording in StarOffice, OpenOffice.org and LibreOffice in the last decades.

Adding Regina to have more input.

No matter what will be decided, not only the naming in Writer's Navigator should be considered but also the other applications and help files.
Comment 9 Regina Henschel 2019-10-22 21:29:34 UTC
I have no strong opinion about it.
From a technical point of view a "frame" is a umbrella term: "Frame Styles" cover images and OLE-objects too. In file format those are all written as <draw:frame> element, including the "Text Box", which is a "Drawing Object" in LibreOffice. From a user point of view, "Frame" in the Navigator is better, because it corresponds to the Insert menu.

These inconsistency is there since the start in ODF 1.

Another aspect to consider is, that each change in the UI will produce a lot of work for translation and documentation.
Comment 10 Cor Nouws 2019-10-23 17:57:57 UTC
(In reply to Regina Henschel from comment #9)

> Another aspect to consider is, that each change in the UI will produce a lot
> of work for translation and documentation.
indeed...
Comment 11 Heiko Tietze 2019-10-24 09:02:12 UTC
We discussed the topic in the design meeting and agree on the change. Documentation should take this into account.
Comment 12 Commit Notification 2019-10-24 10:23:10 UTC
Heiko Tietze committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1721836fb2e94b8478b80139976617f9e7311816

Resolves tdf#128227 - Rename "Text Frame" to "Frame

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 13 Commit Notification 2019-11-18 23:37:33 UTC
Olivier Hallot committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/e20b575c56ebe912501e932192e509b6a227ce3c

tdf#128227 disambiguate text frame and text box
Comment 14 Commit Notification 2019-11-22 10:38:26 UTC
Olivier Hallot committed a patch related to this issue.
It has been pushed to "libreoffice-6-4":

https://git.libreoffice.org/help/commit/dddd28a6173bf590d8b4ea8ca886c0a732e50551

tdf#128227 disambiguate text frame and text box
Comment 15 Dieter 2019-12-04 21:08:25 UTC
Verified with

Version: 6.5.0.0.alpha0+ (x64)
Build ID: 89f0af144c18efafe2573801641689a1432c0cae
CPU threads: 4; OS: Windows 10.0 Build 18362; UI render: GL; VCL: win; 
Locale: de-DE (de_DE); UI-Language: en-GB
Calc: threaded

Olivier, thanks for fixing it!