Bug 128288 - MacOS LO language pack installer window can have wrong background image
Summary: MacOS LO language pack installer window can have wrong background image
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Installation (show other bugs)
Version:
(earliest affected)
6.4.0.0.alpha1+
Hardware: x86-64 (AMD64) macOS (All)
: medium minor
Assignee: Stephan Bergmann
URL:
Whiteboard: target:6.4.0
Keywords: bibisectRequest, regression
Depends on:
Blocks:
 
Reported: 2019-10-21 09:33 UTC by Andrew Watson
Modified: 2019-11-13 22:55 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
en-GB language pack installer with INCORRECT background (87.85 KB, image/png)
2019-10-21 09:37 UTC, Andrew Watson
Details
en-GB language pack installer with CORRECT background (55.29 KB, image/png)
2019-10-21 09:38 UTC, Andrew Watson
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Watson 2019-10-21 09:33:45 UTC
Description:
MacOS en-GB language pack installer window for LO 6.4 Alpha1 incorrectly has the same background image as MacOS LO 6.4 installer window, but only when the LO 6.4 Alpha1 installer DMG is mounted.

Steps to Reproduce:
1. Download LO 6.4 Alpha1 MacOS installer DMG and en-GB language pack installer DMG from pre-release server (https://dev-builds.libreoffice.org/pre-releases/mac/x86_64/).
2. Double-click on LO 6.4 DMG and install LO 6.4 in usual way.
3. With LO 6.4 installer DMG still mounted, double-click on en-GB language pack installer DMG to mount it.
4. Observe that language pack installer window that opens incorrectly has the same background image as LO 6.4 installer.
5. Eject both LO 6.4 installer and en-GB language pack installer DMGs by clicking on eject symbol next to them in any finder window.
6. Re-mount just the en-GB language pack by double-clicking on its DMG.
7. Observe that the language pack installer window that opens now correctly has the a blank background image.


Actual Results:
Language pack installer window incorrectly has the same background image as LO 6.4 installer.


Expected Results:
Language pack installer window should have blank background image.


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.4.0.0.alpha1
Build ID: cc57df8f942f239d29cb575ea5a7cb01405db787
CPU threads: 4; OS: Mac OS X 10.11.6; UI render: default; VCL: osx; 
Locale: en-GB (en_GB.UTF-8); UI-Language: en-US
Calc: threaded
Comment 1 Andrew Watson 2019-10-21 09:37:55 UTC
Created attachment 155183 [details]
en-GB language pack installer with INCORRECT background
Comment 2 Andrew Watson 2019-10-21 09:38:54 UTC
Created attachment 155184 [details]
en-GB language pack installer with CORRECT background
Comment 3 Alex Thurgood 2019-10-24 07:56:43 UTC
Downloaded 6.4 alpha and GB langpack.
Opened App installer DMG first
Then Opened langpack installer DMG

The langpack bundle DMG shows the same background image as the main installer DMG.
Confirming.
Comment 4 Xisco Faulí 2019-11-05 15:27:49 UTC
Hi Stephan,
I thought you might be interested in this issue, since you fixed bug 122244
Comment 5 Stephan Bergmann 2019-11-05 15:57:28 UTC
Looks like the .DS_Store in <https://dev-builds.libreoffice.org/pre-releases/mac/x86_64/LibreOfficeDev_6.4.0.0.alpha1_MacOS_x86-64_langpack_en-GB.dmg> is setup_native/source/packinfo/DS_Store_Dev rather than setup_native/source/packinfo/DS_Store_Langpack.  Must be a problem with ScpAction scp_Copy_Ds_Store in scp2/source/ooo/scpaction_ooo.scp.
Comment 6 Stephan Bergmann 2019-11-05 20:15:03 UTC
Has probably been broken ever since <https://gerrit.libreoffice.org/plugins/gitiles/core/+/dab79744767c05fd5268866937e225b74e658cea^!> "Give Mac master builds a nice background .dmg image, too" in 2011.  Should get fixed with <https://gerrit.libreoffice.org/#/c/82107/> "tdf#128288: Use DS_Store_Langpack even for --disable-release-build".
Comment 7 Commit Notification 2019-11-05 21:05:42 UTC
Stephan Bergmann committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ba7a76f8122cf2903a943218a0c954181bf6f4d0

tdf#128288: Use DS_Store_Langpack even for --disable-release-build

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Andrew Watson 2019-11-13 22:55:23 UTC
> The patch should be included in the daily builds available at
> https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
> information about daily builds can be found at:
> https://wiki.documentfoundation.org/Testing_Daily_Builds
> 
> Affected users are encouraged to test the fix and report feedback.

Tested with this daily build of LO and the en-GB language pack:

Version: 6.4.0.0.alpha1+
Build ID: e3b75f6c275b0f43806cef02414b0b76f2e443d0
CPU threads: 4; OS: Mac OS X 10.11.6; UI render: default; VCL: osx; 
Locale: en-GB (en_GB.UTF-8); UI-Language: en-US
Calc: threaded

Bug does indeed appear to be fixed - many thanks.