Bug 128494 - Grammar checking implementation not made clear
Summary: Grammar checking implementation not made clear
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Documentation (show other bugs)
Version:
(earliest affected)
6.3.2.2 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.0.0
Keywords:
Depends on:
Blocks: Spell-Checking 87648
  Show dependency treegraph
 
Reported: 2019-10-31 10:20 UTC by Alex
Modified: 2020-03-19 15:25 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alex 2019-10-31 10:20:36 UTC
Description:
Despite having activated all the required options:
- Tools > Automatic Spell Checking
- Tools > Options... > Language Settings > Writing Aids > Check grammar as you type
I cannot get grammar to be checked.

Also, in the menu Tools, there is only an entry "Spelling... (F7)" whereas in the latest PDF documentation for Writer (only available for the earlier LO 6.0 version - see: https://documentation.libreoffice.org/en/english-documentation) it is supposed to be "Spelling and Grammar". However, when I click on Tools > Spelling... *while have the cursor in the middle of the document* the Spelling dialog opens with a message "Continue checking at the beginning of document?" under which one can see in the Checking dialog a "Check grammar" option unchecked (hinting at the fact that it should also be possible to check the grammar) but this option disappears once one closes the message.

On the other hand, in the interactive Help > LibreOffice Help (F1), it says: "Grammar checkers can be downloaded and installed as extensions. See the extensions web page.", with a link to https://extensions.libreoffice.org/extension-center?getCategories=Dictionary.

All this is quite confusing...
Is there a grammar checking function implemented in LO which relies on some grammar rules that would come as an addition in the same way as the spelling checker relies on added dictionaries? In which case all the above options that can be activated or inactivated make sens, but in the site extensions.libreoffice.org one can only find external services such as LanguageTool or Scriben relying on an online connection and data transfer.

What addition/extension did the grammar checking function of LO 6.0 rely on? And what happened to it? 

If the grammar checking only relies on external tools/services served as extensions, wouldn't it be clearer to rephrase those grammar-related options to be more explicit that they just enable/disable some grammar-services extensions (for example, replacing "Check grammar as you type" by "Enable grammar checking extension"), and to have those options greyed out when the user hasn't yet installed such extensions?

Steps to Reproduce:
General situation:
1. Open a document containing some grammar errors
2. Activate automatic spell checking (Tools > Automatic Spell Checking)
3. Activate grammar checking (Tools > Options... > Language Settings > Writing Aids > Check grammar as you type)
Regarding the 'hidden' "Check grammar" option:
1. Open a document
2. Required: place the cursor on a new line after some initial text.
3. Open the Spelling dialog (Tools > Spelling... (F7)

Actual Results:
No grammar checking is performed.
A "Check grammar" option is temporarily displayed in the Spelling dialog.


Expected Results:
One of the others:
- Grammar checking should be performed
- The options should explicitly refer to an extension to be installed and that is made enabled/disabled and the options should be greyed out 


Reproducible: Always


User Profile Reset: No



Additional Info:
[Information automatically included from LibreOffice]
Locale: en-US
Module: TextDocument
[Information guessed from browser]
OS: Linux (All)
OS is 64bit: yes
[LibreOffice install]
Version: 6.3.2.2
Build ID: 1:6.3.2-0ubuntu0.18.04.1~lo1
CPU threads: 8; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: en-US (fr_FR.UTF-8); UI-Language: en-US
Calc: threaded
Comment 1 Alex 2019-10-31 10:24:35 UTC
* I mean: "and the option should be greyed out *if no such extension has been installed yet*"
Comment 2 Dieter 2019-11-03 17:51:36 UTC
I have installed Language tool. Grammar checking is working,

Regading to [1] the dialog should now be called Spelling and Grammar. In fact it is still called "Spelling". There is no hint in Tools Menu, that grammar check is available. I agree, that this should be improved

=> Status NEW
cc: Desing-Team for further input

[1] https://help.libreoffice.org/6.3/en-US/text/shared/01/06010000.html?&DbPAR=WRITER&System=WIN
Comment 3 Heiko Tietze 2019-11-04 08:47:41 UTC
(In reply to Dieter Praas from comment #2)
> I have installed Language tool. Grammar checking is working,

Doubt we can and should name dialogs depending on 3rd party extensions. And I don't see a big issue with "Spelling". Anyway, the decision was made in bug 87648 to name it accordingly => WF (keeping the ticket open for QA decision).
Comment 4 Dieter 2019-11-04 08:54:36 UTC
(In reply to Heiko Tietze from comment #3)
> Doubt we can and should name dialogs depending on 3rd party extensions. And
> I don't see a big issue with "Spelling". Anyway, the decision was made in
> bug 87648 to name it accordingly => WF (keeping the ticket open for QA
> decision).

Thank you for that information. But then informations in help are wrong and should be adapted.

cc: Olivier Haillot
Comment 5 Xisco Faulí 2019-11-05 10:58:08 UTC
Changing it to Documentation then
Comment 6 Buovjaga 2020-03-06 06:43:46 UTC
(In reply to Dieter from comment #2)
> I have installed Language tool. Grammar checking is working,
> 
> Regading to [1] the dialog should now be called Spelling and Grammar. In
> fact it is still called "Spelling". There is no hint in Tools Menu, that
> grammar check is available. I agree, that this should be improved
> 
> => Status NEW
> cc: Desing-Team for further input
> 
> [1]
> https://help.libreoffice.org/6.3/en-US/text/shared/01/06010000.
> html?&DbPAR=WRITER&System=WIN

I have a patch for this at https://gerrit.libreoffice.org/c/help/+/90060

If you don't think it is enough, please tell me exactly what to do.
Comment 7 Dieter 2020-03-06 07:51:50 UTC
(In reply to Buovjaga from comment #6)
> I have a patch for this at https://gerrit.libreoffice.org/c/help/+/90060

Thnaks for your work, but I don't know what to do now. Will it become part of master? But actually there is no actual master for windows available (Do you know why?)
Comment 8 Buovjaga 2020-03-06 08:07:46 UTC
(In reply to Dieter from comment #7)
> (In reply to Buovjaga from comment #6)
> > I have a patch for this at https://gerrit.libreoffice.org/c/help/+/90060
> 
> Thnaks for your work, but I don't know what to do now. Will it become part
> of master? But actually there is no actual master for windows available (Do
> you know why?)

In the gerrit patch, click the links to the files I modified like
source/text/shared/01/06010000.xhp

You will see a diff view of my changes. In the upper right corner you can switch to a unified diff view, if it is easier to read (as is often the case).
Comment 9 Dieter 2020-03-06 09:03:16 UTC
My main point was, that the informtaion "If a grammar checking extension is installed, this dialog is called Spelling and Grammar" should be removed, because the dialog is always named "Spelling" (see comment 3). As far as I could see, you did this, so for me your changes are enough. Thanks.
Comment 10 Commit Notification 2020-03-12 17:10:41 UTC
Ilmari Lauhakangas committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/42797a6bc9f90ab9bfa4818bc1344f52125d2afa

tdf#128494 Change Spellcheck to Spelling
Comment 11 Dieter 2020-03-19 15:25:07 UTC
Verified fixed with

Version: 7.0.0.0.alpha0+ (x64)
Build ID: 5dcbd1bb557450a2d658a710c163b310c0cee157
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win; 
Locale: de-DE (de_DE); UI-Language: en-GB
Calc: CL