Description: A user named Carla Rossetti over the Facebook group "KDE Neon Users" modified Breeze SVG and Sifr SVG to create correspondent dark versions for their own use (because the non-SVG version wouldn't look correct under 4K resolution). They are okay with it being upstreamed to LibreOffice. Please take a look: https://github.com/primuladimaggio/libreoffice-dark-icons-svg Actual Results: Expected Results: Reproducible: Always User Profile Reset: No Additional Info:
Rizal, Andreas?
Thank you for your information. This request used to came to my mind sometimes and this report confirm that actually user does need it. Would you mind if I ask the script to create the Breeze & Sifr SVG dark variant? We are very welcome if people want to give more hands also :)
Here is precisely what Carla said. "Hi, Thiago Sueto. It's, simple. Unpack the light icon archives. On terminal I used two commands : #For sifr_dark find . -type f -name "*.svg" -exec sed -i'' -e 's/#555753/#eff0f1/g' {} + #For breeze_dark find . -type f -name "*.svg" -exec sed -i'' -e 's/#232629/#eff0f1/g' {} + Pack and rename."
Is anyone in charge of this? Can I have a look?
I uploaded a patch to include the new set (https://gerrit.libreoffice.org/c/core/+/86590). I created it using the bash line provided, but I had to fix some manually cause the dark fill color was actually black.
(In reply to Luca Carlon from comment #5) > I uploaded a patch to include the new set > (https://gerrit.libreoffice.org/c/core/+/86590). I created it using the bash > line provided, but I had to fix some manually cause the dark fill color was > actually black. https://gerrit.libreoffice.org/c/core/+/86581 Sorry for being late to response. I have send a patch also and especially for Breeze I have already a script in my Github repo to change the color which based on official KDE VDG color choice. So, not following Comment 3 here. https://github.com/rizmut/libreoffice-style-breeze/blob/master/build.sh For Sifr, the script was created against PNG version which is basically negating the bitmap I should find exact color code for this so the patch has not available yet.
I'm sorry, but I downloaded your patch and it is almost identical to mine, except it arrived much afterwards. I don't see a different color, I see the fill is #eff0f1. I'm using breeze dark on my KDE desktop, and I see the color is #eff0f1. What is the reason for another patch instead of reviewing mine that I uploaded first?
Sorry, I see your first patch arrived first but you just didn't reference it here. However I see your patch has not satisfied jenkins. Mine passed jenkins.
(In reply to Luca Carlon from comment #7) > I'm sorry, but I downloaded your patch and it is almost identical to mine, > except it arrived much afterwards. I don't see a different color, I see the > fill is #eff0f1. I'm using breeze dark on my KDE desktop, and I see the > color is #eff0f1. What is the reason for another patch instead of reviewing > mine that I uploaded first? We are not in a competition here, I just want to make sure that we have same color code here. So for Breeze version, I will follow yours. Will comment on you patch afterward
*** Bug 129946 has been marked as a duplicate of this bug. ***
Luca Carlon committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/00f742cace19a8d13550eeb242a4e18bce571645 tdf#128849: Added svg version of the breeze dark icon set. It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
rizmut committed a patch related to this issue. It has been pushed to "libreoffice-6-4": https://git.libreoffice.org/core/commit/54368ea4b13bfb1437459d3a3b5bc009d263079b Breeze & Sifr: tdf#128849 & Sifr: tdf#129846 It will be available in 6.4.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
rizmut committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/482bb2085cecdd9861ba6c48098bbfe0ab2adf8c Sifr: Added SVG version of the Sifr Dark icon set (tdf#128849). It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
rizmut committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/4617a5b7ded7f5d0c67087d204e05a991a50ee41 tdf#128849 -- Add Sifr (Dark + SVG) to the icon theme list It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
rizmut committed a patch related to this issue. It has been pushed to "libreoffice-6-4": https://git.libreoffice.org/core/commit/0273fa1e6d4a724a7d2bad062c142970038bec38 tdf#128849 -- Add Sifr (Dark + SVG) to the icon theme list It will be available in 6.4.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.