Bug 128892 - Same shortcut character/letter assigned to 2 Functions under SHEETS menu item
Summary: Same shortcut character/letter assigned to 2 Functions under SHEETS menu item
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
6.3.3.2 release
Hardware: All Linux (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:6.5.0 target:6.4.0.1
Keywords:
Depends on:
Blocks: Shortcuts-Accelerators
  Show dependency treegraph
 
Reported: 2019-11-19 10:15 UTC by Bijal
Modified: 2022-12-20 08:32 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bijal 2019-11-19 10:15:16 UTC
Description:
In Libre Calc the combination of ALT+S opens the SHEETS menu drop down. the character R is used to open/select both Insert Rows (further sub-menu) and also Rename Sheet

so by clicking R it goes to Rename Sheet and there is no way to open the sub menu of Insert Rows

Steps to Reproduce:
1. Open new or existing Calc Spreadsheet
2. Click Alt+S to open the Sheets menu
3. The letter R is assigned to 2 functions namely Insert Rows and Rename Sheet

Actual Results:
Clicking the letter R highlights the Rename Sheet function

Expected Results:
Highlight Insert Rows sub-menu item


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.3.3.2
Build ID: a64200df03143b798afd1ec74a12ab50359878ed
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: en-IN (en_IN); UI-Language: en-US
Calc: threaded

LibreOffice is a modern, easy-to-use, open source productivity suite for word processing, spreadsheets, presentations and more.

See Log: a64200df03143b798afd1ec74a12ab50359878ed

This release was supplied by The Document Foundation.
Copyright © 2000–2019 LibreOffice contributors.
LibreOffice was based on OpenOffice.org.
Comment 1 Xavier Van Wijmeersch 2019-11-19 17:40:58 UTC
confirm with

Version: 6.3.3.2
Build ID: a64200df03143b798afd1ec74a12ab50359878ed
CPU threads: 8; OS: Linux 4.19; UI render: default; VCL: gtk3; 
Locale: nl-BE (en_US.UTF-8); UI-Language: en-US
Calc: threaded

The letter R is assigned to 2 functions namely Insert Rows and Rename Sheet also with

Version: 6.5.0.0.alpha0+
Build ID: 335852ffcf72e2ef6c4b02ebe645492bb7bc36d3
CPU threads: 8; OS: Linux 4.19; UI render: default; VCL: gtk3; 
Locale: nl-BE (en_US.UTF-8); UI-Language: en-US
Calc: threaded

but clicking the letter R now highlights the insert rows
Comment 2 Xisco Faulí 2019-11-21 12:06:17 UTC
I see the same problem for the E

Takeshi submitted a patch to gerrit: https://gerrit.libreoffice.org/#/c/83368/
Comment 3 Commit Notification 2019-11-22 15:05:34 UTC
Takeshi Abe committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/017c6150e94a3a621f6f3e789fe72cac90a7bf11

tdf#128892 Give menu "Rename Sheet" an alternative mnemonic H

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2019-11-23 07:59:11 UTC
Takeshi Abe committed a patch related to this issue.
It has been pushed to "libreoffice-6-4":

https://git.libreoffice.org/core/commit/e9b1955b0d85409686666a3796166ddf3694335d

tdf#128892 Give menu "Rename Sheet" an alternative mnemonic H

It will be available in 6.4.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Xisco Faulí 2020-01-20 14:31:07 UTC
(In reply to Xisco Faulí from comment #2)
> I see the same problem for the E
> 
> Takeshi submitted a patch to gerrit:
> https://gerrit.libreoffice.org/#/c/83368/

Still reproducible in

Version: 6.5.0.0.alpha0+
Build ID: fc1f85127968d1c2e0a53dace51bf8a78f9e6ca5
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded

@Takeshi, would you like to fix it as well ?
Comment 6 Takeshi Abe 2020-01-22 09:19:57 UTC
(In reply to Xisco Faulí from comment #5)
> @Takeshi, would you like to fix it as well ?

Xisco,

Not only E (for menu "Delete Cells" / "Sheet Events..."), but also each of B ("Insert Page Break" / "Delete Page Break"), C ("Insert Cells" / "Cell Comments"), I ("Fill Cells" / "Right-To-Left"), S ("Insert Sheet..." / "Show Sheet..."), and T ("Insert Sheet from File..." / "Sheet Tab Color...") has been shared with 2 menu items.
To me the E (or T) case looks tolerable because repeat typing of E (or T) switches the focus.
Do you think it would be nice to fix all of them by assigning a unique access key to each item in the above?
Comment 7 QA Administrators 2022-08-28 03:34:12 UTC Comment hidden (obsolete)
Comment 8 stevebell001 2022-10-09 12:22:10 UTC
I have upgraded to 3c58a8f Version 7.4.1.2, tag libreoffice-7.4.1.2 (64) 
recently and my shortcut for delete cells now triggers insert cells dialogue.

So basically Alt/S W no longer works and the highlighted "r" is the trigger for both insert and delete rows! so there is effectively no shortcut to delete rows.

Looking at his bug, it all looks related as the allocations seem random and multiple at the same time!