Description: Issue is a follow up from tdf#125508: Black frame lines around rotation wheel within Position and Size / Ratation dialog may not be intended (see screenshot attached) Steps to Reproduce: 1. Open LO Impress 2. Draw an arbitrary object 2. Open Position and Size / Rotation dialog Actual Results: Black frame lines are drawn around rotation wheel. Expected Results: Rotation wheel is drawn without frame. Reproducible: Always User Profile Reset: No OpenGL enabled: Yes Additional Info:
Created attachment 156016 [details] Screenshot
Moving to NEW
To remove frame around rotation wheel shadow had to be disabled for enclosing GtkViewPort and GtkScrolledWindow objects. This was done using Glade. On Linux result is as expected, on macOS frame is not removed. To remove frame on macOS too, GtkScrolledWindow was removed too. Result looks as expected on macOS too (see screenshot attached). @ Caolan: Could you please doublecheck whether this is the right approach (modified Glade output is attached too). As there is no change within C++ code, GTKScrolledWindow is addressed there furthermore although it has been removed within the XML UI description file: m_xCtrlDial(new DialControl(m_xBuilder->weld_scrolled_window("anglepreview")))
Created attachment 157346 [details] Screenshot with patch
Created attachment 157347 [details] Patch
(In reply to Thorsten Wagner from comment #5) > Created attachment 157347 [details] > Patch Hi Thosten, Could you please submit the patch to gerrit for review ? See https://wiki.documentfoundation.org/Development/gerrit/SubmitPatch
Thorsten, if you made the patch why not submit to Gerrit [1]? Looking forward to review it there. [1] https://wiki.documentfoundation.org/Development/gerrit
caolan->thorsten: remove the ViewPort as well as the ScrolledWindow, the ViewPort is just an adaptor to put things into a ScrolledWindow so if the ScrolledWindow goes, it should go as well Ideally in the c++ m_xCtrlDial(new DialControl(m_xBuilder->weld_scrolled_window("anglepreview"))) changes to m_xCtrlDial(new DialControl(nullptr)) but it will work, as you've already seen, without the change because m_xBuilder->weld_scrolled_window(I_DONT_EXIST) returns null anyway after a little wasted work trying to find it
(In reply to Caolán McNamara from comment #8) > caolan->thorsten: remove the ViewPort as well as the ScrolledWindow, the > ViewPort is just an adaptor to put things into a ScrolledWindow so if the > ScrolledWindow goes, it should go as well > > Ideally in the c++ > m_xCtrlDial(new > DialControl(m_xBuilder->weld_scrolled_window("anglepreview"))) > changes to > m_xCtrlDial(new DialControl(nullptr)) > but it will work, as you've already seen, without the change because > m_xBuilder->weld_scrolled_window(I_DONT_EXIST) > returns null anyway after a little wasted work trying to find it Thank you for checking. Removing GtkViewPort using Glade's "Remove Parent" function causes the removal of enclosed object by Glade as well. Although this is not visible directly, it happens after saving/reloading UI file with Glade. Does the UI file has to be edited directly?
(In reply to Thorsten Wagner from comment #9) > Removing GtkViewPort using Glade's "Remove Parent" function causes the removal > of enclosed object by Glade as well. Maybe copy/paste work.
Yeah, cut and paste would do the trick. I've uploaded the patch with the extra viewport removed as https://gerrit.libreoffice.org/c/core/+/87348
Thorsten Wagner committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/4623b903e16c379a56c63c31ba84cf447bcfe7f9 tdf#128942 Remove frame around rotation wheel within Position and Size dialog It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/2f4dda0a26fba2555641debdc84ec2ece1433ec6 Related: tdf#128942 remove the scrolledwindow frames from all the dialcontrols It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.