Black frame lines are drawn around several dialog widgets (see screenshot for an example). This does not seem to be intended.
Steps to Reproduce:
(1) Open Writer
(2) Insert a table
(3) Select Table Properties / Borders
Black frames are drawn around several widgets (see screenshot).
No frames are drawn around any widgets.
User Profile Reset: No
OpenGL enabled: Yes
Created attachment 151685 [details]
Thank you for reporting the bug.
Could you please try to reproduce it with a master build from http://dev-builds.libreoffice.org/daily/master/ ?
You can install it alongside the standard version.
I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' if the bug is still present in the master build
Issue is still present with build from current master:
Build ID: 79d58ee14da8fbf636fb087453834abb7173d3fc
CPU threads: 8; OS: Mac OS X 10.14.5; UI render: GL; VCL: osx;
Locale: de-DE (en_US.UTF-8); UI-Language: en-US
I don't see any difference in 6.2, 6.3 and 6.4 on Windows.
It looks like the screenshot of Thorsten.
Heiko, do you know that something was changed in the UI in the last main releases?
Created attachment 154944 [details]
Screenshot from LO 5.4.7
Please find a screenshot from LO 5.4.7 attached to compare
If you talk about tables, the border is around cells. Without border you don't see any table structure, which is likely not the general case. The recommended workflow is using a table style without borders.
Where else would you remove the borders?
I am not talking about tables but dialog widgets. The Table Properties / Borders dialog is only an example for a dialog box to show the issue.
Looking at the first screenshot, there are thin gray lines around the widgets below "Presets", "User-defined", and "Position" labels. These thin lines were introduced sometimes during the LO 6 releases and are not present in LO 5 (see second screenshot).
[Automated Action] NeedInfo-To-Unconfirmed
(In reply to Thorsten Wagner from comment #8)
> Looking at the first screenshot, there are thin gray lines...
Got it, sorry for being slow. But I wonder if this border is part of your theme as we haven't changed anything here. And my Breeze theme on KDE doesn't show a border. Caolan, what do you think?
In the .uis those rectangular borders are GtkScrolledWindow parents for those widgets. (In this case cui/uiconfig/ui/borderpage.ui). The GtkScrolledWindows have two purposes, the obvious one of enabling scrolling of widgets, and to provide a border around widgets.
Under Mac/Windows that will be implemented with VclScrolledWindow which will Paint the border with DecorationView::DrawFrame which will attempt to use the system theming to draw it (I think) in that complicated ImplDrawFrame.
I think the middle "User Defined" element actually always had a border, through probably drawn with some different border-drawing system (classic WB_BORDER) in the past, while the other two gained border frames along the way.
I have no strong feelings on whether they should have borders or not, I think they gained a border because they are SvtValueSets which are in general scrollable, though that's optional.
If we wanted to remove the border around presets and shadows valuesets then https://gerrit.libreoffice.org/#/c/80883/ would do that
Let's submit Caolan's patch and see if it has drawbacks.
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":
tdf#125508 remove border frame from shadows and presets
It will be available in 6.4.0.
The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
Affected users are encouraged to test the fix and report feedback.
Unfortunately issue is not fixed for all widgets. The widget below "User-defined" has the thin gray line furthermore. This widget is used in other dialogs too, for example for text orientation in Calc's Format / Cells / Alignment dialog.
You're making this into an open ended bug with probably no end in sight.
(In reply to Thorsten Wagner from comment #14)
> The widget below "User-defined" has the thin gray line furthermore.
This frame looks good to me and it makes sense as it separates the widget content from the canvas. How the frame is drawn depends of course on the theme; it's a light gray in my case.
I would close this bug as FIXED and open individual tickets for all places where the frame is potentially obsolete.
(In reply to Heiko Tietze from comment #16)
> I would close this bug as FIXED and open individual tickets for all places
> where the frame is potentially obsolete.
Indeed. Better to debate each case separately.