Bug 128943 - Remove frames around rotation wheel and reference edge widget within Format / Cells / Alignment dialog
Summary: Remove frames around rotation wheel and reference edge widget within Format /...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.0.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Thorsten Wagner
URL:
Whiteboard: target:7.0.0
Keywords: difficultyBeginner, easyHack, topicUI
Depends on:
Blocks:
 
Reported: 2019-11-22 00:00 UTC by Thorsten Wagner
Modified: 2020-03-05 11:27 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot (65.13 KB, image/png)
2019-11-22 00:01 UTC, Thorsten Wagner
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Thorsten Wagner 2019-11-22 00:00:52 UTC
Description:
Issue is a follow up from tdf#125508: Black frame lines around rotation wheel and reference edge widget within Format / Cells / Alignment dialog may not be intended (see screenshot attached)

Steps to Reproduce:
1. Open LO Calc
2. Open Format / Cells / Alignment dialog

Actual Results:
Black frame lines are drawn around rotation wheel as well as around reference edge widget.

Expected Results:
Rotation wheel and reference edge widget are drawn without frames.


Reproducible: Always


User Profile Reset: No


OpenGL enabled: Yes

Additional Info:
Comment 1 Thorsten Wagner 2019-11-22 00:01:26 UTC
Created attachment 156017 [details]
Screenshot
Comment 2 Thorsten Wagner 2019-11-28 14:04:45 UTC
Further discussion: Is rotation wheel needed at all as it is possible to select rotation angle by dropdown box too? Rendering quality of rotation wheel is poor, wheel looks pixelated.
Comment 3 Xisco Faulí 2019-12-11 14:13:55 UTC
Moving to new
Comment 4 Xisco Faulí 2019-12-11 14:14:58 UTC
@Heiko, I believe this could be turned into an easyhack
Comment 5 Heiko Tietze 2019-12-11 14:56:14 UTC
See https://gerrit.libreoffice.org/plugins/gitiles/core/+diff/da50f3e15e38474a51361bdddbc0951dec5674bf%5E%21 and dicussion in bug 125508 for how to solve the problem.
Comment 6 Thorsten Wagner 2020-01-25 20:30:11 UTC
@ Caolan
Comment 7 Thorsten Wagner 2020-01-25 20:34:47 UTC
(In reply to Thorsten Wagner from comment #6)
> @ Caolan: Thank you for fixing rotation wheels. I will submit an additional patch in short to fix reference edge boxes as in tdf#125508 to close this issue too.
Comment 8 Thorsten Wagner 2020-01-25 21:27:21 UTC
Patch submitted to Gerrit:

https://gerrit.libreoffice.org/c/core/+/87422
Comment 9 Thorsten Wagner 2020-03-04 16:06:57 UTC
Is anyone able to review the submitted patch?

Pootle bot has posted comments on this change. ( https://gerrit.libreoffice.org/c/core/+/87422 )

Change subject: tdf#128943: Remove frame around reference edge widget
......................................................................

Patch Set 2:

A polite ping, still working on this patch?
Comment 10 Commit Notification 2020-03-05 11:27:25 UTC
Thorsten Wagner committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/d264170ebbc92f8a920cd51d7f6f2744aa465be1

tdf#128943: Remove frame around reference edge widget

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.