Impress Presentation console is in Lo from 3.3. It had some small improvements like adding Restart button. Here is a request for an enhancement to add two more buttons: pause/resume and exit buttons. They are all handy if presentation is interrupted or for rehearsal or test. So I set Low.
Actually, there's bug 90978 for Exit, let this one be for pause/resume.
Whoever hopefully confirms this, please try to find where Restart was added. Could be a nice code pointer.
Restart timer was added with this commit: https://cgit.freedesktop.org/libreoffice/core/commit/?id=b1a6a99b9a78689c6d3649ce066fad66912188e2 This is an easy hack. Implement this feature according to the patch above. Icons can be provided by the design team afterwards. Just use one of the existing icons for now.
I would like to attempt this.
Submitted a patch for this. https://gerrit.libreoffice.org/c/core/+/95955 Marked as WIP as logo is needed.
(In reply to Srijan Bhatia from comment #5) > Marked as WIP as logo is needed. What exactly is missing, do you mean icon(s) for UNO command(s)?
Created attachment 161830 [details] Pause/Resume button in presenter console
(In reply to Heiko Tietze from comment #6) > What exactly is missing, do you mean icon(s) for UNO command(s)? Yes the icon for the button is required as you can see in the attachment.
Rizal, apparently these two icons are missing https://gerrit.libreoffice.org/c/core/+/95955/2/officecfg/registry/data/org/openoffice/Office/PresenterScreen.xcu <value>bitmaps/ButtonRestartTimerNormal.png</value> <value>bitmaps/ButtonRestartTimerMouseOver.png</value>
(In reply to Heiko Tietze from comment #9) > Rizal, apparently these two icons are missing > > https://gerrit.libreoffice.org/c/core/+/95955/2/officecfg/registry/data/org/ > openoffice/Office/PresenterScreen.xcu > > <value>bitmaps/ButtonRestartTimerNormal.png</value> > <value>bitmaps/ButtonRestartTimerMouseOver.png</value> Copy that, roger.
Ideally we have two variants: 1. Pause: presenterscreen-ButtonPauseTimerNormal.png & presenterscreen-ButtonPauseTimerMouseOver.png 2. Resume: presenterscreen-ButtonResumeTimerNormal.png & presenterscreen-ButtonResumeTimerMouseOver.png It will weird if we just utilizing only one icon. So two icons in one place. Is it possible by code?(In reply to Srijan Bhatia from comment #5) > Submitted a patch for this. > https://gerrit.libreoffice.org/c/core/+/95955 > Marked as WIP as logo is needed. Ideally we have two variants: 1. Pause: presenterscreen-ButtonPauseTimerNormal.png & presenterscreen-ButtonPauseTimerMouseOver.png 2. Resume: presenterscreen-ButtonResumeTimerNormal.png & presenterscreen-ButtonResumeTimerMouseOver.png It will weird if we just utilizing only one icon. So two icons in one place. Is it possible by code?
(In reply to Rizal Muttaqin from comment #11) > It will weird if we just utilizing only one icon. So two icons in one place. > Is it possible by code? I don't think that is possible. I would try to make the button dynamic(it would show resume when paused and pause when running) if possible.
(In reply to Srijan Bhatia from comment #12) > (In reply to Rizal Muttaqin from comment #11) > > > It will weird if we just utilizing only one icon. So two icons in one place. > > Is it possible by code? > > I don't think that is possible. I would try to make the button dynamic(it > would show resume when paused and pause when running) if possible. Great, hope it will work.
(In reply to Rizal Muttaqin from comment #11) > 1. Pause: presenterscreen-ButtonPauseTimerNormal.png & > presenterscreen-ButtonPauseTimerMouseOver.png > 2. Resume: presenterscreen-ButtonResumeTimerNormal.png & > presenterscreen-ButtonResumeTimerMouseOver.png I made it so that the button now shows resume when paused and pause when running. Now i need the above 4 icons.
(In reply to Srijan Bhatia from comment #14) > (In reply to Rizal Muttaqin from comment #11) > > > 1. Pause: presenterscreen-ButtonPauseTimerNormal.png & > > presenterscreen-ButtonPauseTimerMouseOver.png > > 2. Resume: presenterscreen-ButtonResumeTimerNormal.png & > > presenterscreen-ButtonResumeTimerMouseOver.png > > I made it so that the button now shows resume when paused and pause when > running. Now i need the above 4 icons. Ah such a great work. Better you submit your patch first and than I will make another dedicated bug report for the icon part.
Submitted the patch. https://gerrit.libreoffice.org/c/core/+/95955
(In reply to Srijan Bhatia from comment #16) > Submitted the patch. > https://gerrit.libreoffice.org/c/core/+/95955 From your patch: https://gerrit.libreoffice.org/c/core/+/95955/6/officecfg/registry/data/org/openoffice/Office/PresenterScreen.xcu I could not find ButtonPauseTimer nor ButtonResumeTimer. I just can see ButtonRestartTimer and ButtonNotes. Did I missed something?
I am sorry i forgot to add that change to git. I have updated it now.
The icons has been merged, FYI https://gerrit.libreoffice.org/c/core/+/96254
final patch https://gerrit.libreoffice.org/c/core/+/95955
Srijan Bhatia committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/41d75ee814d71513922a12fae82f2e7eecbcd5f5 tdf#128964 Add time pause/resume button to Impress Presenter console It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Looks good, thanks to both. Sometimes time count resumes differently, with 4 seconds more or 3 seconds less. Like, if you stop at 10 and 20 seconds, it will start OK, but next time you stop at 30, it will start from 34, and when you stop again at 40, it will start from 37. Not straightforward, but can be seen with more stops and longer pauses. Srijan, please comment. Srijan, I think this was you r 1st bug, congrats. Please see also Bug 90978 to add Exit button, which should be easy now.
(In reply to Timur from comment #22) > Looks good, thanks to both. > Sometimes time count resumes differently, with 4 seconds more or 3 seconds > less. > Like, if you stop at 10 and 20 seconds, it will start OK, but next time you > stop at 30, it will start from 34, and when you stop again at 40, it will > start from 37. > Not straightforward, but can be seen with more stops and longer pauses. > Srijan, please comment. > > Srijan, I think this was you r 1st bug, congrats. Please see also Bug 90978 > to add Exit button, which should be easy now. Thanks Timur. I'll look into the issue and add the exit button as well.
(In reply to Timur from comment #22) > Sometimes time count resumes differently, with 4 seconds more or 3 seconds > less. > Like, if you stop at 10 and 20 seconds, it will start OK, but next time you > stop at 30, it will start from 34, and when you stop again at 40, it will > start from 37. > Not straightforward, but can be seen with more stops and longer pauses. > Srijan, please comment. I couldn't reproduce this issue.
Helo Srijan congratulation for your great work. I have a little concern, now the bottom toolbar icons and timer shift when clicking Pause/Resume button. This should not be happen. May be give toolbar a longer size.
(In reply to Rizal Muttaqin from comment #25) > Helo Srijan congratulation for your great work. > > > I have a little concern, now the bottom toolbar icons and timer shift when > clicking Pause/Resume button. This should not be happen. May be give toolbar > a longer size. Hi Rizal, The toolbar size is calculated based on the components of the toolbar so it is not possible to give the toolbar a longer size. I could try to fix the pause button's width but this may cause the text to look a bit distorted. I'll try it nevertheless.
(In reply to Rizal Muttaqin from comment #25) > Helo Srijan congratulation for your great work. > > > I have a little concern, now the bottom toolbar icons and timer shift when > clicking Pause/Resume button. This should not be happen. May be give toolbar > a longer size. Patch for this https://gerrit.libreoffice.org/c/core/+/97151
Srijan Bhatia committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/d53a4f126e9d3ec0a63684d4c7af3108f352791c tdf#128964 fix shifting of icons when the pause/resume button changes It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.