Bug 129104 - When saving user-defined menus, standard menu entries are (partially) lost
Summary: When saving user-defined menus, standard menu entries are (partially) lost
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.3.1.1 rc
Hardware: All All
: medium normal
Assignee: Not Assigned
URL: https://listarchives.libreoffice.org/...
Whiteboard:
Keywords:
Depends on:
Blocks: Main-Menu
  Show dependency treegraph
 
Reported: 2019-11-29 17:20 UTC by joesch04
Modified: 2024-06-06 04:24 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments
Incorrect display in LO 6.0.3 when opening the file with user-defined menu (84.01 KB, image/png)
2019-11-29 17:23 UTC, joesch04
Details
Test file with user-defined menu to reproduce the error (13.90 KB, application/vnd.oasis.opendocument.text)
2019-11-29 17:26 UTC, joesch04
Details

Note You need to log in before you can comment on or make changes to this bug.
Description joesch04 2019-11-29 17:20:36 UTC
Description:
When I save a custom menu to a file in LO (tested in LO 6.3.1) and later open that file in another LO version (or AOO), some of the default menus are not fully displayed.

As an example I add a screenshot of the file in LO 6.0.3.
The display errors in older versions of LO and in versions of AOO (even current ones) are much bigger.


Steps to Reproduce:
1. create a new text file
2. add a custom menu to the file 
3. save the file in the ODF
4. open the file in another (older) version of LO or in AOO

Actual Results:
Standard menus are no longer fully displayed when such files are opened.

Expected Results:
Standard menus should be displayed correctly in any program version.


Reproducible: Always


User Profile Reset: Yes



Additional Info:
I think the bug affects all program versions 6.x
Comment 1 joesch04 2019-11-29 17:23:25 UTC
Created attachment 156185 [details]
Incorrect display in LO 6.0.3 when opening the file with user-defined menu
Comment 2 joesch04 2019-11-29 17:26:06 UTC
Created attachment 156186 [details]
Test file with user-defined menu to reproduce the error
Comment 3 Christoph Schultz 2019-11-29 20:36:28 UTC
in LO > 6.3.1 it works fine
Comment 4 Heiko Tietze 2019-11-30 07:24:51 UTC
I see the entry "More breaks >" with

Version: 6.2.8.2
Build ID: 6.2.8-3
CPU threads: 8; OS: Linux 5.3; UI render: default; VCL: kde5; 
Locale: de-DE (en_US.UTF-8); UI-Language: en-US
Calc: threaded
Comment 5 joesch04 2019-11-30 08:56:27 UTC
> in LO > 6.3.1 it works fine

What exactly do you mean?

I can also open the sample file in LO 6.3.1 without errors in the menu display. 
That wasn't part of my bug report either.
Comment 6 joesch04 2019-11-30 09:08:49 UTC
Clarification / Supplement:
---------------------------
I haven't examined it in detail, but it seems to be that errors always occur when the default menu items of the LO version where a file with custom menu items is created differ from the LO version where the file is opened later.

Example:
If I create a file with a custom menu in LO 6.3.1 and then open it in LO 6.2.5, there will be no errors in the Insert menu because the Insert default menus in 6.3.1 and 6.2.5 are the same.

I note: Incorrect display only occurs if the default menus differ in the participating LO versions.
Comment 7 Buovjaga 2020-06-04 14:21:18 UTC
Maybe let's add this as a UX topic: should we strive to retain backwards compatibility in menu changes? Currently the menu definition XML files have no concept of partial updates. It is all or nothing. This means that it is impossible to use user-defined menus in an older version with an outdated general menu structure. It seems to me that such partial updates might require a rather big effort to achieve.
Comment 8 Heiko Tietze 2020-06-05 10:19:34 UTC
(In reply to Buovjaga from comment #7)
> It seems to me that such partial updates might
> require a rather big effort to achieve.

No idea how user-defined menus are integrated into the shipped configuration. I believe users can expect a consistency, so if the effort is too large we could show a warning. Maxim, what do you think?
Comment 9 Maxim Monastirsky 2020-06-05 12:53:57 UTC
(In reply to Heiko Tietze from comment #8)
> No idea how user-defined menus are integrated into the shipped
> configuration.
Same way this is done for customization which stored in the user profile: There's a menubar.xml file inside the odf package, which overrides the shipped one. So basically this is the same problem as reported for the user profile in Bug 57466.

My take is that regardless of the outcome of Bug 57466, user who need to add/remove menu items in a portable way, should really consider creating an extension, instead of this menubar-inside-document misfeature. Extensions have a proper way to merge individual command into the shipped menu structure. In addition, it's possible to change the runtime menu structure using the UNO api, which can be done also from document macros.
Comment 10 QA Administrators 2022-06-06 03:27:09 UTC Comment hidden (obsolete)
Comment 11 QA Administrators 2024-06-06 03:17:24 UTC
Dear joesch04,

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.
 
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug