Bug 129143 - FILESAVE: PPTX: bullets have a black border after RT
Summary: FILESAVE: PPTX: bullets have a black border after RT
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
6.4.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:6.5.0 target:6.4.0.1
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2019-12-02 09:12 UTC by Xisco Faulí
Modified: 2022-02-13 17:37 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
sample file (130.00 KB, application/vnd.ms-powerpoint)
2019-12-02 09:12 UTC, Xisco Faulí
Details
Screenshot of the original document (97.43 KB, image/png)
2022-02-06 12:16 UTC, Vaibhav Malik
Details
Screenshot after saving as .pptx and opening it without clicking anywhere (97.72 KB, image/png)
2022-02-06 12:18 UTC, Vaibhav Malik
Details
Screenshot after saving as .pptx and opening it, clicking inside the box and clicking outside again. (101.90 KB, image/png)
2022-02-06 12:19 UTC, Vaibhav Malik
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2019-12-02 09:12:14 UTC
Created attachment 156238 [details]
sample file

Steps to reproduce:
1. Open the attached document
2. Save it as PPTX
3. Open the new document

-> Both bullets have a black border around them

Reproduced in

Version: 6.5.0.0.alpha0+
Build ID: 47dd2c63f649828a833543e21d4eca5866ec9ebe
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded
Comment 1 Xisco Faulí 2019-12-02 09:13:46 UTC
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=126818d293982e578dfb4d977ee0ea64a1cff0de

author	Noel Grandin <noel.grandin@collabora.co.uk>	2019-07-08 14:41:34 +0200
committer	Noel Grandin <noel.grandin@collabora.co.uk>	2019-07-08 21:29:19 +0200
commit 126818d293982e578dfb4d977ee0ea64a1cff0de (patch)
tree 2602b0b176cf6d3e321b8fddbc18d840184454c6
parent 31bd8c4a4a4752dcff12ee35636193f79a6d6137 (diff)
no need to use AlphaMask in DrawingML::WriteParagraphNumbering
since we're just setting it to fully opaque

Bisected with: bibisect-linux64-6.4

Adding Cc: to Noel Grandin
Comment 2 Commit Notification 2019-12-17 08:26:14 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/5c54778aad677d6bb6e6687f0f43dffad1aefa1e

tdf#129143 FILESAVE: PPTX: bullets have a black border after RT

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Xisco Faulí 2019-12-17 10:19:49 UTC
Verified in

Version: 6.5.0.0.alpha0+
Build ID: f86824cca0c442d371379d2ea0bff2241f18ab3d
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

@Noel, thanks for fixing this issue!
Comment 4 Commit Notification 2019-12-17 10:42:45 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "libreoffice-6-4":

https://git.libreoffice.org/core/commit/7522113559f33a3349591462b598e986bc427ed9

tdf#129143 FILESAVE: PPTX: bullets have a black border after RT

It will be available in 6.4.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Vaibhav Malik 2022-02-06 12:14:19 UTC
The bug is still reproducible in:
Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 2dd096ea4f98cc9b579bd7095ddccb7caa956815
CPU threads: 4; OS: Linux 5.13; UI render: default; VCL: gtk3
Locale: en-IN (en_IN); UI: en-US
Calc: threaded

Further, the "Click to add Text" is behaving strangely. On loading it lost all its formatting, then when I clicked inside the box and clicked outside again, the size of the text "Click to add Text" increased.
Comment 6 Vaibhav Malik 2022-02-06 12:16:31 UTC
Created attachment 178090 [details]
Screenshot of the original document
Comment 7 Vaibhav Malik 2022-02-06 12:18:00 UTC
Created attachment 178091 [details]
Screenshot after saving as .pptx and opening it without clicking anywhere
Comment 8 Vaibhav Malik 2022-02-06 12:19:33 UTC
Created attachment 178092 [details]
Screenshot after saving as .pptx and opening it, clicking inside the box and clicking outside again.

Notice the change in the font size.
Comment 9 Buovjaga 2022-02-12 09:04:37 UTC
(In reply to Vaibhav Malik from comment #5)
> The bug is still reproducible in:
> Version: 7.4.0.0.alpha0+ / LibreOffice Community
> Build ID: 2dd096ea4f98cc9b579bd7095ddccb7caa956815
> CPU threads: 4; OS: Linux 5.13; UI render: default; VCL: gtk3
> Locale: en-IN (en_IN); UI: en-US
> Calc: threaded
> 
> Further, the "Click to add Text" is behaving strangely. On loading it lost
> all its formatting, then when I clicked inside the box and clicked outside
> again, the size of the text "Click to add Text" increased.

Ok, let me break down what I understand. I tested using the 6.4 Linux bibisect repository.

As Xisco did not attach any screenshot, it is not easy to imagine how it looked like in 2019 with the issue :) The problem was black borders around the bullets that have four sections with different colours.

Now, what you are describing is the first text box from the left. To me, it actually looks like the fidelity was improved, because in 2019 there was no placeholder "Click to add text" at all!

If you want, you can create a new report for it. However, you might first use Bugzilla's advanced search to try and find existing reports. You don't have to reupload any files, you can just refer to them like .ppt file attachment 156238 [details], screenshot attachment 178090 [details] etc.
Comment 10 Vaibhav Malik 2022-02-12 20:21:20 UTC
I am talking about both, the two bullets(on top right and bottom left) as well as the text dialog(on the top left)

I noticed two things,
1. When opened in gdb, I noticed that the function DrawingML::WriteParagraphNumbering is getting called countless times.
2. During some calls to DrawingML::WriteParagraphNumbering the value of const Reference< XPropertySet >& rXPropSet was found to be entirely different than correct values.
Comment 11 Buovjaga 2022-02-12 21:45:13 UTC
(In reply to Vaibhav Malik from comment #10)
> I am talking about both, the two bullets(on top right and bottom left) as
> well as the text dialog(on the top left)

The border around the coloured bullets is just the image bounding box outline, it does not show up in exported results or the slideshow. Disabling it in Impress is a bit hackier when compared to Writer: https://ask.libreoffice.org/t/unwanted-gray-border-showing-up-around-images/19321
Comment 12 Vaibhav Malik 2022-02-13 17:37:39 UTC
Ohh okay, I didn't know that. Thanks for the information