Bug 129153 - Show MIME type icon in main menu File>Recent documents list
Summary: Show MIME type icon in main menu File>Recent documents list
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Bayram Çiçek
URL:
Whiteboard: target:7.2.0
Keywords: difficultyInteresting, easyHack, skillCpp, topicUI
Depends on:
Blocks:
 
Reported: 2019-12-03 04:40 UTC by Rizal Muttaqin
Modified: 2021-04-12 07:34 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments
macOS 11.2.3, LibreOffice nightly 2021-04-07 (268.08 KB, image/png)
2021-04-07 07:47 UTC, steve
Details
MIME type in recent document list (91.66 KB, image/png)
2021-04-10 23:32 UTC, Rizal Muttaqin
Details
a MIME type of protected file in Start Center (32.43 KB, image/png)
2021-04-10 23:34 UTC, Rizal Muttaqin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rizal Muttaqin 2019-12-03 04:40:10 UTC
LibreOffice is a monolithic type software by design. I'm sure that this status leads to recent file list in each module contains whole files which already opened by every single module. While we can see full path as well as their file name. It would be useful if we add an MIME icon to the list
Comment 1 Roman Kuznetsov 2019-12-03 05:04:27 UTC
Rizal, do you mean recent files list in the main menu?
Comment 2 Rizal Muttaqin 2019-12-03 05:06:18 UTC
(In reply to Roman Kuznetsov from comment #1)
> Rizal, do you mean recent files list in the main menu?

Yes, absolutely you are right
Comment 3 Heiko Tietze 2019-12-03 07:29:53 UTC
Yes. It makes sense where icons in menus are enabled, at least.
Comment 4 V Stuart Foote 2019-12-03 12:20:48 UTC
+1, but only when showing icons in menus is enabled.
Comment 5 Rizal Muttaqin 2019-12-03 12:25:09 UTC
(In reply to V Stuart Foote from comment #4)
> +1, but only when showing icons in menus is enabled.

Yes, this enhancement request will not affects user with GTK3 backend and also the option has been removed :) (see tdf#123265)
Comment 6 Heiko Tietze 2019-12-19 11:50:31 UTC
Code pointer for the files list is framework/source/uielement/recentfilesmenucontroller.cxx with the fillPopupMenu() method. Somewhat tricky might be to do something similar as in sfx2/source/control/recentdocsview.cxx getDefaultThumbnail().
Comment 7 Bayram Çiçek 2021-02-26 19:18:58 UTC
I would like to work on this. Assigning to myself.
Comment 8 Rizal Muttaqin 2021-02-27 03:15:48 UTC
(In reply to Bayram Çiçek from comment #7)
> I would like to work on this. Assigning to myself.

Nice, I hope "Clear recent documents list" get an icon also. ;)
Comment 9 Bayram Çiçek 2021-03-03 12:46:18 UTC
(In reply to Rizal Muttaqin from comment #8)
 
> Nice, I hope "Clear recent documents list" get an icon also. ;)
Hi. I've implemented displaying icons in 'File->Recent Documents' list.
However, I couldn't find the code pointer(s) for "Clear recent documents list". Could you please specify the code pointers?.

Thanks.
Comment 10 Rizal Muttaqin 2021-03-06 09:27:49 UTC
(In reply to Bayram Çiçek from comment #9)
> (In reply to Rizal Muttaqin from comment #8)
>  
> > Nice, I hope "Clear recent documents list" get an icon also. ;)
> Hi. I've implemented displaying icons in 'File->Recent Documents' list.
> However, I couldn't find the code pointer(s) for "Clear recent documents
> list". Could you please specify the code pointers?.
> 
> Thanks.

I have zero understanding in code, hope Maxim could help
Comment 11 Commit Notification 2021-04-06 13:53:33 UTC
Bayram Çiçek committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/6fcabbd6199869753fd6a266f23901962a77f556

tdf#129153: Show MIME type icon in main menu File>Recent documents list

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 steve 2021-04-07 07:47:04 UTC
Created attachment 170992 [details]
macOS 11.2.3, LibreOffice nightly 2021-04-07

verified - thanks this is a welcome change and addition to LibreOffice.
Comment 13 Rizal Muttaqin 2021-04-10 23:32:25 UTC
Created attachment 171089 [details]
MIME type in recent document list

Unfortunately a protected document has a regular icon instead of a file with a padlock (or similar). Here's "Presentasi Terproteksi.odp" as an example. 

I am not sure whether this request is still covered by this report or not.
Comment 14 Rizal Muttaqin 2021-04-10 23:34:48 UTC
Created attachment 171090 [details]
a MIME type of protected file in Start Center

(In reply to Rizal Muttaqin from comment #13)
> Created attachment 171089 [details]
> MIME type in recent document list
> 
> Unfortunately a protected document has a regular icon instead of a file with
> a padlock (or similar). Here's "Presentasi Terproteksi.odp" as an example. 
> 
> I am not sure whether this request is still covered by this report or not.

While in Start Center, I get this kind of MIME type
Comment 15 Heiko Tietze 2021-04-12 07:34:34 UTC
(In reply to Rizal Muttaqin from comment #13)
> I am not sure whether this request is still covered by this report or not.

Menu icons never showed encryption. And I doubt it works well with 16px.