When we read EMF+ EmfPlusPath records, we are not reading the point types correctly when we use points that use relative locations.
According to [MS-EMFPLUS] section "18.104.22.168 EmfPlusPath Object":
"PathPointTypes (variable): An array of PathPointCount objects that specifies how the points in the PathPoints field are used to draw the path. The type of objects in this array is specified by the PathPointFlags field, as follows:
- If the R flag is set, the point types are specified by EmfPlusPathPointTypeRLE objects, which use run-length encoding (RLE) compression ([MS-WMF] section 3.1.6).
- If the R flag is clear, the point types are specified by EmfPlusPathPointType objects."
Currently we are handling the second case (where the R flag is clear), but we are not handline the case where the R flag is set. In that case we should be reading an EmfPlusPathPointTypeRLE, but this is not the case.
Steps to Reproduce:
This needs a test case document, unfortunately I don't have one readily at hand.
User Profile Reset: No
Do you have example EMF+ image which demonstrate using of such PathPointTypes?
It will be really hard to verify if it is working correctly without some reference image.
I will try to create such image.
Created attachment 156763 [details]
EMF+ Joint line
It seems that joints are not rendered correctly,
Pen penJoin(Color(255, 0, 0, 255), 8);
path.AddLine(Point(50, 200), Point(100, 200));
path.AddLine(Point(100, 200), Point(100, 250));
Bartosz, that's a different issue I'm afraid. We don't seem to correctly support bevelled lines correctly, but that's a different issue to EmfPlusPath objects.
Might be worthwhile logging a new bug about mitering (we currently don't support SETMITERLIMIT).
[Automated Action] NeedInfo-To-Unconfirmed
Could you please attach a screenshot showing how the file should look like ?
Dear Chris Sherlock,
This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.
For more information about our NEEDINFO policy please read the
wiki located here:
If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.
Thank you for helping us make LibreOffice even better for everyone!
Dear Chris Sherlock,
Please read this message in its entirety before proceeding.
Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):
a) Provide details of your system including your operating
system and the latest version of LibreOffice that you have
confirmed the bug to be present
b) Provide easy to reproduce steps – the simpler the better
c) Provide any test case(s) which will help us confirm the problem
d) Provide screenshots of the problem if you think it might help
e) Read all comments and provide any requested information
Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:
a) respond via email
b) update the version field in the bug or any of the other details
on the top section of our bug tracker