Bug 129375 - Crash when using insert > table of contents... > bibliography entry... on iOS 4.2
Summary: Crash when using insert > table of contents... > bibliography entry... on iOS...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: iOS Editor (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: Other iOS
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:6.5.0
Keywords:
Depends on:
Blocks:
 
Reported: 2019-12-13 15:57 UTC by Nicolas Christener
Modified: 2020-01-14 15:46 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Christener 2019-12-13 15:57:13 UTC
Description:
When tapping on the menu "Insert > Table of Contents and Index > Bibliography Entry..." the iOS app crashes.

Steps to Reproduce:
1. Create/open a writer document on iOS 4.2
2. Tap on the menu "Insert > Table of Contents and Index > Bibliography Entry..."

Actual Results:
The app crashes.

Expected Results:
The app should not crash.


Reproducible: Always


User Profile Reset: No



Additional Info:
Tested with 4.2 (25) in iOS 13.3.x

Note: I think we just removed that entry in 4.1.x from the menu as we currently don't need this functionality.
Comment 1 Xisco Faulí 2019-12-16 18:37:18 UTC
Moving to NEW
Comment 2 How can I remove my account? 2019-12-31 10:24:20 UTC
Can reproduce in a build from current core:cp-6.2+online:master , execution reaches the std::abort() in SalUserEventList::DispatchUserEvents() in vcl/source/app/salusereventlist.cxx at line 117. The warning printed on the previous line is:

vcl/source/app/salusereventlist.cxx:116: Uncaught com.sun.star.uno.DeploymentException message: component context fails to supply service com.sun.star.frame.Bibliography of type com.sun.star.container.XNameAccess context: N4cppu16ComponentContextE

Possibly some component constructor or factory doesn't get built for iOS? But then we would get warnings about that from cppuhelper/source/shlib.cxx, and the only such I see are 'unknown constructor name "com_sun_star_comp_framework_StatusBarFactory_get_implementation"'
Comment 3 How can I remove my account? 2019-12-31 10:28:44 UTC
But yeah, apparently the missing bibliography stuff is handled (or not handled) at some other point, without proceeding to cppuhelper::detail::loadSharedLibComponentFactory() from which the above mentioned warning would be displayed.

Anyway, the fact is that in extensions/Module_extensions.mk , the Library_bib thing is not built in the non-DBCONNECTIVITY case. Should it be? Will doing that drag in lots of things that has never been built for iOS and might cause various interesting issues? How closely is the "bibliography" concept in LO coupled to the "database" concept? It is obvious (I hope) that we have zero interest in providing Base functionality on iOS, right?

Will do some experimentation. If nothing else, I could at least remove that "Insert > Table of Contents and Index > Bibliography Entry..." menu entry for iOS (and Android?).
Comment 4 How can I remove my account? 2019-12-31 10:52:06 UTC
Nicolas, how important is it to get the full bibliography functionality in the iOS app? I must admit I have never even tried to use it on desktop LO, and have no idea what it does or how it is implemented. It is quite possible that it requires database functionality that so far has been left out when building for iOS (and Android) completely. Or would it be acceptable to just drop that menu entry for iOS?

Will continue to hack, debug, and look for some easy solution in the meantime.
Comment 5 How can I remove my account? 2019-12-31 12:24:42 UTC
Suggested fix in https://gerrit.libreoffice.org/c/core/+/86043
Comment 6 Commit Notification 2019-12-31 14:07:42 UTC
Tor Lillqvist committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/6eb5cffa1c4ee15bf96fe97769efac65ba785ef9

tdf#129375: Avoid crash when inserting bibliography entry on iOS

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Nicolas Christener 2020-01-14 15:39:45 UTC
Tested in 4.2 (30). This issue is fixed and can be closed.

Thanks a lot to the Collabora team and especially to Tor for taking care of this.