Download it now!
Bug 129491 - Option buttons have incorrect vertical alignment
Summary: Option buttons have incorrect vertical alignment
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
6.4.0.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
: 129465 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-12-19 10:05 UTC by Xisco Faulí
Modified: 2020-05-30 04:40 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2019-12-19 10:05:00 UTC
Steps to reproduce:
1. Open Writer
2. Go to menu Form - Option button
3. Use half of the page to draw it

-> The button is aligned to the top. it should be in the middle, next to the label

Reproduced in

Version: 6.5.0.0.alpha0+
Build ID: fb1eac64df88baae9f211d052793773686c0e180
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded
Comment 1 Xisco Faulí 2019-12-19 10:06:25 UTC
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=302a00a3190743f5e6d2b61e5b40e493c4744b7e

author	Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>	2019-06-06 17:14:53 +0900
committer	Tomaž Vajngerl <quikee@gmail.com>	2019-06-06 15:48:19 +0200
commit	302a00a3190743f5e6d2b61e5b40e493c4744b7e (patch)
tree	21ce09afb0bc7a8aa678a009d9733a8ca0e7b528
parent	b48672b3108488e2739a49e6f6e327a48c96ed70 (diff)
tdf#124947 fix hit area of the radio buttons, size in ios theme

Bisected with: bibisect-linux64-6.4

Adding Cc: to Tomaž Vajngerl
Comment 2 Julien Nabet 2019-12-19 10:52:44 UTC
It makes me think about tdf#129465 (dup?)
Comment 3 Xisco Faulí 2019-12-19 10:56:47 UTC
*** Bug 129465 has been marked as a duplicate of this bug. ***
Comment 4 Julien Nabet 2019-12-19 10:59:38 UTC
Since checkbox seems ok, let's compare a bit.
Radiobutton:
1972              rMouseRect = tools::Rectangle(aPos, aSize);
1973              rMouseRect.SetLeft(rPos.X());
1974              rMouseRect.SetTop(rPos.Y());
1975  
1976              rStateRect.SetLeft( rPos.X() );
1977              rStateRect.SetTop( rMouseRect.Top() );
(see https://opengrok.libreoffice.org/xref/core/vcl/source/control/button.cxx?r=80530986#1972)

Checkbox:
2995          rMouseRect          = tools::Rectangle( aPos, aSize );
2996          rMouseRect.SetLeft( rPos.X() );
2997          rStateRect.SetLeft( rPos.X() );
2998          rStateRect.SetTop( rMouseRect.Top() );
(see https://opengrok.libreoffice.org/xref/core/vcl/source/control/button.cxx?r=80530986#2995)
Comment 5 Julien Nabet 2019-12-19 14:22:48 UTC
just for information with this, it's ok:
diff --git a/vcl/source/control/button.cxx b/vcl/source/control/button.cxx
index 715752c146c4..64cc91f43576 100644
--- a/vcl/source/control/button.cxx
+++ b/vcl/source/control/button.cxx
@@ -1971,7 +1971,7 @@ void RadioButton::ImplDraw( OutputDevice* pDev, DrawFlags nDrawFlags,

             rMouseRect = tools::Rectangle(aPos, aSize);
             rMouseRect.SetLeft(rPos.X());
-            rMouseRect.SetTop(rPos.Y());
+            //rMouseRect.SetTop(rPos.Y());

             rStateRect.SetLeft( rPos.X() );
             rStateRect.SetTop( rMouseRect.Top() );
Comment 6 Xisco Faulí 2019-12-19 14:25:32 UTC
the question is if removing 'rMouseRect.SetTop(rPos.Y())' would reintroduce tdf#124947...
The other option would be to make that like ios specific ?