Bug 129745 - Help button in Paragraph Style dialog tab only remembers its "identity" once
Summary: Help button in Paragraph Style dialog tab only remembers its "identity" once
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.3.2.2 release
Hardware: All All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.4.0 target:7.2.6 target:7.3.0.2
Keywords: bibisected, regression
Depends on:
Blocks: Paragraph-Dialog Help-Link
  Show dependency treegraph
 
Reported: 2020-01-02 18:48 UTC by sdc.blanco
Modified: 2022-01-23 07:34 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description sdc.blanco 2020-01-02 18:48:22 UTC
1.  Any document, right-click, Paragraph, Edit Style (which opens Paragraph Style dialog box)
2. Click on Help button twice

Actual Result:  

First time, opens help page for the tab.  
Second time, opens the generic introduction page:  
https://help.libreoffice.org/6.5/en-US/text/swriter/main0000.html?System=WIN&DbPAR=WRITER

Expected Result:  Always opens the relevant help page for the relevant tab.

Additional information:

1.  Same effect for different tabs in the Paragraph Style dialog
2.  Have not tested with other dialog boxes
3.  Works correctly with 6.3.4.2

tested with

Version: 6.5.0.0.alpha0+ (x64)
Build ID: 444f0d256957544d26b9af9a0898364e829df1b5
CPU threads: 8; OS: Windows 10.0 Build 18363; UI render: GL; VCL: win; 
Locale: sv-SE (en_DK); UI-Language: en-US
Calc: threaded
Comment 1 Durgapriyanka 2020-01-03 16:55:23 UTC
Thank you for reporting the bug. I can reproduce the bug in

Version: 6.4.0.0.alpha1+ (x86)
Build ID: ec7374ff84c71edfbb30d6e4dc5b486b6df7107f
CPU threads: 2; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-11-10_21:37:30
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded
	

But, not in

LibreOffice 3.3.0 
OOO330m19 (Build:6)
tag libreoffice-3.3.0.4. It works fine.
Comment 2 Durgapriyanka 2020-01-03 16:55:23 UTC Comment hidden (obsolete)
Comment 3 Dieter 2020-01-05 12:59:37 UTC
I confirm it with

Version: 6.5.0.0.alpha0+ (x64)
Build ID: e26d89371f0e4f41476c9a99be01d98dedb76776
CPU threads: 4; OS: Windows 10.0 Build 18362; UI render: default; VCL: win; 
Locale: de-DE (de_DE); UI-Language: en-GB
Calc: threaded
Comment 4 Xisco Faulí 2020-01-20 14:42:53 UTC
I can reproduce it in

Version: 6.5.0.0.alpha0+
Build ID: fc1f85127968d1c2e0a53dace51bf8a78f9e6ca5
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: x11; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded

but not with gtk3...
Comment 5 Xisco Faulí 2020-01-20 15:23:39 UTC
It worked fine until https://cgit.freedesktop.org/libreoffice/core/commit/?id=b78edeca8631a5e3b888d6fb357fe9125a491c41. After this commit, the main writer help page was displayed. Later on, it was fixed in https://cgit.freedesktop.org/libreoffice/core/commit/?id=34e83dd95260d534464ff9a61eddefdde136013c when the help page is displayed for the first time, but not for the second time.

Adding Cc: to Caolán McNamara
Comment 6 Xisco Faulí 2020-01-20 15:23:57 UTC
Also reproducible in

Version: 6.3.5.0.0+
Build ID: b4708c1c2b4acb171952ebead751792037161680
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: x11; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded
Comment 7 sdc.blanco 2020-09-29 17:49:55 UTC
Have encountered a similar problem with another dialog box.
1. Insert textbox or shape.
2. Select inserted object.
3. Right-click, choose "Position and Size"
4. In "position and size" dialog box, click on Help twice.

Result: 

Finds help page first time.
Gives error message for all subsequent clicks on help.

Additional information.
1.  Same result if "Rotation" tab is used with this dialog box.

Question:  Should this new case (with a different dialog box) be considered part of the same bug?  Or should this be filed as a new, separate report?

Version: 7.1.0.0.alpha0+ (x64)  (29. sept)
Build ID: 3c6177be2705303044e3de262689d593f3d0f282
CPU threads: 8; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL: win
Locale: da-DK (en_DK); UI: en-US
Calc: threaded
Comment 8 sdc.blanco 2021-12-30 01:37:51 UTC
repro:

Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: e63fe68fb1d0915b64fdf63f7fa6eed866fa3a0d
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: da-DK (da_DK); UI: en-US
Calc: CL
Comment 9 Rafael Lima 2022-01-06 21:02:40 UTC
I cannot reproduce this bug. Every time I click the Help button I land in the "Organizer" tab:
https://help.libreoffice.org/7.2/en-US/text/shared/01/05040100.html?System=UNIX&DbPAR=WRITER&HID=sfx/ui/managestylepage/ManageStylePage#bm_id3145356

I tried closing and opening the Paragraph Style and clicking the Help button multiple times, but could not find any issue.

I am using kf5 on LO 7.2.5.

Version: 7.2.5.2 / LibreOffice Community
Build ID: 20(Build:2)
CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Ubuntu package version: 1:7.2.5~rc2-0ubuntu0.21.10.1~lo1
Calc: threaded
Comment 10 Dieter 2022-01-06 21:45:07 UTC
Still present in

Version: 7.2.5.2 (x64) / LibreOffice Community
Build ID: 499f9727c189e6ef3471021d6132d4c694f357e5
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL


Target of second click is now:
https://help.libreoffice.org/7.2/en-GB/text/shared/05/err_html.html?System=WIN&DbPAR=WRITER&HID=modules/swriter/ui/paradialog/help

Restart in SafeMode has no effect. Same behaviour with paragraph dialog.
Comment 11 Rafael Lima 2022-01-06 22:15:00 UTC
Dieter, I gave another try using "gen" and "gtk3" backends. I could not reproduce the bug.

Maybe this is bug with the "win" backend?
Comment 12 Dieter 2022-01-06 22:58:53 UTC
(In reply to Rafael Lima from comment #11)
> Maybe this is bug with the "win" backend?

Xisco could reproduce it with Linux (see comment 4 and 6).
Comment 13 Caolán McNamara 2022-01-07 12:14:46 UTC
I think this effect happens only for the online help, and when the intermediate "Help is not installed...Read Help Online" dialog is shown
Comment 14 Commit Notification 2022-01-07 15:13:13 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/8fd6924fc36b7a006e2edec60b7b59cec2ca883b

Resolves: tdf#129745 don't override child help for application frames

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 15 Caolán McNamara 2022-01-07 15:14:02 UTC
done in trunk, backports to 7-3 and 7-2 in gerrit
Comment 16 Commit Notification 2022-01-09 12:37:41 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/6c191f339c8bd8717e01085baea93ccfb2416c82

Resolves: tdf#129745 don't override child help for application frames

It will be available in 7.2.6.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 17 Commit Notification 2022-01-09 12:37:56 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/6ed655058f0a38af744ed2431f006011c6f0afa3

Resolves: tdf#129745 don't override child help for application frames

It will be available in 7.3.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 18 Dieter 2022-01-23 07:34:01 UTC
VERIFIED with

Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: e27a41a362bf25e12487b36f625985b35fb891e3
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL

Caolán, thanks for fixing it.