Bug 129820 - Format "Standard" appears (replaced) Format "General" in Variables (Field)
Summary: Format "Standard" appears (replaced) Format "General" in Variables (Field)
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.3.4.2 release
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: needsDevAdvice
Depends on:
Blocks: Fields-Dialog
  Show dependency treegraph
 
Reported: 2020-01-05 23:23 UTC by sdc.blanco
Modified: 2020-05-11 08:49 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Saved when Variable Format was General (8.48 KB, application/vnd.oasis.opendocument.text)
2020-01-06 23:40 UTC, sdc.blanco
Details

Note You need to log in before you can comment on or make changes to this bug.
Description sdc.blanco 2020-01-05 23:23:02 UTC
Tested with:  6.3.4.2  and 6.5.0.0.alpha

1.  Baseline condition:  Open a new document, Ctrl-F2, Variables Tab,
"General" shown in Format list ("Standard" is not).

2.  Open attachment 114832 [details] from bug 90658, 
Ctrl-F2, Variables Tab, "General" is gone from Format list; "Standard" appears.

Is this considered problematic -- at least from a UI perspective?

(I understand that General/Standard are alternative labels for the same idea (and code). I am not asking about their meaning.)

But my naive belief is that these labels should not change within the same UI  (especially given the confusion that General and Standard seem to cause). 

Additional information:

I believe that I created this shift (from General to Standard) at least once in a new (Untitled) document (while making different combinations of variable types "Variable", "Input Field" and "User Field").  But could not find a way to reproduce it.  So I mention this only as an unsubstantiated rumor.
Comment 1 Dieter 2020-01-06 21:44:39 UTC
(In reply to sdc.blanco from comment #0)
> Tested with:  6.3.4.2  and 6.5.0.0.alpha
> 
> 1.  Baseline condition:  Open a new document, Ctrl-F2, Variables Tab,
> "General" shown in Format list ("Standard" is not).

I can't confirm that. "Standard" is shown in the list.

Version: 6.5.0.0.alpha0+ (x64)
Build ID: e26d89371f0e4f41476c9a99be01d98dedb76776
CPU threads: 4; OS: Windows 10.0 Build 18362; UI render: default; VCL: win; 
Locale: de-DE (de_DE); UI-Language: en-GB
Calc: threaded

and also

Version: 6.3.4.2 (x64)
Build-ID: 60da17e045e08f1793c57c00ba83cdfce946d0aa
CPU-Threads: 4; BS: Windows 10.0; UI-Render: Standard; VCL: win; 
Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE
Calc: threaded
Comment 2 sdc.blanco 2020-01-06 23:40:11 UTC
Created attachment 156974 [details]
Saved when Variable Format was General

With 6.5.0.0.alpha 

Test 1:  Open the attachment. Ctrl-F2 - Variable tab (predict:  General format)

Test 2:  Tools>Options>Language Settings>Language>Locale Setting -- choose English (USA),  Apply, Ok.

2.  Ctrl-F2 - Variable tab  (I predict it will still show "Standard" in the Format list)

3.  Exit and restart LO

4.  Ctrl-F2 - Variable tab  (I predict it will show "General" in the Format list) 

Test 3.  If Test 2 succeeds, then try to open attachment 114832 [details]. 
Ctrl-F2, Variables Tab, "General" is gone from Format list; "Standard" appears.

If the first three tests fail:

Test 4:  Restart in Safe Mode and Factory Settings  (shows "General")

Observations:
1.  Seems to depend on which locale setting is used.  But need to restart LO to see the effect.  (even though Help>About shows the locale setting change)

2. Seems to be stored with a document (see Test 1)

3. Maybe other variations, but have not found reliable steps to reproduce.

Tested with: 
Version: 6.5.0.0.alpha0+ (x64)
Build ID: 444f0d256957544d26b9af9a0898364e829df1b5
CPU threads: 8; OS: Windows 10.0 Build 18363; UI render: GL; VCL: win; 
Locale: da-DK (en_DK); UI-Language: en-US
Calc: threaded

4. NB  Only tests 3 and 4 worked with LO 6.3.4.2
Comment 3 Buovjaga 2020-05-09 14:54:17 UTC
(In reply to sdc.blanco from comment #2)
> Created attachment 156974 [details]
> Saved when Variable Format was General
> 
> With 6.5.0.0.alpha 
> 
> Test 1:  Open the attachment. Ctrl-F2 - Variable tab (predict:  General
> format)
> 
> Test 2:  Tools>Options>Language Settings>Language>Locale Setting -- choose
> English (USA),  Apply, Ok.
> 
> 2.  Ctrl-F2 - Variable tab  (I predict it will still show "Standard" in the
> Format list)
> 
> 3.  Exit and restart LO
> 
> 4.  Ctrl-F2 - Variable tab  (I predict it will show "General" in the Format
> list) 
> 
> Test 3.  If Test 2 succeeds, then try to open attachment 114832 [details]. 
> Ctrl-F2, Variables Tab, "General" is gone from Format list; "Standard"
> appears.
> 
> If the first three tests fail:
> 
> Test 4:  Restart in Safe Mode and Factory Settings  (shows "General")
> 
> Observations:
> 1.  Seems to depend on which locale setting is used.  But need to restart LO
> to see the effect.  (even though Help>About shows the locale setting change)
> 
> 2. Seems to be stored with a document (see Test 1)
> 
> 3. Maybe other variations, but have not found reliable steps to reproduce.
> 
> Tested with: 
> Version: 6.5.0.0.alpha0+ (x64)
> Build ID: 444f0d256957544d26b9af9a0898364e829df1b5
> CPU threads: 8; OS: Windows 10.0 Build 18363; UI render: GL; VCL: win; 
> Locale: da-DK (en_DK); UI-Language: en-US
> Calc: threaded
> 
> 4. NB  Only tests 3 and 4 worked with LO 6.3.4.2

I assume you missed to mention that we need to select "Set Variable".

The only thing I confirm is test 3. Confirmed with 4.4 and 3.3 as well. However, is it a valid concern, if we can't reproduce from a known good state?

Arch Linux 64-bit
Version: 7.0.0.0.alpha1+
Build ID: c73418d8d1258ea0a8c77c07672fd182e2b28b26
CPU threads: 8; OS: Linux 5.6; UI render: default; VCL: kf5; 
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded
Built on 9 May 2020
Comment 4 sdc.blanco 2020-05-10 21:40:26 UTC
To go back to the original report:

Why should there be both "General" and "Standard" formats? 
That is the main concern.  

New way to demonstrate (not dependent on locale setting, as best I can tell), and no need to open previous documents.

1.  Open document.  Use status bar to set language to Danish.
2.  Ctrl-F2, Variable, Set Variable  (shows "Standard") in Format
3.  Change language in same document to English (USA) or English (UK)
4.  Repeat Step 2 -- now shows "General"
5.  Change language to Finnish
6.  Repeat Step 2 -- now shows "Yleinen"


Presumably all the variables are still treated as numerical variables -- but why should there be different format names for different languages (when the UI language is not changing)?

(there is no documentation -- in English -- about "Standard" or "General" format -- afaik)

(I assume that a document will store the version "Standard" or "General" or whatever was used when the variable was created -- and will be used when the document is opened.  No problem with that.  But still wondering if there should be both "General" and "Standard")

Tested with:
Version: 7.0.0.0.alpha0+ (x64)
Build ID: 10e20a77ce302a0475a661ad1886f2ca83c55f3f
CPU threads: 8; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win; 
Locale: da-DK (en_DK); UI-Language: en-US
Calc: threaded
Built 14 March 2020
Comment 5 Buovjaga 2020-05-11 08:49:09 UTC
Ok, I get the point. I asked in dev chat, but nothing yet.