Bug 129910 - Add tooltip to explain greyed out "Inherit from" in "Numbering Style" dialog
Summary: Add tooltip to explain greyed out "Inherit from" in "Numbering Style" dialog
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Styles-Dialog
  Show dependency treegraph
 
Reported: 2020-01-09 15:31 UTC by sdc.blanco
Modified: 2020-01-22 20:03 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:
Regression By:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description sdc.blanco 2020-01-09 15:31:38 UTC
View > Styles (F11) - List Styles - right click (your choice) - New

Actual result:  "Numbering Style" dialog box opens

(LO 6.3.4.2):   dropdown box for "Inherit from" is greyed out 
                "Edit Style" button is "active" (but does not seem to do anything).

(LO 6.5.0.0.alpha) both dropdown box for "Inherit from" and "Edit Style" button are greyed out.

According to LO Writer's Guide, Inherit From is not available for List styles.

If true, seems better to remove "Inherit from" and "Edit Style" button entirely from Numbering Style dialog.  (cleaner UI, no need to explain in documentation)
Comment 1 Heiko Tietze 2020-01-13 11:32:18 UTC
Guess it was solved with bug 120286. From the usability POV it makes sense to hide controls when they never apply but to disable if inappropriate only temporarily, which is the case here. So a perfect WFM.
Comment 2 sdc.blanco 2020-01-13 11:55:08 UTC
(In reply to Heiko Tietze from comment #1)
> From the usability POV it makes sense to disable if inappropriate only
> temporarily, which is the case here. So a perfect WFM.
Ok.  Have revised the summary and reopened as enhancement request for adding an explanatory tooltip.
Comment 3 sdc.blanco 2020-01-13 12:19:47 UTC
(In reply to Heiko Tietze from comment #1)
> From the usability POV it makes sense
> to hide controls when they never apply but to disable if inappropriate only
> temporarily, which is the case here. So a perfect WFM.
On further reflection.  I want to respectfully disagree.

The name of the relevant dialog box is "Numbering Style". As I understand, "inherit from" would never apply, so should not be shown according to usability principle.

Other (similar) dialog boxes, such as "Paragraph Style", "Frame Style", and "Character Style" also have "Inherit From" in their Organizer, and I can see (from comparing 6.3.4.2 and 6.5.0.0) that the "Edit Style" button is now deactivated (presumably from bug 120286). (No problem there.  Was not in the original report.)

But if I have understood the usability POV correctly, then "Numbering Style" and "Page Style" Organizer tabs should not show "Inherit From"  because (as best I can tell), it is never possible to use this control (when modifying existing or making new Numbering or Page Styles).
Comment 4 Xisco Faulí 2020-01-20 11:30:23 UTC
You can't confirm your own bugs. Moving it back to UNCONFIRMED until someone
else confirms it.
Comment 5 Heiko Tietze 2020-01-20 12:10:02 UTC
(In reply to sdc.blanco from comment #3)
> But if I have understood the usability POV correctly, then "Numbering Style"
> and "Page Style" Organizer tabs should not show "Inherit From"  because (as
> best I can tell), it is never possible to use this control (when modifying
> existing or making new Numbering or Page Styles).

Point is that inheritance can be set under some circumstances. It would be correct to hide when one module hasn't this option while the other does. But within the same workflow coming from one interaction shouldn't be too much different compared to another starting point. So I still vote for WFM.
Comment 6 sdc.blanco 2020-01-20 12:32:31 UTC
(In reply to Heiko Tietze from comment #5)
> Point is that inheritance can be set under some circumstances. It would be
> correct to hide when one module hasn't this option while the other does. 
Ok. Understand now. Please consider comment #2 -- which is how this ticket is actually configured.
Comment 7 Heiko Tietze 2020-01-20 12:42:22 UTC
(In reply to sdc.blanco from comment #6)
> Ok. Understand now. Please consider comment #2 -- which is how this ticket
> is actually configured.

Tooltips are always good, in particular when it's unclear why a control is disabled.