Bug 129996 - "Missing hyphenation info" pop-up banner displayed if Hyphenation Module is disabled.
Summary: "Missing hyphenation info" pop-up banner displayed if Hyphenation Module is d...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.4.0.1 rc
Hardware: x86-64 (AMD64) All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Hyphenation
  Show dependency treegraph
 
Reported: 2020-01-14 12:57 UTC by Paul
Modified: 2020-12-19 17:21 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot of banner. (8.97 KB, image/png)
2020-01-14 12:59 UTC, Paul
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Paul 2020-01-14 12:57:53 UTC
Description:
I don't know if this is a bug per se, but this behaviour only started after an update to 6.4 (from 6.3.3.2)

If the Libhypen Hyphenation module is disabled, then upon opening a document a "Missing hyphenation info" pop-up banner is always displayed.

Steps to Reproduce:
1.From: Tools -> Options -> Language Settings -> Writing Aids disable the "Libhypen Hyphenation" module. 
2.Open an existing document.
3.

Actual Results:
"Missing hyphenation info" pop-up banner is displayed.

Expected Results:
Banner is not displayed.


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.4.0.1
Build ID: 40(Build:1)
CPU threads: 2; OS: Linux 5.4; UI render: default; VCL: kf5; 
Locale: en-GB (en_GB.UTF-8); UI-Language: en-GB
Calc: threaded
Comment 1 Paul 2020-01-14 12:59:35 UTC
Created attachment 157148 [details]
Screenshot of banner.
Comment 2 Paul 2020-01-14 17:28:40 UTC
This appears to be due to this commit (?)
https://git.libreoffice.org/core/commit/c434fc0d181f098a179c6dc9d1506fa806d579f1

I believe the Info Bar (sorry for calling it a banner) should only be shown if the package is truly missing, and not in the case where a user has purposely chosen to disable the module.
Comment 3 Dieter 2020-01-21 08:05:35 UTC
I confirm this behaviour with

Version: 6.5.0.0.alpha0+ (x64)
Build ID: 350d25da375f221edfa37309324ce3c68cf297ef
CPU threads: 4; OS: Windows 10.0 Build 18362; UI render: default; VCL: win; 
Locale: de-DE (de_DE); UI-Language: en-GB
Calc: threaded

But it pnly happens, if you open a document, that contains hyphenation. So for me it's not a bug.

cc: Design-Team
Comment 4 Paul 2020-01-21 12:14:18 UTC
(In reply to Dieter Praas from comment #3)
> 
> But it pnly happens, if you open a document, that contains hyphenation. So
> for me it's not a bug.
> 

It's not a case of the document containing hyphenation. It happens if you open a document that *would be hyphenated*, if the hyphenation module was active.

My use case is one of never using hyphenation - I have globally disabled it by "Tools -> Options -> Language Settings -> Writing Aids disable the "Libhypen Hyphenation" module".

In a case such as this, ie, deliberate disablement, the Info Bar should not be displayed. So for me it *is* a bug.

Perhaps the logic for the display of the Info Bar could be such that if the hyphenation module is disabled, the "Missing hyphenation info" message is shown, but with the option to "Not show this message again".  That would satisfy the need for a warning if the module was inadvertently disabled, at the same time not "nagging" users who have purposely disabled the module.
Comment 5 Heiko Tietze 2020-01-21 13:44:23 UTC
The infobar needs a checkbox "Don't show again" (or we assume hyphenation is disabled intentionally so the warning doesn't need to be too obtrusive / disabling  not too cumbersome, which means a button does the trick as well).
Comment 6 Michael Stahl (allotropia) 2020-03-27 11:40:24 UTC
i agree with Paul, 'disable the "Libhypen Hyphenation" module' is an unusual configuration and the infobar is primarily about data for the libhyphen module so disabling the module should disable the infobar.