Bug 130069 - Hide section "Scope" when B&N dialog is called from an activated graphic object
Summary: Hide section "Scope" when B&N dialog is called from an activated graphic object
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
(earliest affected)
Hardware: x86-64 (AMD64) Windows (All)
: medium normal
Assignee: Not Assigned
URL: https://design.blog.documentfoundatio...
Depends on:
Blocks: HelpGaps-NewFeatures Impress-Bullet-Numbering-Dialog
  Show dependency treegraph
Reported: 2020-01-18 12:52 UTC by Regina Henschel
Modified: 2022-07-28 09:22 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:
Regression By:

Draw document for testing (13.14 KB, application/vnd.oasis.opendocument.graphics)
2020-07-06 12:41 UTC, Regina Henschel
Impress document for testing (19.04 KB, application/vnd.oasis.opendocument.presentation)
2020-07-06 12:42 UTC, Regina Henschel

Note You need to log in before you can comment on or make changes to this bug.
Description Regina Henschel 2020-01-18 12:52:29 UTC
Problem: The new Bullets&Numbering dialog in Impress/Draw is used not only for presentation objects but for graphic objects too. But for graphic objects the option "slide" and the button "Master slide" makes now sense and do not work. The only working option is "Selection". The problem is especially in Draw, where no presentation objects exist at all.

(1) For now, do not show section "Scope", if the dialog is called from an activated graphic object.
(2) For further improvement, extend the feature of the dialog so, that in case of a graphic object it allows "Selection" (current available), "Entire object", and "Update Style".
Comment 1 Heiko Tietze 2020-01-21 14:14:50 UTC
Reasoning behind the new dialog is in the URL field. Agreed to 1) but 2) "Update Style" feels a bit too much to me and "entire object" is not clear. Why not all objects on the page/slide, ie. "Page/Slide"?
Comment 2 Regina Henschel 2020-01-21 18:33:18 UTC
(In reply to Heiko Tietze from comment #1)
> Reasoning behind the new dialog is in the URL field. Agreed to 1) but 2)
> "Update Style" feels a bit too much to me

Why? It would be a similar scope as 'master page' for presentation objects.

 and "entire object" is not clear.

If you have a text object with several paragraphs and the cursor is in one paragraph, if you then enable bullets or numbering or change properties via the Bullets&Numbering item of the context menu, only this one paragraph is changed. That happens even if you have in a previous step marked all paragraphs to apply numbers for them.

> Why not all objects on the page/slide, ie. "Page/Slide"?

Such behavior is not useful for text boxes. Keep in mind, that on a slide, presentation outline objects, even in case there exists more than one of them, have the same purpose. But a text box is not only used for a list of items, but very often used as label of something in the drawing, or for giving contact data, or for providing legal information. You do not want, that all these text boxes become a list.
Comment 3 Heiko Tietze 2020-07-06 10:12:59 UTC
Citing the blog post: "Additionally, the scope is introduced where users can decide whether the modification applies to the current selection or to the whole slide. If the modification should apply to all slides that use the current master slide, then the ‘apply to master style’ option is provided via dedicated button. When this dialog is started from master slides respectively as style definition the scope feature should be disabled."

Imagine more than one text box or shapes on a slide/page. Users probably often want to change the bullets not only for one object but all. And actually it works as it was designed - apply to selection changes the current textbox on a slide with two contents, to whole slide both. And Apply to Master affects the following slides too. We need to disable the option in master and I haven't checked all the various configurations neither Draw.

I would either resolve this ticket or use it to deal with the remaining bugs. What do you think, Regina?
Comment 4 Regina Henschel 2020-07-06 12:41:02 UTC
It seems, I was not clear enough about the problems.

Open attached Draw-document and try it.

Bug 1
Select the upper text box, open B&N dialog and set the first level to A,B,C. Click on "Apply to Master". OK. Nothing happens.
If you are in Draw, then the button "Apply to Master" does not work. And cannot work, because the styles of text boxes or shapes are nowhere connected to Master. The button should be hidden in Draw. 

Open attached Impress-document and try it. Reload after each try to have a clear start.

Bug 2
Select the item "One" in the Text box shape. Open B&N dialog and set the Bullet color to red. Select scope "Slide". OK.
The Outline object changes its numbering style, but not the graphic objects, even the selected item is not changed. Press Undo. The change to the Outline object is not reverted. 

Bug 3
Click in item "Ten" in the presentation object. Open B&N dialog and set the numbering style of second level to "1,2,3". Select scope "Slide". OK. The items in the Outline object changes style as expected. But numbering in graphic objects is not changed.

So term "Slide" is misleading.

Bug 4
The numbering of paragraphs in a list in a graphic object can only be changed together, if all these paragraphs are selected. There exists still no option "apply to all items in the current list".

The current solution ignores, that the B&N dialog is not only used for Outline objects but for graphic objects too.

Bug 5
Go to Master View. Set cursor in the text "Click to edit the outline text format". Open B&N, set bullet color of second level to red. Click on "Apply to Master". OK -> Crash.
Comment 5 Regina Henschel 2020-07-06 12:41:45 UTC
Created attachment 162706 [details]
Draw document for testing
Comment 6 Regina Henschel 2020-07-06 12:42:22 UTC
Created attachment 162707 [details]
Impress document for testing
Comment 7 QA Administrators 2020-07-07 03:38:41 UTC Comment hidden (obsolete)
Comment 8 Heiko Tietze 2020-07-07 09:20:03 UTC
(In reply to Regina Henschel from comment #4)
> Bug 1
> Bug 5

Smells like individual tickets, doesn't it?

The scope section itself is a convenience feature implemented by design based on user interviews. Bug fixing needs to be done, of course.
Comment 9 Heiko Tietze 2020-07-27 13:35:40 UTC
Let's start with simple things first.
Comment 10 QA Administrators 2022-07-28 03:39:23 UTC Comment hidden (obsolete)
Comment 11 Regina Henschel 2022-07-28 09:22:51 UTC
The crash in Bug 5 is fixed by removing the button in master view. The other problems are still not solved.

Tested in Version: (x64) / LibreOffice Community
Build ID: 5df1bb4b1b222be00d25097660c4ee33542896ea
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: de-DE (en_US); UI: en-US
Calc: CL