New B&N dialog in Draw has Scope section with "Slide" and "Selection" options. It's strange.
If I understood right, then new B&N dialog for Impress just was copy to Draw also without any optimizations. Draw and Impress are different module anyway and we should make some changes there for Draw case.
First, Draw doesn't has a "Slide" thing. Second, we can create lists only inside some shapes or text boxes (that are shapes too) in Draw, but can't for all page! In Impress we can create lists on slide in special predefined area with own styles.
Possibly we should change Slide label to Shape label and change C++ code there that it works as we want in Draw.
Steps to Reproduce:
1. Open Draw
2. Create a shape
3. Create a some list inside the shape
4. Open B&N dialog from Format->Bulet & Numbering
5. Look at Slide label
There is a Slide label and I don't know how it works in Draw case
There is no a Slide label but possibly there is some another variant that works fine for list in Draw case
User Profile Reset: No
(In reply to Roman Kuznetsov from comment #0)
> Draw and Impress are different module
Technically they are the same, more or less. But different of course from the user perspective and we do use Slide vs. Page everywhere.
You can apply the number format to the current object (text box, shape) or to all objects on the slide/page. And in case of Impress it's possible to change the master, which makes not so much sense for Draw since this master is rather a static background.
So what we should do in case of Draw is
* Change "Slide" to "Page"
* Hide "Apply to Master" button
Code pointer is sd/source/ui/dlg/BulletAndPositionDlg.cxx
Seems like a dupe of bug 130069.
(In reply to Aron Budea from comment #2)
> Seems like a dupe of bug 130069.
So should we close this as dupe, but transfer the easy hack status?
Bug 130069 lists several problems, one of them is the for Draw useless "master" option. Because the suggestion to completely remove the section in Draw got no support, it is anyway necessary to create individual bug reports for the problems listed in bug 130069.
(In reply to Heiko Tietze from comment #1)
> (In reply to Roman Kuznetsov from comment #0)
> > Draw and Impress are different module
> Technically they are the same, more or less. But different of course from
> the user perspective and we do use Slide vs. Page everywhere.
> You can apply the number format to the current object (text box, shape) or
> to all objects on the slide/page. And in case of Impress it's possible to
> change the master, which makes not so much sense for Draw since this master
> is rather a static background.
> So what we should do in case of Draw is
> * Change "Slide" to "Page"
> * Hide "Apply to Master" button
> Code pointer is sd/source/ui/dlg/BulletAndPositionDlg.cxx
I attached a very simple (maybe too simple) patch for this bugreport. I literally hid the button. Another possibility would be to only create the button in Impress, not Draw, in the first place.
I'm willing to continue to work on this bug if this first version is not good enough. :) It's my first try, the LibreOffice code is quite big, so please bear with me.
Created attachment 166854 [details]
First version of a possible patch
(In reply to Sven Lüppken from comment #6)
> Created attachment 166854 [details]
> First version of a possible patch
Sven, can you send it into gerrit yourself?
Here is an instructions about LO development process wiki.documentfoundation.org/Development/GetInvolved
(In reply to Sven Lüppken from comment #5)
> I attached a very simple (maybe too simple) patch
LGTM, feel free to add me as reviewer on Gerrit.
Regina, please reopen if you think hiding the Apply to Master button in Draw is not sufficient.
Sven Lüppken committed a patch related to this issue.
It has been pushed to "master":
tdf#130526 Hide "Apply to Master"-button and rename "Slide" to "Page" in Draw
It will be available in 7.1.0.
The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
Affected users are encouraged to test the fix and report feedback.