Created attachment 157722 [details] ODT sample When I export file to pdf, unicoded URL interprets like file url See: https://bugs.documentfoundation.org/show_bug.cgi?id=125041
Created attachment 157723 [details] PDF sample
confirm in Версия: 7.0.0.0.alpha0+ (x64) ID сборки: 69ccba90135f4dfc22d4cb823e10cf4794ddaa04 Потоков ЦП: 4; ОС: Windows 10.0 Build 18362; Отрисовка ИП: по умолчанию; VCL: win; Локаль: ru-RU (ru_RU); Язык интерфейса: ru-RU Calc: threaded
There appears to be an issue with internationalized domain name top level domains (IDN TLDs) somewhere in the code: The IDN URL <http://транссеть.рф> (with a IDN TLD) is exported as a URL with a last segment of "http:%2F%2Fxn--80akxkhacg4g.xn--p1a%D1%84" (i.e., some code apparently decoded IDN label "транссеть" to "xn--80akxkhacg4g" and "рф" to "xn--p1a%D1%84", though the latter should have been "xn-p1ai"?!?, and then URL-encoded "//" as "%2F%2F" as it apparently decided for some reason that all of the input should become a single segment in the resulting URL). On the other hand, testing with current master on Linux at least, <http://транссеть.ru> (with a "plain" TLD) is exported as <http://xn--80akxkhacg4g.ru/> (i.e., with the IDN label "транссеть" decoded to "xn--80akxkhacg4g", which should be fine).
(In reply to Stephan Bergmann from comment #3) > On the other hand, testing with current master on Linux at least, > <http://транссеть.ru> (with a "plain" TLD) is exported as > <http://xn--80akxkhacg4g.ru/> (i.e., with the IDN label "транссеть" decoded > to "xn--80akxkhacg4g", which should be fine). (See <https://gerrit.libreoffice.org/plugins/gitiles/core/+/a346dfccd7e342d776dd59eb3ed128557e22a1bf%5E!> "tdf#70833: IDNA support when exporing hyperlinks to PDF" for why IDN URLs are decoded to ASCII when exporting to PDF.)
I have the same problem with Version: 6.4.0.3 (x64) Build ID: b0a288ab3d2d4774cb44b62f04d5d28733ac6df8 CPU threads: 12; OS: Windows 10.0 Build 18363; UI render: default; VCL: win; Locale: de-DE (de_DE); UI-Language: en-US Calc: CL
Stephan Bergmann committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/4c0394461af4d6bcba059161113abffbb484efe8 tdf#130501: Fix off-by-one error in URIHelper::resolveIdnaHost It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
(In reply to Commit Notification from comment #6) > Stephan Bergmann committed a patch related to this issue. > It has been pushed to "master": > > https://git.libreoffice.org/core/commit/ > 4c0394461af4d6bcba059161113abffbb484efe8 > > tdf#130501: Fix off-by-one error in URIHelper::resolveIdnaHost > > It will be available in 7.0.0. > > The patch should be included in the daily builds available at > https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More > information about daily builds can be found at: > https://wiki.documentfoundation.org/Testing_Daily_Builds > > Affected users are encouraged to test the fix and report feedback. Stephan, will you plan to backport it to 6.4?
(In reply to Roman Kuznetsov from comment #7) > Stephan, will you plan to backport it to 6.4? yes, <https://gerrit.libreoffice.org/c/core/+/88295> "tdf#130501: Fix off-by-one error in URIHelper::resolveIdnaHost"
Stephan Bergmann committed a patch related to this issue. It has been pushed to "libreoffice-6-4": https://git.libreoffice.org/core/commit/289d2e5c86ffa99bc6a8c6c51f630d629afcd954 tdf#130501: Fix off-by-one error in URIHelper::resolveIdnaHost It will be available in 6.4.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
(In reply to Stephan Bergmann from comment #8) > (In reply to Roman Kuznetsov from comment #7) > > Stephan, will you plan to backport it to 6.4? > > yes, <https://gerrit.libreoffice.org/c/core/+/88295> "tdf#130501: Fix > off-by-one error in URIHelper::resolveIdnaHost" Thank you for fix! Can you please backport it to 6.3?
(In reply to Andrew from comment #10) > Can you please backport it to 6.3? Do you have a pressing need for that? My understanding is that exporting URLs with a IDN TLD (see comment 3) never worked (and that the fix for issue 70833 by accident only made it work for non-TLD IDN labels), so this issue would classify as a non-high-severity non-regression. Therefore, I'm a bit reluctant about backporting, to avoid unexpected regressions.
(In reply to Stephan Bergmann from comment #11) > (In reply to Andrew from comment #10) > > Can you please backport it to 6.3? > > Do you have a pressing need for that? My understanding is that exporting > URLs with a IDN TLD (see comment 3) never worked (and that the fix for issue > 70833 by accident only made it work for non-TLD IDN labels), so this issue > would classify as a non-high-severity non-regression. Therefore, I'm a bit > reluctant about backporting, to avoid unexpected regressions. Yes. We have a need. Because we usually use the still version. These fixes make life easier for users.
Shrug; lets take the risk then, seeing that PDF export is the only code using URIHelper::resolveIdnaHost. <https://gerrit.libreoffice.org/c/core/+/88401> "tdf#130501: Fix off-by-one error in URIHelper::resolveIdnaHost"
(In reply to Stephan Bergmann from comment #13) > Shrug; lets take the risk then, seeing that PDF export is the only code > using URIHelper::resolveIdnaHost. > <https://gerrit.libreoffice.org/c/core/+/88401> "tdf#130501: Fix off-by-one > error in URIHelper::resolveIdnaHost" Thank you!
Stephan Bergmann committed a patch related to this issue. It has been pushed to "libreoffice-6-3": https://git.libreoffice.org/core/commit/6ce74c39d15a9e55cc2ad846e18e001509e95392 tdf#130501: Fix off-by-one error in URIHelper::resolveIdnaHost It will be available in 6.3.6. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.