Bug 130546 - Record changes and smart punctuation conversion causes pointless change and restores deleted text
Summary: Record changes and smart punctuation conversion causes pointless change and r...
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
(earliest affected) release
Hardware: x86-64 (AMD64) All
: medium normal
Assignee: Not Assigned
Whiteboard: target:7.1.0
Depends on:
Blocks: Track-Changes AutoCorrect-Complete
  Show dependency treegraph
Reported: 2020-02-10 02:12 UTC by Luke Kendall
Modified: 2020-12-09 10:29 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:

LO document illustrating the bug (11.40 KB, application/vnd.oasis.opendocument.text)
2020-02-10 02:12 UTC, Luke Kendall
Another example document, maybe related? (14.11 KB, application/vnd.oasis.opendocument.text)
2020-02-15 06:24 UTC, Luke Kendall

Note You need to log in before you can comment on or make changes to this bug.
Description Luke Kendall 2020-02-10 02:12:41 UTC
Created attachment 157759 [details]
LO document illustrating the bug

Have smart punctuation enabled (I mean, so that typing a space after three periods - ... - the periods are converted to an ellipsis.

Steps to reproduce:

1. Delete a comma adjacent to a word, let's call it WORD.
2. Type three periods
3. Type a space
4. Observe that WORD is marked as deleted, and inserted
   (this is the pointless change mentioned), and more seriously:
5. the deleted comma is also inserted, i.e. its deletion has been reversed

See attached file.
Comment 1 Dieter 2020-02-11 14:05:16 UTC
I can't confirm it with

Version: (x64)
Build-ID: 60da17e045e08f1793c57c00ba83cdfce946d0aa
CPU-Threads: 4; BS: Windows 10.0; UI-Render: Standard; VCL: win; 
Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE
Calc: threaded
Comment 2 Luke Kendall 2020-02-15 06:24:57 UTC Comment hidden (obsolete)
Comment 3 Stanislaus J. Pinasthika 2020-02-16 03:37:54 UTC
I am using Kubuntu 19.04 and trying in my 
Build ID: 4ff12ba6f4639c73587f2bb58afcc3ca6fb30105
CPU threads: 8; OS: Linux 5.0; UI render: default; VCL: kf5; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2020-01-24_21:09:14
Locale: id-ID (id_ID.UTF-8); UI-Language: en-US
Calc: threaded

but, it can't be reproduce
Comment 4 Dieter 2020-02-16 05:58:20 UTC Comment hidden (obsolete)
Comment 5 Luke Kendall 2020-02-16 09:45:03 UTC Comment hidden (obsolete)
Comment 6 Buovjaga 2020-06-27 12:59:02 UTC
Note: this requires Tools - Autocorrect - While typing to be activated.

Reproduced both on Linux and Windows.

In the 4.4 line there was a change. Old behaviour was that three periods were not autocorrected at all, if you typed them after the deleted comma. It should be assumed that the old behaviour masked the problem.

The change was https://git.libreoffice.org/core/+/b3b6361c555e54ce852d62c80c0bb3d19c1ec78f%5E!/
fdo#81571 autocorrect doesn't need space before (c), (r), (tm)...
Comment 7 Commit Notification 2020-11-06 21:39:38 UTC
László Németh committed a patch related to this issue.
It has been pushed to "master":


tdf#130546 sw autocorrect: don't replace redlining

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:

Affected users are encouraged to test the fix and report feedback.
Comment 8 László Németh 2020-11-06 21:39:44 UTC
tdf#130546 sw autocorrect: don't replace redlining

if it starts or ends within the removed text to
avoid various problems, for example, reappearing
deleted comma before ellipsis replacement:

text[,]... -> text,...[,]

or replacing words based on already deleted text:

[tt]he -> [tt]the

Add test/user-template/user/autocorr/acor_en-GB.dat
unit test autocorrect definition with three dots to
ellipsis replacement.
Comment 9 NISZ LibreOffice Team 2020-12-09 10:29:50 UTC
Verified in:

Version: (x64)
Build ID: 761a672d62df1891b9f4f367a499b220ab2b33fa
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: hu-HU
Calc: threaded