Bug 131493 - Performance regression opening presentation with shapes
Summary: Performance regression opening presentation with shapes
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
6.1 all versions
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, perf, regression
Depends on:
Blocks: Regressions-imageHandling
  Show dependency tree / graph
 
Reported: 2020-03-23 13:06 UTC by Xisco Faulí
Modified: 2021-09-22 19:37 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:

Attachments
Flamegraph (172.18 KB, application/x-bzip)
2020-03-23 18:10 UTC, Julien Nabet 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2020-03-23 13:06:45 UTC 
Steps to reproduce:
1. Open attachment 115778 [details] from bug 91436 with time 'OOO_EXIT_POST_STARTUP=1 instdir/program/soffice'

it takes

real	0m17,566s
user	0m8,840s
sys	0m7,280s

in

Version: 7.0.0.0.alpha0+
Build ID: fd1cd5522283f279a01d6d673f676a1346e9358b
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded

while it takes

real	0m5,371s
user	0m3,354s
sys	0m0,387s

in

Version: 6.0.0.0.alpha1+
Build ID: 6eeac3539ea4cac32d126c5e24141f262eb5a4d9
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); Calc: group threaded

so it's 3 times slower in master than before
Comment 1 Xisco Faulí 2020-03-23 13:08:32 UTC 
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=1b02ba03bd62a712e15c15384a3d105d2c088120

author	Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>	2018-02-13 21:49:57 +0900
committer	Tomaž Vajngerl <quikee@gmail.com>	2018-02-14 07:47:26 +0100
commit 1b02ba03bd62a712e15c15384a3d105d2c088120 (patch)
tree b46f383c7ea60de65dbbede5b658a7babd813610
parent 733d77570771e2536d5ce1f18ba82f68ac6c22ee (diff)
shapes: don't use "GraphicURL" property, always use "Graphic"

Bisected with: bibisect-linux64-6.1

Adding Cc: to Tomaž Vajngerl
Comment 2 Xisco Faulí 2020-03-23 13:09:03 UTC 
@Julien, would it be possible to have a perf chart for this issue ?
Comment 3 Julien Nabet 2020-03-23 18:10:18 UTC 
Created attachment 158897 [details]
Flamegraph

Here's a Flamegraph retrieved on pc Debian x86-64 with master sources updated today.
Comment 4 Roman Kuznetsov 2021-09-22 19:37:04 UTC 
It takes 4 sec in

Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: a9cc066a86c6bd3423c5802c5a4eded55a50c754
CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: en-US
Calc: threaded

Xisco please retest it