Bug 131506 - [EMF+] FILEOPEN: PathGradient background no longer displayed
Summary: [EMF+] FILEOPEN: PathGradient background no longer displayed
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Chart (show other bugs)
Version:
(earliest affected)
7.0.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Bartosz
URL:
Whiteboard: target:7.5.0 target:7.4.0.0.beta2 tar...
Keywords: bibisected, bisected, regression
Depends on:
Blocks: EMF-WMF
  Show dependency treegraph
 
Reported: 2020-03-23 18:15 UTC by Xisco Faulí
Modified: 2022-06-15 06:57 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
sample file (97.50 KB, application/vnd.ms-powerpoint)
2020-03-23 18:15 UTC, Xisco Faulí
Details
Comparison MSO 2010 and LibreOffice 7.0 master (83.21 KB, image/png)
2020-03-23 18:16 UTC, Xisco Faulí
Details
EMF file extracted from ppt (346.38 KB, image/emf)
2021-05-13 10:07 UTC, Bartosz
Details
Minified EMF sample (2.35 KB, image/x-emf)
2021-06-03 18:07 UTC, Valek Filippov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2020-03-23 18:15:43 UTC
Created attachment 158898 [details]
sample file

Steps to reproduce:
1. Open attached document

-> Chart no longer has blue gradient background

Reproduced in

Version: 7.0.0.0.alpha0+
Build ID: fd1cd5522283f279a01d6d673f676a1346e9358b
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded

[Bug found by office-interoperability-tools]
Comment 1 Xisco Faulí 2020-03-23 18:16:04 UTC
Created attachment 158899 [details]
Comparison MSO 2010 and LibreOffice 7.0 master
Comment 2 Xisco Faulí 2020-03-23 18:17:13 UTC
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=c3f0c527b31f5c88263ea63d3d0e332c4783917c

author	Armin Le Grand <Armin.Le.Grand@me.com>	2020-03-11 14:06:53 +0100
committer	Armin Le Grand <Armin.Le.Grand@me.com>	2020-03-11 16:24:36 +0100
commit c3f0c527b31f5c88263ea63d3d0e332c4783917c (patch)
tree bab3bd06413795688746dc95f9e92eca77203fc6
parent 367431b6987b75e7a201499bfbd25a41c92a4a59 (diff)
tdf#124424 Enhanced SvgGradientHelper for EMF+

Bisected with: bibisect-linux64-6.5

Adding Cc: to Armin Le Grand
Comment 3 Armin Le Grand 2020-03-30 15:11:23 UTC
grepping --- need to take a look
Comment 4 Bartosz 2020-05-25 12:47:43 UTC
Hello Armin, 
Do you need help with this issue?

Could you pleae give some advice what could be the cause of this issue?
Comment 5 Xisco Faulí 2021-02-09 13:07:05 UTC
Actually, it can be set to NEW, no action done in a while
Comment 6 Bartosz 2021-05-13 10:07:20 UTC
Created attachment 171952 [details]
EMF file extracted from ppt
Comment 7 Valek Filippov 2021-06-03 18:07:35 UTC
Created attachment 172598 [details]
Minified EMF sample

Only EMF+ part shrunk to "Header, Object, FillRects, EOF"
Comment 8 Valek Filippov 2021-06-03 18:19:32 UTC
EMF part has a StretchDIBits record with bitmap of the background gradient.
If EMF+ records are removed, then LO uses this bitmap and shows things correctly.

("disable EMF+" could be a sort of "workaround")
Comment 9 Commit Notification 2022-06-14 08:31:16 UTC
Bartosz Kosiorek committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/7b12c659842eb53b96dd98ecea65c6071506dfbb

tdf#131506 tdf#143031 EMF+ Fix displaying PathGradient fill

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2022-06-15 04:29:55 UTC
Bartosz Kosiorek committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/a1d4093bf44058c1d956717404817cb82a830521

tdf#131506 tdf#143031 EMF+ Fix displaying PathGradient fill

It will be available in 7.4.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Xisco Faulí 2022-06-15 04:44:44 UTC
Verified in

Version: 7.4.0.0.beta1+ / LibreOffice Community
Build ID: 76698a4a1c8e514962cc54fd9ddc73e39fce7177
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: es-ES (es_ES.UTF-8); UI: en-US
Calc: threaded

@Bartosz, Thanks for fixing this issue. Should this issue be closed as RESOLVED FIXED now ?
Comment 12 Commit Notification 2022-06-15 06:42:11 UTC
Bartosz Kosiorek committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/8419e2909aef8916111e4dce9c0a070464a06e66

tdf#131506 tdf#143031 EMF+ Fix displaying PathGradient fill

It will be available in 7.3.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.